| Message ID | 87b87381-2e22-423e-8dde-8eef241f1aab@suse.com |
|---|---|
| State | New |
| Headers |
Return-Path: <binutils-bounces~patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9D0293858290 for <patchwork@sourceware.org>; Mon, 9 Dec 2024 10:45:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9D0293858290 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256 header.s=google header.b=EJMSyq3p X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by sourceware.org (Postfix) with ESMTPS id 3934D3858031 for <binutils@sourceware.org>; Mon, 9 Dec 2024 10:44:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3934D3858031 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3934D3858031 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::336 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1733741087; cv=none; b=KHh1zexml2OVLX+Y6fiG74FVWCveJg+dSioetUyzXGKSDUE7nIibkNPrDnZyBo9/j4jwvWN7mNUXv2yxhtMNLNE9ZqyFCZzgZhLLEy7HweRZIq2X3L1muaE32tYO8iN3JrMuZYm+dqyyrUo0Ss3BA4r3M97ECLyExibPkoMI1iQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1733741087; c=relaxed/simple; bh=s458oBJLU0lyOUDV4AU0tUrAECtJYz3P9jC2y154b6c=; h=DKIM-Signature:Message-ID:Date:MIME-Version:To:From:Subject; b=EX+2TfffaS20O/UzNgMx2NiwKUdUo00U7h4fqkrEXD2M/ewPsB22kJ+Di8VQXE/03SZ5/yWL1Z5/CntQdLa5RPg6tr2HVOP2ypS6YAHfFWUmAH4b8cRCwvX7yWeCRfJPlvFoE7kExmSs5kemuysk4CT+Xz3ORiSvpqByhgyh4X4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3934D3858031 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-434ab938e37so26843215e9.0 for <binutils@sourceware.org>; Mon, 09 Dec 2024 02:44:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1733741086; x=1734345886; darn=sourceware.org; h=content-transfer-encoding:autocrypt:subject:from:cc:to :content-language:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=RJ9VpqsL4Yq3Fr8aCk3pF0K6eWFCcnVKa2E0ZOkzWL4=; b=EJMSyq3p2i1TiB0DtTiX0YEFfow1qAFZ6pZw0LhRTAorzowSCj5rQ+z8YKBnWeCxw4 8XBdKQgPPACkCYTW4x83Xfrom4/3jGCYhxPC+eY8Mj16WUJeF4NWFrLWWUCqTZxWxPFa j3tlzpnKSxRGv39qjU4MM/kKnygePGsYirnB/JTvvXKRi/8TxSBogViFIB3HxhgsATbb gDd7IqPQVBFLjUoydRBV3jknUivK1fvtQjKZ+6LBW36Qsag5SI6NdlwaBGgaJ6aNn0gY 8HHEjxPC3aQjNsIEip/lqcDisPWAhLvH5JoN/vzzG9COWsJhO5CATMgzXAzsRbSDIANS dEIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733741086; x=1734345886; h=content-transfer-encoding:autocrypt:subject:from:cc:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RJ9VpqsL4Yq3Fr8aCk3pF0K6eWFCcnVKa2E0ZOkzWL4=; b=Gf1+IUzg0liewSSg16iyy2M6X9YJoL/mYOHZDMDtDMHNwaODmQtDEOUN6Wrk5++U5M UCmTiKVMTQU11A8MxA5A3Z+LIFwxXTVn6/ruRbM33VwW9D69tj2CRGY7ENq0viJCkUDp rOG6DP9m+CDdlUSzKweqfP7sxnYRVRNEal6AtZwOv62p3vbjOWXDajjYOcu24RviehTK qrUTDr8mh5mX4wwAvK1R4uw4Ub+TTFdso8uQFsoxDNgjb72974zyPzYUzMoETlt3jtC+ bs+5JKoTdVxUY8t1ihTgL8IDeFb8PCziFiRv6I9juloiSedKuVhvpDe6r/2SNzPGdg3B 4Lsw== X-Gm-Message-State: AOJu0YwbZYFGaLXjDKhr3V7vQgnF2vTht4fCVij4BptmhfoUlZPY1zWb e6KqedENI1/R5y60gG49cBnDGeMoPCL3gR0a7nmtXUSZFVQNKKANaVjy1+wX5PVmP7WAgmoO3zc = X-Gm-Gg: ASbGnctrq23IYPWvgVjTlUg7r6HEEAU6gpmBgCbTUiJywj2TI20GuE+mk9DJ9ZQiH3n YJXLfktNBrbM/oq6zk5ttqqUK+1MxDdnll4BlKE6avzk7Fh2lLPHP8IeUUPFsvb1vDHuu40h36Z VL32bK+t8vQyFuq5aDGURGnnzkbhTP1AvkKila2yUQ3IxdOF3dXTqkaebNhdSmzB/tuMkPBh4UC PbHxZtDiigpw+YI3WBlTrgCO+FFw91t6I4OJolV/rFJjqlCOKHk00tNqsSCVX73zE3RqLZ637ew yDmNlJsGsR7Kk0MWKkNz9fVbAWLcmK1ISPs= X-Google-Smtp-Source: AGHT+IF6tLolRAPJl9u8IBfw/AoqSbg4Qr3Hp3PTuGk2yOzW4nK+Ve2vsXgm+ha2+DIWr9Iv6DhY4w== X-Received: by 2002:a05:6000:4213:b0:385:fa2e:a33e with SMTP id ffacd0b85a97d-3862b3d08e2mr7749117f8f.43.1733741085947; Mon, 09 Dec 2024 02:44:45 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-725d3dd4cbasm3819035b3a.142.2024.12.09.02.44.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Dec 2024 02:44:45 -0800 (PST) Message-ID: <87b87381-2e22-423e-8dde-8eef241f1aab@suse.com> Date: Mon, 9 Dec 2024 11:44:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Binutils <binutils@sourceware.org> Cc: Nick Clifton <nickc@redhat.com> From: Jan Beulich <jbeulich@suse.com> Subject: [PATCH] msp430/gas: correct BFD_RELOC_32 handling Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3022.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list <binutils.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/binutils>, <mailto:binutils-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/binutils/> List-Post: <mailto:binutils@sourceware.org> List-Help: <mailto:binutils-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/binutils>, <mailto:binutils-request@sourceware.org?subject=subscribe> Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org |
| Series |
msp430/gas: correct BFD_RELOC_32 handling
|
|
Checks
| Context | Check | Description |
|---|---|---|
| linaro-tcwg-bot/tcwg_binutils_build--master-arm | success | Build passed |
| linaro-tcwg-bot/tcwg_binutils_build--master-aarch64 | success | Build passed |
| linaro-tcwg-bot/tcwg_binutils_check--master-aarch64 | success | Test passed |
| linaro-tcwg-bot/tcwg_binutils_check--master-arm | success | Test passed |
Commit Message
Jan Beulich
Dec. 9, 2024, 10:44 a.m. UTC
It was likely a copy-and-paste oversight that bfd_putl16() was used here from the very beginning. And of course there's a difference only if the value to be stored is different from the value that's already there; typically both are 0.
--- a/gas/config/tc-msp430.c +++ b/gas/config/tc-msp430.c @@ -4541,7 +4541,7 @@ md_apply_fix (fixS * fixp, valueT * valu break; case BFD_RELOC_32: - bfd_putl16 ((bfd_vma) value, where); + bfd_putl32 ((bfd_vma) value, where); break; case BFD_RELOC_MSP430_ABS8: