From patchwork Fri Dec 15 13:32:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 82251 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B6A9C3875466 for ; Fri, 15 Dec 2023 13:32:45 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by sourceware.org (Postfix) with ESMTPS id 2FC2238708C2 for ; Fri, 15 Dec 2023 13:32:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2FC2238708C2 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2FC2238708C2 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::62c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702647151; cv=none; b=OPvfAqzV1UHgB86+jn8SzW/2X2kqKyCc8xQHK8m05dy78O+Q6xb7T63ZN8zu4ffhaXetcHMH4AGh8l8aB78HwFPbUGYVj+8ETv2mBXZ0Zr6HPyBLCXsHQM/kIrQJVbePyYHNQY+SYfgm3hHYeCyhMAmQVCZ3uY83+E41YWZwsCo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702647151; c=relaxed/simple; bh=jRzTCN8q65T4pShHX9yypsIOOrVdd/WUu4mZ6KExIUo=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=PMnbw2WRQ6/Xn9gbhNbDVncNPHhySn3mdC1tlTn2IzLMVie7IbByQeead3+hLSqrnq18xZpIWHPmEP+dejCy/GLugVtNz/pqRJ5yPoNfzxYQ5aLDssk+I+qlm3z5R9Mtlm7565tbNiK35mYyOzCCXRnSQ2vLduJVp6Xa6iGmID8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-a1f8a1e9637so112689866b.1 for ; Fri, 15 Dec 2023 05:32:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1702647148; x=1703251948; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=5hvlNWEB6P67gnJAVlcqcfb4GXQgoDUBUyieTHjDP+U=; b=gDbEnTeDzkoLixpvTb4rl4efYlfk7IBVME0omLcy0PVmvFddZAd7A/O1Yk3hveQklC gQN2zdkKLVCwq/1MNjkDlPnvzIr41pKMsLRKWkP5/Ns3Y8yHWGgR4aohVSW9V9xmvH0J wPrZh9af71qgP5ZySXZkxUtrSwcRkui0VH6ftPKKwtpNq+7EQEUc2I4w4MghFqzJAgl7 OWwX1YbCUWgZ4KeOcWRfQnj/ZdQz9ep4PFjxgJx6Ive8CJBzTS5pqtwBZKgm5R4JorTa r7SnUS+Uq2NjljNNp9Hdn31WO2f483axe2JjXsWM+7bNGa5PG6ev0GwJQkefkpPVoVVr ZLPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702647148; x=1703251948; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5hvlNWEB6P67gnJAVlcqcfb4GXQgoDUBUyieTHjDP+U=; b=Z2wBMQF6Wo1rjIVPdUesdWnkVuwc4SZ2KgfkPcFm0Zr3+/UD+P+pusrPNOWQqA6ze7 4V5k1wfIckr8lhX2fHzy5DPzJ+oScVnR2A6IDKREXTOU5tqHxbau6dl3jRehXK+xYQBP iDxm1kwajOaeDsn7FN2YSctyr5f9T8/5Dlq0DMlcdLm3r8F76spc9qbTy5UJFmp8QmKz 34+MCvJcCU0BFXQ7HMHo98UcsXtX7v/yJ2PpaBo788HES5x5RTXMfuPqe3qgVsdqeTIe 7O64yotjzPgM9n7Y9T4EyjBqiU+1xp21IbsG9pWSntVAJR7Z4bsTIkoCKvo2OjLSF7yf Lr3w== X-Gm-Message-State: AOJu0YzB0xNTobTrJtzp1O51AyjLKaQwpKv3h4T0owR+Sj4mbsio6+gI 6Cx/dlcBLktwM3Tn1KAs6jHVpysk4oAncPo3BcfG X-Google-Smtp-Source: AGHT+IH+LenqyMV4zt/fbvwE5JUz5f0oer757ZKI0aOiNxUK7D5gy05+24P3eMBgeAKpi/x93Z07GA== X-Received: by 2002:a17:907:aa6:b0:a1e:5a8a:674a with SMTP id bz6-20020a1709070aa600b00a1e5a8a674amr14789965ejc.19.1702647147840; Fri, 15 Dec 2023 05:32:27 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id bq5-20020a056638468500b00468ebaadd2dsm3954559jab.152.2023.12.15.05.32.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Dec 2023 05:32:27 -0800 (PST) Message-ID: <870d2722-85a5-4ab8-9680-4b1c4e8f98af@suse.com> Date: Fri, 15 Dec 2023 14:32:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 2/2] x86-64: refuse "high" 8-bit regs with .insn and VEX/XOP/EVEX encodings Content-Language: en-US From: Jan Beulich To: Binutils Cc: "H.J. Lu" , Lili Cui References: <663a2bcd-188c-42d9-9147-9f5d1e627429@suse.com> Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <663a2bcd-188c-42d9-9147-9f5d1e627429@suse.com> X-Spam-Status: No, score=-3026.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+patchwork=sourceware.org@sourceware.org Much like REX, those encodings - if permitting 8-bit regs at all, i.e. only starting with APX - permit use of "new" 8-bit registers only. %ah, %ch, %dh, and %bh cannot be encoded and hence should be rejected. Permit their use outside of 64-bit code though, as "new" registers simply don't exist there. --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -11484,6 +11484,16 @@ s_insn (int dummy ATTRIBUTE_UNUSED) for (j = i.imm_operands; j < i.operands; ++j) { + /* Look for 8-bit operands that use old registers. */ + if (i.vec_encoding != vex_encoding_default + && flag_code == CODE_64BIT + && i.types[j].bitfield.class == Reg + && i.types[j].bitfield.byte + && !(i.op[j].regs->reg_flags & RegRex64) + && i.op[j].regs->reg_num > 3) + as_bad (_("can't encode register '%s%s' with VEX/XOP/EVEX"), + register_prefix, i.op[j].regs->reg_name); + i.types[j].bitfield.instance = InstanceNone; if (operand_type_check (i.types[j], disp))