From patchwork Fri Jun 19 11:52:18 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 137426 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BB6264BAE7C3 for ; Fri, 19 Jun 2026 11:57:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BB6264BAE7C3 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256 header.s=google header.b=HW+I65D4 X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by sourceware.org (Postfix) with ESMTPS id 074234B9DB6A for ; Fri, 19 Jun 2026 11:52:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 074234B9DB6A Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 074234B9DB6A Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::434 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781869940; cv=none; b=VmUbwKv9qQzt7cqS9vfVtgkkoo/78e9SetilXeL63YK1zJSi8bMsLh02+97+WgZhB4Q+Ll7v782N01ii5354k/FfAla1sz5BQXU/5WPBTQ2O6pD8W/xeHCWTERu/vOHz4Msk+U2Fz7dtPXA86qLZB4LcjFAxY1lh9+5UDf2R570= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781869940; c=relaxed/simple; bh=Ia9K8BMDeQuQC/CtsFX7vNubel2r/ma3KLkTw2n3lik=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=k2iRi/EbFN4jD3rD0If5IZBInGhztSlzpAbAQj4NynNzOvOn3dqIvA6PWG5fPNqdtYqdvtlocgvvj52I5ZCswlIzELkmk66q8aGP94/51STO7tLGhzM35sIjhKJAb4Dt39gh4o34vMmBlBtJ6iPbCsTQ0K2BbyhNiTIitcsNZvI= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256 header.s=google header.b=HW+I65D4 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 074234B9DB6A Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-4602e2a0372so1629328f8f.3 for ; Fri, 19 Jun 2026 04:52:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1781869939; x=1782474739; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=HPL9LTdiPDp/z5/hMVx4ow9SeygOP3VZgxdZHYqhqYM=; b=HW+I65D4uDaVDs3QxCydyfhrQ4wfAf8to0ymFd8dPVFbNDDu0/4E0r76NqMYqaWo/I pHU/nr++pfnc4X3fPdZZOA/Ge2RspErK8+9y2IfbHntZG68Y6clmXKaiqRzbED/ZH5ps Q/fTfuX7G1vPKPQEd3wNUArX6rBizgCCaASf/6E6S0PIVUN9WFR0TSKXOEzRPA1abn5a IIkHgbj5lUkWoAWiBS/eQZdcDleS4FGv0dekob93DWfHX+MRLn86xoQ4mZsM0k9ojwVA HJLGowLrPREPr86ChnOz2vcAJnqtslP4AgvCTiNFp4c1cuzLvjH+vpUSvq96Xtowl2JS 7T5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781869939; x=1782474739; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HPL9LTdiPDp/z5/hMVx4ow9SeygOP3VZgxdZHYqhqYM=; b=nC3eM1Ov2x/7LcWx5voCjYTA6jJKmAARho0+gftr2Uu4DZZJ3XdcK15alW6n4BYtFj 17L4b2fp5YA9MrcfuAFvoliYBWHp+m7QLo7Y0RbPDSXou3h1p/51t0ZV6nSNrdZVxyME 7JJ7IA9dXzlvyV7gProrLnHHEnLS0lnHibSCYwmeglJcXiBqrwpQCyXs4lfQ16zMgJAw syaZhRSSnz63Kl34efA2zSirtJltK44WUP6hxOkw3OsF7fSBRSLxqWHyNhJVNW1REOl5 Zckb/h0PlKsEECO/cV2WKGxEUjwOWh0wk4oNzfPY4ahmdzoARbWomuzQ1ZUVjMhqbt+s e9aA== X-Gm-Message-State: AOJu0YytUQKX1p0fVB9vHCA/Whn1TCiYV4jeBFTTke5oGoO975EnXtsh yT/WfNgrG9nKjHZ20mkfyMZz9NDO/SZkLRr751YzzbjODmeFznyPpcp2TPM/eQJE2Lc6ZD96KZh ka9G5fQ== X-Gm-Gg: AfdE7cmT0PFTumItePvqo2H6ZSXx5r54U78URiQaK9w3xaz0KpplKe8yxxlyRJfUtRY cR7KCkWWPZr24qSuSF7K2HbBmEDjE58p7RM8LOw3UjMgHWC7aaYL2G955T1FWoxlPowWSmjZhtH q9z5X5tflZL1FAihx61Yvfxb1HBIJ3t0ixUBVJXaQTExeGVfzliwmqsHVJl15tBUKYLx5S+EsPS AdudOd2pVVd89q91xmhh9WK6lI4xd0NK29gEKlWC0jHWT58UWPW+NEyyk0NO5I6M/V2GE5rvtN/ yL4AN8sCQoOkR6mO5emkN9PLB7OGbBXYoNQeny+eMpnPNFkKpbjlkl8oqvgqoF7DurCFybutLqV LPbxbJFY+5sMaTaSj8Hx7k/9CGPbxurXbL6SuBN2N4+DhguE/1ywyib74IrgPD0S0phe4e28b07 yGLDrf6tLthcbKbcK/uMPm3cB8TPyHHVoHQ8PLkyLqAcF4PRBsEGtTAy6fabFU5GMlBfXYaCDuA ubh X-Received: by 2002:a05:6000:2c12:b0:460:3233:bee9 with SMTP id ffacd0b85a97d-4656ef8df84mr3223870f8f.41.1781869938927; Fri, 19 Jun 2026 04:52:18 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4650b76e7c9sm7522209f8f.21.2026.06.19.04.52.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Jun 2026 04:52:18 -0700 (PDT) Message-ID: <70bdd397-4326-4c00-841b-7e4a57c82919@suse.com> Date: Fri, 19 Jun 2026 13:52:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v3 11/13] RISC-V/gas: warn about non-power-of-2 stack-align attribute From: Jan Beulich To: Binutils Cc: Palmer Dabbelt , Andrew Waterman , Jim Wilson , Nelson Chu , jiawei References: <8243b692-4895-420c-b2d0-27ee3b714732@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <8243b692-4895-420c-b2d0-27ee3b714732@suse.com> X-Spam-Status: No, score=-3016.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org Only power-of-2 values are sensible for alignment. Reviewed-by: Jiawei --- Should we reject changing an already set non-zero value, like riscv_merge_attributes() does? Should we permit 0 as an explicit indication of "attribute not set"? --- v2: New. --- a/gas/config/tc-riscv.c +++ b/gas/config/tc-riscv.c @@ -5902,6 +5902,13 @@ s_riscv_attribute (int ignored ATTRIBUTE "any instructions")); break; + case Tag_RISCV_stack_align: + if (!attr[Tag_RISCV_stack_align].i + || (attr[Tag_RISCV_stack_align].i & + (attr[Tag_RISCV_stack_align].i - 1))) + as_warn (_("`stack_align' attribute with non-power-of-2 value")); + break; + case Tag_RISCV_unaligned_access: if (attr[Tag_RISCV_unaligned_access].i > 1) as_warn (_("`unaligned_access' attribute with non-boolean value")); --- a/gas/testsuite/gas/riscv/attribute-warn.d +++ b/gas/testsuite/gas/riscv/attribute-warn.d @@ -4,4 +4,5 @@ Attribute Section: riscv File Attributes + Tag_RISCV_stack_align: 65536-bytes Tag_RISCV_arch: [a-zA-Z0-9_\"].* --- a/gas/testsuite/gas/riscv/attribute-warn.l +++ b/gas/testsuite/gas/riscv/attribute-warn.l @@ -1,2 +1,4 @@ .*: Assembler messages: .*:2: Warning: `unaligned_access' attribute with non-boolean value +.*:5: Warning: `stack_align' attribute with non-power-of-2 value +.*:6: Warning: `stack_align' attribute with non-power-of-2 value --- a/gas/testsuite/gas/riscv/attribute-warn.s +++ b/gas/testsuite/gas/riscv/attribute-warn.s @@ -1,3 +1,7 @@ .attribute unaligned_access, 1 .attribute unaligned_access, 0x1234 .attribute unaligned_access, 0 + + .attribute stack_align, 0 + .attribute stack_align, 0x4444 + .attribute stack_align, 0x10000