From patchwork Fri Mar 27 14:13:25 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 132378 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id BB72C4BA23EE for ; Fri, 27 Mar 2026 14:20:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BB72C4BA23EE Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256 header.s=google header.b=fvmafwn+ X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by sourceware.org (Postfix) with ESMTPS id A81C74BA23D1 for ; Fri, 27 Mar 2026 14:13:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A81C74BA23D1 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A81C74BA23D1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::331 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774620808; cv=none; b=Uzx5WthwYWrq6H+6tE3Key+M+z0u5CAjXQipa0yLJwEf7qrHJPSg9a2dXrJlRc9awZa911+Y+6VNDZRtwCVJmopVv3PtAt1RMbZj0NwT7Lr4Y69Tns4WU15Yz+2Sb8KLXdV2YTiPL1upoB5QJqpg+QAmg7eIXx+S+xv7Nh/0ftQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774620808; c=relaxed/simple; bh=5A0MYh4yfhwFJbznmPAl0WQZ9oR+9os5odpAWP2Lmf0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=sATyRY/QlzrZ1OYOIjVZd8cXVJDANAVGsKBnh5QhpUYJXT9CMPpv6XsN40LKICogt1yMEYSiaPCTLVHCzrqhKXIdzEeh6T4I89kfeOGgUY/lDjiMHnM8qn0HuuJjc6qXwlAQ0v5FUbDTXar7eNBMuvyUWmoQQoEa7gJDe9tM2qM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A81C74BA23D1 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-48700b1ba53so20701415e9.1 for ; Fri, 27 Mar 2026 07:13:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1774620807; x=1775225607; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:cc:content-language :references:to:from:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=f6OPggsMFUqsSUIlZpy2sNd52RN8/zE5+JCWGyvJ1SE=; b=fvmafwn+ZRLOb1cvleaoLKNlcsXy+Dzg+gUFSsUdtvdR6P7WXFggjWn6TbmL7hhLqQ KeEWKiyE+sKJe7ekSvIbJuWlYSeKnkc5JbKAK8U5cx3PSAN0dsHCttlG0/M+dkcNykjI O33McuCDkndAEYEwSMS9jmVsD2YAl4P5rYE7XYaqP+HkcCndkSmYpUpYRhSFqQ3UoioA BlRgOPBcgOJCXDW+726PnE6rjQOmX1y8+y3tLpHt3rtBYmOqn8kxFs26JuNfn6A3Ue5v zhwwIyC6NacIiUcYSWlv1QU+ESfMma9hM/1D1MEpTG7Qe6/KPFRUs0oP6hn6RVnfG/bl gNMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774620807; x=1775225607; h=content-transfer-encoding:in-reply-to:autocrypt:cc:content-language :references:to:from:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=f6OPggsMFUqsSUIlZpy2sNd52RN8/zE5+JCWGyvJ1SE=; b=XV3MfyGpKS1tlN4YRSuvs3A64CYzFMy7Eiy2YNhAQUr6zZaKto9FxAhDoxhwCywtrD CcizPZB7Px0DbKWhSaZkDpgcHGSzkxal+y2Idoyv0AO7ZHWoK2lDFGzGvHFlECY0OE0X mm15FcReF+VGvGafwARoXGb90gLGqZMzTgMt06crW2I/DYFlgIUQ1G1Yet9ibFIrJM+G h9HoaJE3L5QSgA87mYWAJ0vDeOWbCLfy5260ZmGOMbTptJMemUusRpKAgSgjWuxT4dZZ 2NrCRysb/jaX54tV8Sj4VCQuBlGYduVXv60ZS9xnnHVOUECG7S234T3BoNlnjf+SGp/3 9pAw== X-Gm-Message-State: AOJu0YzK6t6Os7wqIUNqeISy64dQ0xcTivCtOJKu2KcYTXFGqDm9+z3W MWX4WObp7rsoDCqXBiyUVF6o0edvHq4vpKIRssH2cxLGxlNeAY8PsVzVCbkJ2/ISkqtbVduY/eG ofgRUoQ== X-Gm-Gg: ATEYQzyYuvZzSY4vlXypM2UceloWOQK6r4QBqGzjPWGw/0yLMFKyjCWAD2bdIyosOKK o/O6nP0m/bPlP0taEKetWE3Cy3Os5epFo8wCzaeMOoLTQmd47s6NpSKQp5U3siCEPQfOro62X5p gATBv69c2bjO3txnzcORQgxhUmS2xJdm5XiKw6tlmdpZQuFP3RE+TQxpF4cSh6RdLeYpb3ZmcjH mFRAR6mtAGiBMKaDXLq+W1Uj4c21vDA9f6Yhlt5Dw6w1F2t/E4qcA0W1QyWQRfbJC1wE17CGvI5 A/oycYFHedC5txAVRoPu6GwI6SqvykVbGRQ+S7PmGr86AF9ey1YxcEPv5qo5E9BOw4urpxwSRF3 xSBIPb6Eu2Q+iUjLAKtUL0/wwXOtt1igWWy3sIvVwuKeWHLj7cz1ETXiiNKJX352SC8iXviz9Lk Zh+bwQZMt11Qt7xCpaGvA9zjizrdNEDfXbK/0Ds3J3KEzoLOFbw7necQK3eVKKCF16kesKnzAfz 4rw66F85paZNw4= X-Received: by 2002:a05:600c:8b70:b0:487:467:42a2 with SMTP id 5b1f17b1804b1-48727f7b571mr44785795e9.18.1774620807377; Fri, 27 Mar 2026 07:13:27 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4872712b2e7sm16735635e9.17.2026.03.27.07.13.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Mar 2026 07:13:27 -0700 (PDT) Message-ID: <58a1afc5-183f-483a-ba48-1e7f30f88675@suse.com> Date: Fri, 27 Mar 2026 15:13:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 6/8] x86/AT&T: make GOT-relative expressions work From: Jan Beulich To: Binutils References: <04ccd34e-7b05-412b-a0fe-2039e323f7d1@suse.com> Content-Language: en-US Cc: "H.J. Lu" Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <04ccd34e-7b05-412b-a0fe-2039e323f7d1@suse.com> X-Spam-Status: No, score=-3016.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE, SPF_NONE, TXREP, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org The expressions used in intel-got{32,64}.s should equally work (or not) in AT&T mode. Changing the Intel syntax parser such that O_symbol wouldn't happen to be wrapped around such expressions breaks it there, too. It really isn't correct to limit this to just O_symbol. Permitting O_add and O_subtract as well requires taking care of the other operand as well then. (Strictly speaking non-zero offsets aren't very useful here, but then at least with an equate of 0 this ought to work. The non-zero offset in the testcase helps demonstrate that this offset isn't lost.) --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -15081,13 +15081,26 @@ i386_finalize_displacement (segT exp_seg || i.reloc[this_operand] == BFD_RELOC_X86_64_GOTPCREL || i.reloc[this_operand] == BFD_RELOC_64_GOTOFF) { - if (exp->X_op != O_symbol) + if (exp->X_op != O_symbol + && exp->X_op != O_add + && exp->X_op != O_subtract) goto inv_disp; if (S_IS_LOCAL (exp->X_add_symbol) && S_GET_SEGMENT (exp->X_add_symbol) != undefined_section && S_GET_SEGMENT (exp->X_add_symbol) != expr_section) section_symbol (S_GET_SEGMENT (exp->X_add_symbol)); + + if (exp->X_op != O_symbol) + { + if (S_IS_LOCAL (exp->X_op_symbol) + && S_GET_SEGMENT (exp->X_op_symbol) != undefined_section + && S_GET_SEGMENT (exp->X_op_symbol) != expr_section) + section_symbol (S_GET_SEGMENT (exp->X_op_symbol)); + + exp->X_add_symbol = make_expr_symbol (exp); + } + exp->X_op = O_subtract; exp->X_op_symbol = GOT_symbol; if (i.reloc[this_operand] == BFD_RELOC_X86_64_GOTPCREL) --- a/gas/testsuite/gas/i386/x86-64-gotpcrel-2.d +++ b/gas/testsuite/gas/i386/x86-64-gotpcrel-2.d @@ -8,4 +8,6 @@ Disassembly of section .text: 0+ : +[a-f0-9]+: 48 8b 05 00 00 00 00 mov 0x0\(%rip\),%rax # 7 3: R_X86_64_GOTPCREL foo-0x4 + +[a-f0-9]+: ff 35 00 00 00 00 push 0x0\(%rip\) # .* 9: R_X86_64_GOTPCREL foo\+0x4 + +[a-f0-9]+: ff 35 00 00 00 00 push 0x0\(%rip\) # .* f: R_X86_64_GOTPCREL foo-0xc #pass --- a/gas/testsuite/gas/i386/x86-64-gotpcrel-2.s +++ b/gas/testsuite/gas/i386/x86-64-gotpcrel-2.s @@ -1,3 +1,7 @@ .text foo: movq foo@GOTPCREL(%rip), %rax + push foo@GOTPCREL + eight(%rip) + push foo@GOTPCREL - eight(%rip) + + .equ eight, 8