From patchwork Fri Nov 28 11:30:05 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 125500 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DCFD03857007 for ; Fri, 28 Nov 2025 11:30:51 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by sourceware.org (Postfix) with ESMTPS id 77733385842D for ; Fri, 28 Nov 2025 11:30:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 77733385842D Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 77733385842D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::333 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1764329414; cv=none; b=EnHubmIpmiigheLJgPQceLfmlbIOHBFoZS662DfjJsUg4uV4beXoXliZxL+LgDtQHsbqiNIFupRWaVyzGQMheSYrGaoJhCm9WDTqGLEKyVwI+lL4Esu90oXHe7MvYMzsqUfFK+ZHS54DgbK0koILbTI7p3aa1ZET2o5OzmPxdk8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1764329414; c=relaxed/simple; bh=TbDGqHFzO7y9G/5L6ZyjcuhqqBxoNRkwUGxAyPTlmRE=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=hK3qJkCJoV+7hEg6aZc0wQWwHQ4V2cNKCxxL8zcZvTvy435W/Plv8wjdfknbRiZzFpST9WJu9aW1KJuoLUh3DNzyfx9n4fh3QvM5yVSv0W5UL4LTG3mOxigCe/jm7P2Hl/dLhI2qY0BG7vlZLJtV6A0E1uDaiV8YlzFZHcXx4f8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-4779adb38d3so11784165e9.2 for ; Fri, 28 Nov 2025 03:30:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1764329407; x=1764934207; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:cc:content-language :references:to:from:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=E8qGQg+rBYv7OYHkVIdhCPCkqJ6WVxeRMAIcT+fYVJw=; b=bZHaUb+NpTz+bhhaEMLzE/S7XCRxspz+hd9wucizyynh7+Z6vh45o4GiULZZJ7olv/ fSX8+sIwJoPMKQfEoUzyK50DozWvwUM7s0Zme2BlUx9n7v9q/5bEDjtEOYUeXgxhB/5W fIVVz6JcjbH+jkFGoF7H5wJlmVNslulr5BQzb007dMjDRPc8sK36s0hX4+jd3KBn9KPD 1rZoDaquCfDXYY6W/OdC2oh4cw5AW+BgvgcYtdfRSAoc9wuRh4//MazeNTac2V58zMaE BBOJKngtzXi1UK0I18aGtdO/QlY+UiTTMpe0yDU3CyIQHg2gfzmBOgrmCsTMusIEJTcz nW+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764329407; x=1764934207; h=content-transfer-encoding:in-reply-to:autocrypt:cc:content-language :references:to:from:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=E8qGQg+rBYv7OYHkVIdhCPCkqJ6WVxeRMAIcT+fYVJw=; b=sDqndufoM6YGOEzLDgUtJp6/+rcuBQn7DmPuG3ctlNwM0ZVnLHQhHYfGH/Q+nrAJe2 YxeRgTt7XL7LvFdxKWgGBK9HY+MsrEMXRxophbx4izrr7m7dT9N/UhfR9h4BkhQu283n DIETIJ/IS2BwHrc0Lhpn/mUAQWkKY6fceX3ttjzETJoq2pbkulcV0g2VPgTPUDPqzGoD KruUyYLBHz5ciwhAlo1XmZnp4N5ALwkhwMDIwt/LcsfrKlamoXoPZzLSdn3rLQrKgH9G 8c4/zmekrQFgO8Vxq1bzh1kxoAzhERvRxrN2Jl6ZdWlYx2y1iosHAjXKElrseOGk3E+g 1MbA== X-Gm-Message-State: AOJu0Yz3pANIu/rHchPie5JNVuFjaFWdY+1lk8z0esa3fpJQRrTVCSuJ fC44tzZaYOFx9Y0WePTe/IdoUQ0c5CQzq1oanjNSlOPbHu9v4i/A2Vx0gr356AliFD90H7CiJUt aM9U= X-Gm-Gg: ASbGncseaLf/R2zEKQeMKJmLLQCy51AnDsWPYBL+dLNy6fik5HKQzhL8sBlm3fzSJO1 SoohlqXPpjtKrJmRgun8y+CPzZSF7SzkfKUH4eGnorfg/+9HcazbtqkwvWfeZ+MKE5OV1Q7jpzA glNsTw5aY2AuBLEolEkHBKIYnjSY1Tan1lli84MuV+02FXtUjpnRsMogzhT6xhcl47432kHKdQe XoTX+GnJICc5GfhcU5dCwk0GBikUiBJei/EPrfhXQA+tr15TX9X3VrNOFKFfHTkIeWK8JrMQTM1 SEZaGIxc+25jHAgbIg3QTRSB62Pj4XdJIAPIMfh1li2k1eMXwVcKiOVMH4cGqQucwpNO85bwSMR jOUIotdYigxZOz8rICo32FkdQG/kqS03SKKbJAOWQwFJ6gYvgE6HtGmJj5ARsKnIBm8vq6Z0eRa 53njot7TVk6baNLzxLl2ltd3i/g1HMSX9tOMjQvzrpjyWy3/WuQbSboEREP1e704v2xJ2qfrRAd jQ= X-Google-Smtp-Source: AGHT+IFN7Zo09ZFzTuzh9vovODzhD5xGU+LbEZi426tzoRdkQD2MtBoRPA/tUbqK/BR1eanjoUkdlw== X-Received: by 2002:a05:600c:4f41:b0:477:942:7521 with SMTP id 5b1f17b1804b1-47904ae2429mr165275725e9.14.1764329407073; Fri, 28 Nov 2025 03:30:07 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-479052cfd9dsm88329065e9.7.2025.11.28.03.30.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Nov 2025 03:30:06 -0800 (PST) Message-ID: <53eff588-0e5f-4bd6-acff-0f6151b52970@suse.com> Date: Fri, 28 Nov 2025 12:30:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 03/14] x86-64: use BFD_RELOC_64_PLTOFF in favor of custom type From: Jan Beulich To: Binutils References: Content-Language: en-US Cc: "H.J. Lu" Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: X-Spam-Status: No, score=-3018.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org No reason to have a separate type when the generic one has no (other) meaning for this target. --- a/bfd/bfd-in2.h +++ b/bfd/bfd-in2.h @@ -3902,7 +3902,6 @@ enum bfd_reloc_code_real BFD_RELOC_X86_64_GOTPCREL64, BFD_RELOC_X86_64_GOTPC64, BFD_RELOC_X86_64_GOTPLT64, - BFD_RELOC_X86_64_PLTOFF64, BFD_RELOC_X86_64_GOTPC32_TLSDESC, BFD_RELOC_X86_64_TLSDESC_CALL, BFD_RELOC_X86_64_TLSDESC, --- a/bfd/elf64-x86-64.c +++ b/bfd/elf64-x86-64.c @@ -260,7 +260,7 @@ static const struct elf_reloc_map x86_64 { BFD_RELOC_X86_64_GOTPCREL64,R_X86_64_GOTPCREL64, }, { BFD_RELOC_X86_64_GOTPC64, R_X86_64_GOTPC64, }, { BFD_RELOC_X86_64_GOTPLT64, R_X86_64_GOTPLT64, }, - { BFD_RELOC_X86_64_PLTOFF64, R_X86_64_PLTOFF64, }, + { BFD_RELOC_64_PLTOFF, R_X86_64_PLTOFF64, }, { BFD_RELOC_SIZE32, R_X86_64_SIZE32, }, { BFD_RELOC_SIZE64, R_X86_64_SIZE64, }, { BFD_RELOC_X86_64_GOTPC32_TLSDESC, R_X86_64_GOTPC32_TLSDESC, }, --- a/bfd/libbfd.h +++ b/bfd/libbfd.h @@ -1466,7 +1466,6 @@ static const char *const bfd_reloc_code_ "BFD_RELOC_X86_64_GOTPCREL64", "BFD_RELOC_X86_64_GOTPC64", "BFD_RELOC_X86_64_GOTPLT64", - "BFD_RELOC_X86_64_PLTOFF64", "BFD_RELOC_X86_64_GOTPC32_TLSDESC", "BFD_RELOC_X86_64_TLSDESC_CALL", "BFD_RELOC_X86_64_TLSDESC", --- a/bfd/reloc.c +++ b/bfd/reloc.c @@ -2458,8 +2458,6 @@ ENUMX ENUMX BFD_RELOC_X86_64_GOTPLT64 ENUMX - BFD_RELOC_X86_64_PLTOFF64 -ENUMX BFD_RELOC_X86_64_GOTPC32_TLSDESC ENUMX BFD_RELOC_X86_64_TLSDESC_CALL --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -1393,7 +1393,7 @@ gotrel[] = { .bitfield = { .imm32 = 1, .imm64 = 1 } }, false }, #endif { STRING_COMMA_LEN ("PLTOFF"), { _dummy_first_bfd_reloc_code_real, - BFD_RELOC_X86_64_PLTOFF64 }, + BFD_RELOC_64_PLTOFF }, { .bitfield = { .imm64 = 1 } }, true }, { STRING_COMMA_LEN ("PLT"), { BFD_RELOC_386_PLT32, BFD_RELOC_X86_64_PLT32 }, @@ -3963,15 +3963,11 @@ _reloc (unsigned int size, if (size == 8) switch (other) { + case BFD_RELOC_64_PLTOFF: + case BFD_RELOC_X86_64_GOTPLT64: + return other; case BFD_RELOC_X86_64_GOT32: return BFD_RELOC_X86_64_GOT64; - break; - case BFD_RELOC_X86_64_GOTPLT64: - return BFD_RELOC_X86_64_GOTPLT64; - break; - case BFD_RELOC_X86_64_PLTOFF64: - return BFD_RELOC_X86_64_PLTOFF64; - break; case BFD_RELOC_X86_64_GOTPC32: other = BFD_RELOC_X86_64_GOTPC64; break; @@ -18469,7 +18465,7 @@ tc_gen_reloc (asection *section ATTRIBUT case BFD_RELOC_X86_64_GOTPCREL64: case BFD_RELOC_X86_64_GOTPC64: case BFD_RELOC_X86_64_GOTPLT64: - case BFD_RELOC_X86_64_PLTOFF64: + case BFD_RELOC_64_PLTOFF: case BFD_RELOC_X86_64_GOTPC32_TLSDESC: case BFD_RELOC_X86_64_CODE_4_GOTPC32_TLSDESC: case BFD_RELOC_X86_64_CODE_5_GOTPC32_TLSDESC: @@ -18583,7 +18579,7 @@ tc_gen_reloc (asection *section ATTRIBUT case BFD_RELOC_X86_64_GOTPCREL64: case BFD_RELOC_X86_64_GOTPC64: case BFD_RELOC_X86_64_GOTPLT64: - case BFD_RELOC_X86_64_PLTOFF64: + case BFD_RELOC_64_PLTOFF: as_bad_where (fixp->fx_file, fixp->fx_line, _("cannot represent relocation type %s in x32 mode"), bfd_get_reloc_code_name (code));