From patchwork Fri Apr 10 13:32:10 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 132913 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 2641F4BA2E0F for ; Fri, 10 Apr 2026 13:33:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2641F4BA2E0F Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256 header.s=google header.b=TuFw/Wkz X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by sourceware.org (Postfix) with ESMTPS id 87D6C4BA2E32 for ; Fri, 10 Apr 2026 13:32:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 87D6C4BA2E32 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 87D6C4BA2E32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::333 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775827933; cv=none; b=qpP8kaJKmc7B7k6S3AkZm4DeOr4FzeIuWtoTuhpzEC90TxguBfjM3HZSpa5vfXcbRhaefbd7zEGWeKGTDdYxqOYuAX5qZIBdPgnKJrECAURF/ld9PUpDrLVDNqIH2Va1j82WXy8GAK728CNm61X3XDamPuCz792e6GYUXfG62QY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775827933; c=relaxed/simple; bh=8yo2S+JMK1/Fya1g7Tl7+mgB0GKJU8rIctRxK5P+ggY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=upSgga5ulkVHBEbXcECtr8z/jLhzCThDcnjIdrNaJcasIp6ND7I/Dptw49yrA7zimK/1VQ7Z81bG/6+Cbg/furg76t+ueAcAsbTcPwliNcsV98idqRgw3/3ZA6nhIIoKKMvOJhEbHy1CucFt1ThQfD5elADdlMmxifuwmnxVjRo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 87D6C4BA2E32 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-488b00ed86fso22033505e9.3 for ; Fri, 10 Apr 2026 06:32:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1775827932; x=1776432732; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:to:from:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QJHD2hA81fU3WwP3MmK3JeYCh6jGLTVPkdrOAuku6oA=; b=TuFw/WkzBco0/LsMrlV3rx6woWGMqj+Ucj6cCnDPCFiprp8o9tTT48KvfIsyoFwr0t 8sbaqoKd1+CqLeIBQW5N69bvcudbtevF5xONWfo4Fd85W/HCubDRv8yr4XYzNTtaHYDW FKECo8M3yykvlallU2f8IdQNH3LQZYJvwgLzBRN/v3VEHqPVWf3axfD1lqA9HbUWzTX6 CzEFkXvwbhm4ThNhe6EQC+vKXg0WDKhWolQSbrHI0hm21tKeb2R3XJHQwRgqGemmqTY7 R+hJqEPZBKjhqSQhFRn5uxLDwQpcLF+GiQ7Rg8cnNY89pOSFWYIqJcUnr/iC/VM++12A RX0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775827932; x=1776432732; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:to:from:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QJHD2hA81fU3WwP3MmK3JeYCh6jGLTVPkdrOAuku6oA=; b=VcG9eLHv/F7Cz42ifIIVQf4bG5/S7a6vob5IPP6XjIeq1CXQoerLHR+BXIs8OYe2YF YTUWUpQbYzNpGuBX5O1Y76/9dv9JF2cjKGwEZTZnBSf5BIXHN7iD73t7bmmn9+l8aLlF sKNfweUIrPjQ92O6EY+s3gbQhJO+TTCiHdFcOjXgveErj027D5q+4nLl9I0JfBO1rkN1 vLFTOmX73hZdv9MzN4Fsona8ApOQaGPrjwKsPn5G0km0XBD/xZF6baNno46pYhoDN/03 wF29E5cUa5qIx6AXeXL17lncC4XPLSJFspnql80lZ+VV/PyO4ggs5ufGV6NRqjmNhNg3 oUGg== X-Gm-Message-State: AOJu0Ywt9i0jhAp7qYHxmrt8j/LRXXVQDTMqyFAKhBfZa/ArHQ9ORDzz 0ujEq1hm04MVe/c7zlCn2axcEfk4Fe3Bx34F2MbFvWeo2u5Fm+M4GmZpNbMbdTDdeXHLuFIQvL0 pqnKh/Q== X-Gm-Gg: AeBDietUOZcsnoLRdTkR0HVnOgjVphWPIo9AfyordZFNtIW+hGblKiZWGdkqQHA3uUM SRUpRD0EwofBLGgrB2lKU8lb26lCAP5GZ4sVa6LrljrIO8ua/hk9W5ePnC2im4sJOZXd8TKU4OH OI9BC4MUCCELXTlG5sitjnxdS3NR3i9c7H/VQK6xR496Bq0LFKNpvt5IN3LvF8dVs1dyA6Y4+15 BWO0ohKPqCm9QATMSQjK40dcO50ylWufcNyUt0iRno7vuG5AZxr2uRm9zoIpIzjLGAHKsEUnFnA yQ6Pl81wlO/PYv1s6y53pBEUXq5+sEixsgT4oSh5pwl0x4e+msd/R4Kqh47Ak7EN89bQjt3hhOn wieUW9OoxK45qmKSArwDTi7FvqOavWdY1xWsLZV10TlDiYiTU+r9sznUpnSlPg9WI13Xhr32mHh KY23NxRZv6yG1bq3mqWzdop42i3/WWzWXVN3YoererCW/Bg0WZgTFffFtR4BzClJFCKsKEBs7cJ LcyKbDH25t1RUU= X-Received: by 2002:a05:600c:5299:b0:487:1fb4:7e1 with SMTP id 5b1f17b1804b1-488d6875f3emr39502615e9.22.1775827932288; Fri, 10 Apr 2026 06:32:12 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d63deb904sm8270194f8f.9.2026.04.10.06.32.11 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Apr 2026 06:32:12 -0700 (PDT) Message-ID: <40a01241-563a-44ce-aeb9-4ae8fa55c8f3@suse.com> Date: Fri, 10 Apr 2026 15:32:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 3/3] objcopy: zap ELF visibility when localizing symbols From: Jan Beulich To: Binutils References: Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: X-Spam-Status: No, score=-3016.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org The spec explicitly precludes STB_LOCAL together with STV_PROTECTED (and, implicitly, STV_HIDDEN or STV_INTERNAL), so we better wouldn't (entirely silently) write out symbols violating this. --- a/binutils/objcopy.c +++ b/binutils/objcopy.c @@ -1532,6 +1532,15 @@ is_hidden_symbol (asymbol *sym) return false; } +static void +clear_visibility (asymbol *sym) +{ + elf_symbol_type *elf_sym = elf_symbol_from (sym); + + if (elf_sym != NULL) + elf_sym->internal_elf_sym.st_other &= ~ELF_ST_VISIBILITY (~0); +} + /* Empty name is hopefully never a valid symbol name. */ static const char * empty_name = ""; @@ -1765,6 +1774,7 @@ filter_symbols (bfd *abfd, bfd *obfd, as { flags &= ~(BSF_GLOBAL | BSF_WEAK); flags |= BSF_LOCAL; + clear_visibility (sym); } else if (!undefined --- a/binutils/testsuite/binutils-all/localize-hidden-1.d +++ b/binutils/testsuite/binutils-all/localize-hidden-1.d @@ -4,15 +4,15 @@ #name: --localize-hidden test 1 #warning_output: localize-hidden-1.l #... -0+1200 l .*\*ABS\* 0+ \.hidden Lhidden -0+1300 l .*\*ABS\* 0+ \.internal Linternal -0+1400 l .*\*ABS\* 0+ \.protected Lprotected +0+1200 l .*\*ABS\* 0+ (\.hidden )?Lhidden +0+1300 l .*\*ABS\* 0+ (\.internal )?Linternal +0+1400 l .*\*ABS\* 0+ (\.protected )?Lprotected 0+1100 l .*\*ABS\* 0+ Ldefault #... -0+2200 l .*\*ABS\* 0+ \.hidden Ghidden -0+2300 l .*\*ABS\* 0+ \.internal Ginternal -0+3200 l .*\*ABS\* 0+ \.hidden Whidden -0+3300 l .*\*ABS\* 0+ \.internal Winternal +0+2200 l .*\*ABS\* 0+ Ghidden +0+2300 l .*\*ABS\* 0+ Ginternal +0+3200 l .*\*ABS\* 0+ Whidden +0+3300 l .*\*ABS\* 0+ Winternal #... 0+2100 g .*\*ABS\* 0+ Gdefault 0+2400 g .*\*ABS\* 0+ \.protected Gprotected