From patchwork Wed Jul 29 17:44:18 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Georg-Johann Lay X-Patchwork-Id: 140182 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 909E04BB58E4 for ; Wed, 29 Jul 2026 17:45:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 909E04BB58E4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1785347100; bh=lDwIvMs2Hbg91SfJ5XcRin0IHibxArXVFyeoRIgcALM=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=Z8JYY5zDkL0bY0uqTQPaUTuLwXT22dtl0IcKTO4cXr/P/gCJ5qNKaX6Di1COOxzj1 ZdvDXBRYxiOVgCgnTVVoG5UH6smh+YBL0Sr40HcQFuWEn5HJcVgQLiKsj9ViD+cKHX Cn584JTDcZFG0w8PuT365lVWJCXgDhEKv54aZxOk= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mo4-p00-ob.smtp.rzone.de (mo4-p00-ob.smtp.rzone.de [81.169.146.160]) by sourceware.org (Postfix) with ESMTPS id D9EE24BB3BCD for ; Wed, 29 Jul 2026 17:44:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D9EE24BB3BCD ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D9EE24BB3BCD ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1785347066; cv=pass; b=D53xe7DyY3tGVKn5cD7JdZK6eGyV9ZxIfiQriZxnxsFj5prft5t1D4C+y0xJlixwYbZJx4mEhF8ELFh2BURAtEscGZWNqYPYe/QYk1c3pzdEoGVlZAZ91qwHp6CUwNw0gHtv+qw2rTBCbIDNpli/RwL7z/bSp8/5/BSqIULjIfk= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1785347066; c=relaxed/simple; bh=WOXIVGNgBmWz913TLCyCasNe8CdkuMXGWzUlNEPuft4=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version:From: To:Subject; b=sXQKOILbvDbXc4V3h9u2H7rnq0PjgKuJp4htZPOUFKJ0to9Ue6kA9ajkBL2lqDk9U6VSSnXfa+k6JUdNmdOBmUe4jSuFT14WGZh5fJzQ6JJG1FpKSwsG/s0654xRAb3mLsa4cLuQMIYIK5KHu5pqAhZcQXOWksyqzkGZAAdFOhE= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gjlay.de header.i=@gjlay.de header.a=rsa-sha256 header.s=strato-dkim-0002 header.b=h/V2V3Xh; dkim=pass header.d=gjlay.de header.i=@gjlay.de header.a=ed25519-sha256 header.s=strato-dkim-0003 header.b=MsA0Viyd DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D9EE24BB3BCD ARC-Seal: i=1; a=rsa-sha256; t=1785347059; cv=none; d=strato.com; s=strato-dkim-0002; b=OsI/67BW6/9O977JirUnGSMuu4n0SWiW3QZtwIoT4qKZ6ojiLTH8j8IRkAkhohZfXZ Pp0XcP2kRXrpaeHg0FklyST9pnxcyGnSg/XFAwXW6+Q6cCUvUluN2cZWdSDqk1EwICwX i0kugmnZKvtReF1leej+WUnQnOFw1tFiINK+0nByxtNA6hHKKhkhBPszlt3rqbS1pxev UlyiiI3X4gDwsAZEuDibxBJ0QeuYxlHfikNR2yRrFvPdGMLK888nA2CmXOkOrRVRYPjm TbCmwPZA7cg4mcenCApnmHqY1FNabNmMFqLTqnvWUS8TXxuQpjcayREidpnNlz+PMsb0 VJ3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1785347059; s=strato-dkim-0002; d=strato.com; h=Subject:To:From:Date:Message-ID:Cc:Date:From:Subject:Sender; bh=lDwIvMs2Hbg91SfJ5XcRin0IHibxArXVFyeoRIgcALM=; b=MDseug/LoFEKua+/Ab5dIRqVVp6Fa0WkuiYoiaBiS5Fn4h5rBNQKuQQxZseb2CCRmm Syksx6uCNpo8IjnUtoTEI+/aIlH59Ssyg7HOXFZUnsLh6WQwgvdhnMa3cFf8AAo+Zr68 Pt5iGEEL3qnSBgyTNid4MaWkZcVnKokQBCyd9OgpRgemzbQKh5/yI6NLhaTjCUn2gvr1 Kt1o2EItsBsjR36mpk3q/XVLJ9nK+rWk4HL+dRmZRgudZ5qWzPPy8c8zQYP63e3dYyn/ BH3uYPaxF7P29kIWdukrs2nBT9EgG+JWFTGZnXQITnU+qGS74LzNYGVv7SC47iz53fD+ yHjg== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo00 X-RZG-AUTH: ":LXoWVUeid/7A29J/hMvvT3koxZnKXKoq0dKoR0vdoTJLPTbjkmu5qjgJAp0=" Received: from [192.168.2.105] by smtp.strato.de (RZmta 55.5.6 DYNA|AUTH) with ESMTPSA id xed40226THiJqvv (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Wed, 29 Jul 2026 19:44:19 +0200 (CEST) Message-ID: <3f4cafa7-7fe3-4544-ace1-d822003f2e50@gjlay.de> Date: Wed, 29 Jul 2026 19:44:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: binutils@sourceware.org, Denis Chertykov Subject: [patch, pushed] AVR: Fix comment typos in bfd/elf32-avr.c X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Georg-Johann Lay via Binutils From: Georg-Johann Lay Reply-To: Georg-Johann Lay Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org This fixes some typos in comments in bfd/elf32-avr.c. Applied as obvious. Johann --- bfd/ * elf32-avr.c: Fix typos in comments. diff --git a/bfd/elf32-avr.c b/bfd/elf32-avr.c index 07d958ab2e3..0b495bb1bd4 100644 --- a/bfd/elf32-avr.c +++ b/bfd/elf32-avr.c @@ -1744,7 +1744,7 @@ elf32_avr_adjust_diff_reloc_value (bfd *abfd, struct bfd_section *isec, } } - /* For a diff reloc sym1 - sym2 the diff at assembly time (x) is written + /* For a diff reloc sym1 - sym2, the diff at assembly time (x) is written into the object file at the reloc offset. sym2's logical value is symval () + reloc addend. Compute the start and end addresses and check if the shrinked insn falls between sym1 and sym2. */ @@ -2375,15 +2375,15 @@ avr_load_all_property_sections (struct bfd_link_info *link_info) to check if the ret is no longer needed, it is checked that the ret's address is not the target of a branch or jump within the same section, it is checked that there is no skip instruction before the jmp/rjmp and that there - is no local or global label place at the address of the ret. + is no local or global label placed at the address of the ret. We refrain from relaxing within sections ".vectors" and ".jumptables" in order to maintain the position of the instructions. There, however, we substitute jmp/call by a sequence rjmp,nop/rcall,nop - if possible. (In future one could possibly use the space of the nop + if possible. (In the future one could possibly use the space of the nop for the first instruction of the irq service function. - The .jumptables sections is meant to be used for a future tablejump variant + The .jumptables section is meant to be used for a future tablejump variant for the devices with 3-byte program counter where the table itself contains 4-byte jump instructions whose relative offset must not be changed. */ @@ -2410,7 +2410,7 @@ elf32_avr_relax_section (bfd *abfd, asection *sec, /* If 'shrinkable' is FALSE, do not shrink by deleting bytes while relaxing. Such shrinking can cause issues for the sections such - as .vectors and .jumptables. Instead the unused bytes should be + as .vectors and .jumptables. Instead, the unused bytes should be filled with nop instructions. */ bool shrinkable = true; @@ -2541,7 +2541,7 @@ elf32_avr_relax_section (bfd *abfd, asection *sec, if (h->root.type != bfd_link_hash_defined && h->root.type != bfd_link_hash_defweak) /* This appears to be a reference to an undefined - symbol. Just ignore it--it will be caught by the + symbol. Just ignore it -- it will be caught by the regular reloc processing. */ continue; @@ -2600,7 +2600,7 @@ elf32_avr_relax_section (bfd *abfd, asection *sec, /* Here we handle the wrap-around case. E.g. for a 16k device we could use a rjmp to jump from address 0x100 to 0x3d00! In order to make this work properly, we need to fill the - vaiable avr_pc_wrap_around with the appropriate value. + variable avr_pc_wrap_around with the appropriate value. I.e. 0x4000 for a 16k device. */ { /* Shrinking the code size makes the gaps larger in the @@ -3012,7 +3012,7 @@ elf32_avr_relax_section (bfd *abfd, asection *sec, true)) goto error_return; - /* That will change things, so, we should relax + /* That will change things, so we should relax again. Note that this is not required, and it may be slow. */ *again = true; @@ -3050,7 +3050,7 @@ elf32_avr_relax_section (bfd *abfd, asection *sec, /* Look for alignment directives that have had enough bytes deleted before them, such that the directive - can be moved backwards and still maintain the + can be moved backwards and still maintains the required alignment. */ record = &relax_info->records.items [i]; bytes_to_align @@ -3268,7 +3268,7 @@ avr_add_stub (const char *stub_name, } /* We assume that there is already space allocated for the stub section - contents and that before building the stubs the section size is + contents, and that before building the stubs the section size is initialized to 0. We assume that within the stub hash table entry, the absolute position of the jmp target has been written in the target_value field. We write here the offset of the generated jmp insn