From patchwork Wed Jul 31 11:54:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 94859 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6D3E6385828B for ; Wed, 31 Jul 2024 11:55:30 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by sourceware.org (Postfix) with ESMTPS id B15343858C56 for ; Wed, 31 Jul 2024 11:54:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B15343858C56 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B15343858C56 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::535 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1722426894; cv=none; b=epKuNZn3+XIahyo6lwgqRd1fd3wTKHiIFoG3/uQ69u8WaNMGgoF+uQ3ozHQtD7n+7x4YQQYYw43DMP0HlswJoTHq8R8XZuF8/pelwdWjPCH7Wt1AI3w5EEC5xoGjzsCY3AmaCpm2MCHEOWuSmGAxWPONsCjLYbdByJdP70n1rpk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1722426894; c=relaxed/simple; bh=vQmph/mqTNOyo/hmn7l/XfrNKCURiEBRgHOdr5yfrCY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=itE28kwCu2o9Cw7CjVK3mwp+L6paBZ6/3FWu1pIUNlN4E9bwX5VkjNY8W9CcMG783P9Du4kgK23ExZn1ZSN/5Od40FOYNPaqac5FHJgMUfXm7yWbNLpde6AUiQfc7wKbd6vzUDfT3Qc0HaambIWbLQ/pX7c8kpltn6vGh1z4ZC4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-5b01af9b0c9so4631829a12.3 for ; Wed, 31 Jul 2024 04:54:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1722426891; x=1723031691; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:to:from:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=iDCYT2BQXFFcBg2S30XdDBdcUI5E/vavMTGK9Y9FFdI=; b=CTjscHU7QVO9NXukFEWnngBjThE0wf3Y7g9TPoMTuCycqHSpFgRzedMIBGPWXLuL07 nviTlPZA64qbTULGx9Jp+NYdFGiDryLtYDTluiMbz0KA3gzJk/c4Q5GZ7usYH8/CWhuh Smde/DXTIPzWDnV+fZE4f6cJxz2K+Xc666+CbN6Nlornwhtgp1+WZOfaO9TFhUCcnVxn /6Vbm0UVvNwzNQPxf4AcoGanGsaS84NldaYocunI90kOyZ84vX5X35WZkXnyHn6RNx3H yvBzgK4ktKvUhN42OuTna3IoqPQGGnAFYPrOTmfO/iqgJuWgaUkpQcaI5bYUQmt7ak7N zBvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722426891; x=1723031691; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iDCYT2BQXFFcBg2S30XdDBdcUI5E/vavMTGK9Y9FFdI=; b=hK3mZ+Ugrv5JHDyAU0GuxTVhtx88Sw40MCTdgdkgEPnn3fTP4VdwQGxtvQxr4YHf+h qOjsHukjTfSiAsZ3doqUsEEctgLKdBbeJ7EYpTqSaFvXP81av4q9K+AgRVIj3FcedXA8 BZh2yKkzlHS/wFV+HfFjolGV3IHLkdLh68zDODFmRzkCTpzt1ZoV87pOqfbFDU9R2TEw hVnWdg8bOaEX8WERcDV2PrFlzmlrndxRjCb0T5fvYV6KSFNdUsudrgOsrRWNGD6Hz1Rk e4tySjuX1LXxehLHa5ZFatr99hLHD1sINYGPLKfIFr3a5jMOH4XPIxXie+9o3Duu0f6Y 3KNg== X-Gm-Message-State: AOJu0YxaxuwcDllkxlsq2z3UTzoP2cUg8JS1vpuM5JGASeNiGWRNQ0OX sHBwfvUfje9WSXZz+3lOmiSrCxwD6bveRMMYp8tKKYrQyJ9k7ELtHxg631No/RFwfvraQEzObzw = X-Google-Smtp-Source: AGHT+IE4+66HTQHp37Om815MYowWcrVTOsOpliKGMIviV2Az3R0cic2Z2m3NvuDQi3vkl0UBFwtHng== X-Received: by 2002:a50:998d:0:b0:5a3:f5c6:7cd9 with SMTP id 4fb4d7f45d1cf-5b021d22068mr9752429a12.26.1722426891157; Wed, 31 Jul 2024 04:54:51 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5ac6578344fsm8605309a12.91.2024.07.31.04.54.50 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Jul 2024 04:54:50 -0700 (PDT) Message-ID: <3bfd6cff-3477-4ac2-a945-f24098c4a414@suse.com> Date: Wed, 31 Jul 2024 13:54:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v3 1/9] gas: have scrubber also respect quoted labels From: Jan Beulich To: Binutils References: <7e951d11-cccf-4851-84a6-3a85cda8254a@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <7e951d11-cccf-4851-84a6-3a85cda8254a@suse.com> X-Spam-Status: No, score=-3023.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_FILL_THIS_FORM_SHORT autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org For the handling of ':' elsewhere in the scrubber to be correct with regard to labels, the state after parsing a string found at the start of a line must match that after finding a symbol character at the start of a line. (Things are largely okay when there's whitespace ahead of the label: Whitespace after the colon then is retained rather than dropped for typical targets like x86, but read.c will know to deal with that.) --- v3: New. --- a/gas/app.c +++ b/gas/app.c @@ -1113,6 +1113,8 @@ do_scrub_chars (size_t (*get) (char *, s } else if (state == 3) old_state = 9; + else if (state == 0) + old_state = 11; /* Now seeing label definition. */ else old_state = state; state = 5; --- a/gas/testsuite/gas/all/gas.exp +++ b/gas/testsuite/gas/all/gas.exp @@ -477,6 +477,7 @@ if [is_elf_format] { } run_dump_test quoted-sym-names +run_dump_test quoted-label-blank # Targets where # is not a line comment character don't transform # "# " into .linefile (PR gas/29120). --- /dev/null +++ b/gas/testsuite/gas/all/quoted-label-blank.d @@ -0,0 +1,9 @@ +#nm: --extern-only --numeric-sort +#name: quoted label name followed by whitespace +# No quoted strings handling (TC_STRING_ESCAPES set to 0): +#notarget: powerpc*-*-aix* powerpc*-*-beos* powerpc-*-macos* rs6000-*-* +# Certain LABELS_WITHOUT_COLONS targets: +#notarget: mmix-*-* tic54*-*-* z80-*-* + +#... +0+00 D blank-after --- /dev/null +++ b/gas/testsuite/gas/all/quoted-label-blank.s @@ -0,0 +1,4 @@ + .data + .globl "blank-after" +"blank-after" : + .byte 0