Message ID | 2d41b76b-0e40-4266-9d02-55cd02203566@suse.com |
---|---|
State | New |
Headers |
Return-Path: <binutils-bounces~patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DF5FA3857C63 for <patchwork@sourceware.org>; Mon, 27 Jan 2025 17:06:40 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by sourceware.org (Postfix) with ESMTPS id 64C8C3857C5F for <binutils@sourceware.org>; Mon, 27 Jan 2025 16:31:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 64C8C3857C5F Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 64C8C3857C5F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::62f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737995466; cv=none; b=dNUjoZWyZxJhBOstV8+NJERAfir3+XtOopk6yesHEoGFoIwOhtNu0MqaHh7waK22hzwvoFkGBHFYMJh2Ov4/EP0HysEfFvOAcXnlg9Qox4UJrOEa3EolKNY1f064cLMgM4FjKLXgA2sN1jDqA1Yq3v4Qq0g7SnLT6VrLfGoqHeE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737995466; c=relaxed/simple; bh=9TsOSy4nTmSaj06XpaPlOiVeIMJ0LKJK+RiWggL/3Bs=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=hR1hUCJz8u7XNktoj1yq7Z8U9tRzz3ooIKvg7Q39derOFFUIOYm3ZIZE4JemlBfW5V4VqY8FfgAYmLdR4/FqzXEMCXjSv6IH5lh+I3u4mpYJ9HuNZ2B9rRW9TVivYkAb4ZQnuJqPPUIevv9inaZOMhVROUrLg0TWJkwD53v0MGc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 64C8C3857C5F Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256 header.s=google header.b=KlCmjfpu Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-aa679ad4265so1129108466b.0 for <binutils@sourceware.org>; Mon, 27 Jan 2025 08:31:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1737995465; x=1738600265; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:to:from:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QVyRJf0D0HG2m5iGfqu4ddMKjIw0aW3BxS0gn6lwcxc=; b=KlCmjfpuGp5/ZHM4MlVP6Rzpq1ax+XxtbbvoWsy3s3dpJ1br7ymf47+IqpujQMLx7E 6yKNOSRYp0nCpfmllMNzxPa0o+hO9uqaM93ZXUH9jEHKfa/jguivdfhCv35e6KbjhNRr mz0MGbVWv/WmZ7f2GCygp22mLE0+wq431VcSoTwT2fiojjUuEX2asGcm1TPzWaZt8nen 9utCLvj+cqI1QzntyXLkTs0x7/blkEeamkO4j4vZuSQioGoW10NXnxXjQXAdLpIUoCxA clK3mnM0+DNjKylfyum2gz5+Rf5P6EQXnM+fI22Odqszc3VC4vh3JuHWvggtLnSqRST4 gPXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737995465; x=1738600265; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QVyRJf0D0HG2m5iGfqu4ddMKjIw0aW3BxS0gn6lwcxc=; b=BzeCjoWW2qg0Zyikxg7p42RWGIdUBZpF7IC9OtX1u/0wSh/Ay/1hWB2pmLv04JtyYf szsoOPXtJaqj0xff+NUuLh4d34lTbh3s0Ju7hthz90NupG46u685xPThUo+alFJsowxg HRk+EFQUNedCFKcZrMhl/z5m2nDabKLYUheB5Vjj2y+ybPtA6KZTK1fbmmwghV7PLQEJ LskzvxNgKv56cQQ2wKqz4zk/wQvnitEj2I1MPmPiJMhujMNZVvi6XDRmjJpmaCODOdRV LZ8ObpV63jCAFSCHjXLS2JUiwDdqSyRTJzb9iFGCPcMeuOGiw+HV+f3XveKMXt9d2XiZ Pb7g== X-Gm-Message-State: AOJu0YwFqyR2ZhxbMHTh4P7AB24Qw4mBofgfjOREEjH6ovmqcK6JVANy 2L2DK8yoQn02EBVWx1nFI93K7i+rdSYpUtuARsduw0k9xgEoeHsr3ovsoKE0bcUlCt3VQpyE20A = X-Gm-Gg: ASbGnctLlNJPIR4s61k+S67Yfrr57QjacY2oW05bZHiQIlb6mlMpMhbaWfe/+0hgqUE ynlHcNonHt0PFXYdPewXeEOUh6mV2wGvw51EiZdOxf2n5qmmPIY9FxgPWG+3frsBwgSVl+Rhr4+ g3ZvYQ6jCwiqy5yRmALe1yiVbHs4CiY3QEffm675RZWR6SWsrPgcZ/c6o9M5eRbYBIhYrC+NekM wT4LjNDpCOlGfBwBmATU7+ZXoumWBGrHB/WTNq7gTy6Rjz97IpT73Jgvd6Be6LGikBJe55J85B/ ys11TwZteh2jKWY2PjuiNJGIzHJHxOiIn0kVyJc40STxCrvmDAiNv+AdsewBSi0y7Q== X-Google-Smtp-Source: AGHT+IG01XtegRuE16W+2Rjt4vvVEAJNR6rK6jM3qk6pFONoQqsXko6Bd99MD233teAwJ+IdFOlxUQ== X-Received: by 2002:a17:907:94d5:b0:ab2:f255:59f5 with SMTP id a640c23a62f3a-ab6629d01c4mr1587203266b.16.1737995465057; Mon, 27 Jan 2025 08:31:05 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab676117b02sm609980366b.173.2025.01.27.08.31.04 for <binutils@sourceware.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Jan 2025 08:31:04 -0800 (PST) Message-ID: <2d41b76b-0e40-4266-9d02-55cd02203566@suse.com> Date: Mon, 27 Jan 2025 17:31:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v2 36/65] msp430: use is_whitespace() From: Jan Beulich <jbeulich@suse.com> To: Binutils <binutils@sourceware.org> References: <2316ac5c-7870-4b46-9c80-eaecaef93a31@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <2316ac5c-7870-4b46-9c80-eaecaef93a31@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3022.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list <binutils.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/binutils>, <mailto:binutils-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/binutils/> List-Post: <mailto:binutils@sourceware.org> List-Help: <mailto:binutils-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/binutils>, <mailto:binutils-request@sourceware.org?subject=subscribe> Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org |
Series |
gas: whitespace handling
|
|
Checks
Context | Check | Description |
---|---|---|
linaro-tcwg-bot/tcwg_binutils_build--master-arm | fail | Patch failed to apply |
linaro-tcwg-bot/tcwg_binutils_build--master-aarch64 | fail | Patch failed to apply |
Commit Message
Jan Beulich
Jan. 27, 2025, 4:31 p.m. UTC
Wherever blanks are permissible in input, tabs ought to be permissible, too. This is particularly relevant when -f is passed to gas (alongside appropriate input). Also convert ISSPACE() uses. At the same time use is_end_of_stmt() instead of open-coded checking in code needing touching anyway. --- v2: New.
--- a/gas/config/tc-msp430.c +++ b/gas/config/tc-msp430.c @@ -436,11 +436,11 @@ del_spaces (char * s) { while (*s) { - if (ISSPACE (*s)) + if (is_whitespace (*s)) { char *m = s + 1; - while (ISSPACE (*m) && *m) + while (is_whitespace (*m) && *m) m++; memmove (s, m, strlen (m) + 1); } @@ -452,7 +452,7 @@ del_spaces (char * s) static inline char * skip_space (char * s) { - while (ISSPACE (*s)) + while (is_whitespace (*s)) ++s; return s; } @@ -1813,7 +1813,7 @@ extract_cmd (char * from, char * to, int { int size = 0; - while (*from && ! ISSPACE (*from) && *from != '.' && limit > size) + while (*from && ! is_whitespace (*from) && *from != '.' && limit > size) { *(to + size) = *from; from++; @@ -2833,14 +2833,12 @@ msp430_operands (struct msp430_opcode_s check = true; break; - case 0: - case ' ': - case '\n': - case '\r': - as_warn (_("no size modifier after period, .w assumed")); - break; - default: + if (is_whitespace (*line) || is_end_of_stmt(*line)) + { + as_warn (_("no size modifier after period, .w assumed")); + break; + } as_bad (_("unrecognised instruction size modifier .%c"), * line); return 0; @@ -2853,7 +2851,7 @@ msp430_operands (struct msp430_opcode_s } } - if (*line && ! ISSPACE (*line)) + if (*line && ! is_whitespace (*line)) { as_bad (_("junk found after instruction: %s.%s"), opcode->name, line);