From patchwork Fri Sep 22 07:52:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 76566 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 600B03861874 for ; Fri, 22 Sep 2023 07:53:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 600B03861874 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1695369182; bh=SkPL6+dn9RF8/w9ZtSLjzj3VQwPWbdNk5o9FxZbawhs=; h=Date:Subject:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=bS1VIkeYjtsvqTqFbUFtE8EQWjXsMahDV8yZCD6jmAW1Elxr6fYCyxctuPmkblZCR YdCy/jJq2wXVZsBKiLUM4BzuFHIVrswegZZkYJ5i5kqaYgC2GN4d2QpJJcTODLAtvY ykVcRCm1OFVGGrQH/O8V9eK3QkVMR7/r+XeXRj2g= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2053.outbound.protection.outlook.com [40.107.21.53]) by sourceware.org (Postfix) with ESMTPS id 68CCB3857359 for ; Fri, 22 Sep 2023 07:52:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 68CCB3857359 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HmCnLlm0frnpdEuxYZRriA1gou5MYpqAroG4QeQAHbE/J5/HaV/K5q49wzZKhI51J0sHwWzFb9gK95a70Q3BxJUJ2L8sZ9W+r+1N04iOa/x1QyXIDD/NHpg73+EjgER9W9UAbyPnfy+FGBAWrmZyyE4yPFlvUL/L7KHup6d9+ExWKbTyTIR9gemd7paxvB7Ap/YGU9t3lMEtHgb0LfieqvFVP/y3TX42KDsO2lAp9B5UBkIwkDMrH1CbYmDJqnqG+SvxZ/mWypZHRedNRhw+bYc9+IFbIzJTJbU5i7clQsmkGq7gPLznmT35gdaC+GvU7v/yTVRmtzFqpgPQ2S1z1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SkPL6+dn9RF8/w9ZtSLjzj3VQwPWbdNk5o9FxZbawhs=; b=AzE6zyn0FZg0g0cigSPr7Eu3O3cv43r1b4PX0LMP3V3utrvX5YAtR2kPwn02nuWpx7DZJn7hdQjBQzWt7G5jeZAZazzVB9oUyJaWF4Ms0JuYEE/m8SiFtSZob4YJ0JyjfNHBlWkZlsMybWcPMjJnol57uLQ6nVn1i4JZoDJUNa2Hege83eZ7hX8H5nebsO7QaGYyY20YNWlr1JNSVNvdQn1hq7zMUW0NxBR6nwdwueeObKaBObAr7ENPsrLtvltD6fiVhjbCjMKpTFF/YrBHu4pTDU6U76zmCPi+x2d8BFvG8tNih6joMn38+9XdepkD8w1zp2qjTS+fqOjFh/PKyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DU2PR04MB8919.eurprd04.prod.outlook.com (2603:10a6:10:2e2::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.20; Fri, 22 Sep 2023 07:52:31 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::f749:b27f:2187:6654]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::f749:b27f:2187:6654%6]) with mapi id 15.20.6813.017; Fri, 22 Sep 2023 07:52:31 +0000 Message-ID: <25b9c9f6-8762-5cff-39fa-8153a4d9c754@suse.com> Date: Fri, 22 Sep 2023 09:52:28 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: [PATCH 2/2] x86-64: REX.W overrides DATA_PREFIX Content-Language: en-US To: Binutils Cc: "H.J. Lu" References: In-Reply-To: X-ClientProxiedBy: FR2P281CA0057.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:93::17) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DU2PR04MB8919:EE_ X-MS-Office365-Filtering-Correlation-Id: 4b8f7430-9df2-48c6-befc-08dbbb40dfbd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LPrKoitDZK7slwDJwdkMmwKiH00/VYvKz/Tv1Uqn+7Ta2BDzwjAMt5ZhNkv+KcWzcNyzvOapqH8XFvaSDI1Dp05mge8C8Xubft6VXaXWhu37G8XvL4nWZXxRc0+JEXIUxw91DKzlw/MWsNQO7IJf8CnLY6uis8v/pKXR+cP6aAEa3H64x9tHZcboNv32+BCTuRpzoQNNRuFCmUBJQFgufGLpz1ebBa0624+yvE+EODlQ9Y/fH5MQZCO5iYTQwc+GQzXSGHPIQMIQop1eiiWtfs1a+NFREfu+FJbRh6l3qeboCo5Niq7m92Dc3Ty5MZZ0/98ZHpTpvNz9ZYBuDgy6d9ZooBzPxHrSt6Bg03fao95aQrkE0y5tns46+rxiEmKXzlhC7xQJShCorR4oWgUlJ5qJCPbmWXB2J0vAglBR7exeGDhAx1oFvR972jwaSZCIILSm+aoG9kaarH4fkp5zQ0oM/nF0IMHB0FSSuIDbBk5biWj9+sah9WBlvYeDN1fFZoGPaQaAtOv+RZkhL+D2LFuM1cTBxzeqqV9F2f1OKxwPwIA00/uQkwTeyXPuG0mesM8rlH/LFG+6d7tGlQ1uCGcGS4g8r7iYFQQAMBDUcOipIbv4NydQLkMlxRTGqufkGbePQjmpP80QHP/UCMHXvA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR04MB8790.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(346002)(366004)(136003)(396003)(376002)(451199024)(1800799009)(186009)(38100700002)(6666004)(478600001)(8676002)(41300700001)(4326008)(8936002)(5660300002)(6916009)(66899024)(66476007)(316002)(66946007)(66556008)(26005)(31686004)(2906002)(2616005)(86362001)(31696002)(83380400001)(36756003)(6506007)(6486002)(6512007)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?0M00C/DA4PghNdDzxKCQDLrUYAjA?= =?utf-8?q?w5uNX8Ka8ncTBH1ol5yVcZeVArcAXgUkO1F7yHcYsqo8mBqJbY5eiLH5GZT7wICsR?= =?utf-8?q?P7Qog94bWJ3AszFOrocueBhtrDeMC/KyaO1CBVzVSKIq0DAV5J1D50QDOO9h6KoX2?= =?utf-8?q?Y7XbREk38nTD2Rp65dWapCE1CviuNMjak40uwcb4QtFcL54jG+wNb2QGsFJThnnlO?= =?utf-8?q?4lU2WRxbwIJxwx7d2CyB9KJI45vaxFxc4HZgN20Jtd6Y+L0nEYK8H8y6pFsJ1NJo6?= =?utf-8?q?uZgf/BxIFScVBkGwsiEqn5v/vBOOiXnUmGL7d+bOuFZDRXzSSfYh+zCdYYo6hNiU7?= =?utf-8?q?Lsz4FE7JR1R1KDbFINqmaU7wFZ/qyqy8CkQSsipLERsTLTKP45AxLkCv2qRjEQnNu?= =?utf-8?q?qchbjuzLhpUmGuIhbgwu23awuG497buJcgFGfuRrhDdlGQk5gDiN3JhZdzqJucXZX?= =?utf-8?q?k8pqLCbm0Sl90+JuW+WMyqhoZVy8y46yLhB+mpUKPojieXkD9Dcxr7hvTA4Oi322d?= =?utf-8?q?Pjy48RHtKMiaS5cBXQGSKgD/Jj3UY8snuoBhJiLonWkleu0lZh5age3hNriSCN1kC?= =?utf-8?q?GbmoVrcw4B9b41ZHz+Rdb7cnVKzyXM7aKbfm8SZlO2l5LhN/XwFR2Ew+isMfgO0G4?= =?utf-8?q?aV4GyhuR67USHev5cmUzaihaIlJVKPOCwvV5NlE/O5WDCOVDKT+8eGoVRA4zVOWy3?= =?utf-8?q?7OmijN6+IHearMIIzNPHXvB8VFlsZzuqFqs4ekuS5mp29orU188vfaFjL1j7gHmtF?= =?utf-8?q?osl1JMd6C56//SeF0T6GATERh3hmr7Ju/e7tESQPXJsbC5TIflmxMLVzyYLE+U5kG?= =?utf-8?q?r+woMgTGiqrcOPKLekpLKoj4rKyJRbL1DVzbmL9C/ptt0bx/NsHVaZ5PgQ504M2yS?= =?utf-8?q?S/6CToE7eS+osReK6HCvHMaduBdo6cc3ZqSkzL5+Iui12hi+d5jn7StKBG8onKfWc?= =?utf-8?q?dfTa4yJb5U55EDbO+r0NFra+alJk6dhhECkCxPYv1o6hTJ6E5QLJR7b6mLjBTHH6z?= =?utf-8?q?OdQJPzYqdtvD8oiorF9usyKBCX3uDffpRMqNawyxovBkQ7Kznv/ghg31qSX0yrQ6W?= =?utf-8?q?clcBHc5JbPJOioP+/syIzCuZgxUahcrtNqvKB2yYoCRH1tyAOpFpiIhXLxPYubhEY?= =?utf-8?q?n2iL0t98wP7R2x8QzCHouLtV+NfAF4HZ/joTPCNCq/gKgHnvdzfYnC+M2OpKkIyIW?= =?utf-8?q?t1pzK6dYLp2ahQAg0ZTbk3i5UkF13RJzNcAguSo5RNK9/ed1BhLYcD8uhgVj8VNsR?= =?utf-8?q?9Aptfz5RYhEJIgd6+Hy0zThVkVwxwoG0L4mRWKgZxfcNsZISnlUYZ11XPwl/VCLQZ?= =?utf-8?q?ZH6M8hmt3H/EUsEoBkPLx50W81mBwft+mWi9szGFgM/e3wZOzdF2lAyEJBWUBSALP?= =?utf-8?q?eXChcB8DDqwJl7vdiY3qbQL0OiRESi80C/vsIlr+4e286d3L9ZcBeVNdRDuUEYgVR?= =?utf-8?q?Fbr949K2VUz+ZbYhDdAT0UjUuTIpNOET35ecQIBOHiru9dHeIfL8IAMpdtt8JAPPv?= =?utf-8?q?5qiDVgr45GuK?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4b8f7430-9df2-48c6-befc-08dbbb40dfbd X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2023 07:52:31.0010 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YFp5fdxLEukbtx/VtHoLHcY+syv+CHzcpbBb19c23HThFPyJBnBJhgz9LZBlkP1sHtGXKToUxvrDSOe6IVKimA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8919 X-Spam-Status: No, score=-3026.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jan Beulich via Binutils From: Jan Beulich Reply-To: Jan Beulich Errors-To: binutils-bounces+patchwork=sourceware.org@sourceware.org Sender: "Binutils" REX.W needs to be respected when immediate size and relocation type are determined. --- Looks like similar issues exist in displacement processing, but that'll want to be dealt with separately. --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -6212,7 +6212,8 @@ optimize_imm (void) break; } } - else if ((flag_code == CODE_16BIT) ^ (i.prefix[DATA_PREFIX] != 0)) + else if ((flag_code == CODE_16BIT) + ^ (i.prefix[DATA_PREFIX] != 0 && !(i.prefix[REX_PREFIX] & REX_W))) guess_suffix = WORD_MNEM_SUFFIX; else if (flag_code != CODE_64BIT || (!(i.prefix[REX_PREFIX] & REX_W) @@ -8186,7 +8187,8 @@ update_imm (unsigned int j) || operand_type_equal (&overlap, &imm16_32) || operand_type_equal (&overlap, &imm16_32s)) { - if ((flag_code == CODE_16BIT) ^ (i.prefix[DATA_PREFIX] != 0)) + if ((flag_code == CODE_16BIT) + ^ (i.prefix[DATA_PREFIX] != 0 && !(i.prefix[REX_PREFIX] & REX_W))) overlap = imm16; else overlap = imm32s; @@ -10426,6 +10428,7 @@ output_imm (fragS *insn_start_frag, offs if (i.types[n].bitfield.imm32s && (i.suffix == QWORD_MNEM_SUFFIX || (!i.suffix && i.tm.opcode_modifier.no_lsuf) + || (i.prefix[REX_PREFIX] & REX_W) || dot_insn ())) sign = 1; else