Message ID | 22965bdb-fe8c-4793-9809-6729acf8c44e@suse.com |
---|---|
State | New |
Headers |
Return-Path: <binutils-bounces~patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4FF993858282 for <patchwork@sourceware.org>; Mon, 27 Jan 2025 16:54:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4FF993858282 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256 header.s=google header.b=O46Jf6Lh X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by sourceware.org (Postfix) with ESMTPS id 90FA53857C63 for <binutils@sourceware.org>; Mon, 27 Jan 2025 16:29:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 90FA53857C63 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 90FA53857C63 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::536 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737995363; cv=none; b=nvuhzAbFoza+2OzzOLGyOn0oQd4ba8DfHUz0A0UB4kkyy84n+a2v6B3NTDDZ5p/SS5aUmTxlzUqKoK6BkWieDWgflabWlT6MjDuemLVQ0yqyGF12QlzQBNhKkLnhtbc+H00mcko/npIfoPkTEi0IkVaktABneAcacJuomAm8gJ4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737995363; c=relaxed/simple; bh=aKfqbWO2Me4vh8Z7Fq2N8LzdUk4LVECfg8UI1ffS8Hc=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=iMSCfwFVvV++cnAumGVmOaYiNyqZpJQy39Cr4j4MNpjznAhHVNeVf7ThHoudKIEDWsVxEW2e24eQyrrxwAZPJRg/jO7vt8mJaTjJe0Uya9E8zBwXaMCVQ8RCFUXZMuO23HYZB2r9ERC+nsjKQhG/hTafFRNOjyL23Z3zb7eGfgA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 90FA53857C63 Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-5dc10fe4e62so8633734a12.1 for <binutils@sourceware.org>; Mon, 27 Jan 2025 08:29:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1737995362; x=1738600162; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:to:from:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HIcOyI9PDNDi/IxStZa9A+TwjcfgXmJev+S0SOW2lqE=; b=O46Jf6Lhf+O6QQIK6pYI6HSY8IxEvj0aNMMhTOxFfjL/pa57gj+7mH+H9wG+sCxHHV ooArItoIkae1CBcAC8D7UkMRWKW2izZ7XhG3QpNRRaas9VhBTOyD2QBXGPdUak4+IUdY C9HecCz/j46UBX55Bp4AR4C6okEtquxDY4EI94nvqf5OqvQrv7WpU39LxLtYu+vArzhj 4ek8euf+zmCRMTGUd47qk/0tgUKsfgO4BsNlvb5TwXko3+B7ugWMJPOU2LDzs7vZ7R7V a6Xd/v86cU+4smxQCW7suZhTQbT1VzdJK8FbuXtskJ3VTRhndwYhrNBoSxRgqbUtOfd6 p96w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737995362; x=1738600162; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HIcOyI9PDNDi/IxStZa9A+TwjcfgXmJev+S0SOW2lqE=; b=rasoVev4rXobenCmWDpQcQ+4qO/NnQwlV/PBJ3dn3rmRYiu4xPXoTAn1Qzv++Gfm4e mnLLGct4/QGRrGHfmoTtlpDVLmxedf1h1g+nheMlJPoNjbjvcA9Kx6fQ7+QB1gZ9mFHp 5vHd+jGnI3cwgxS2qMGTEHoFlXb8T7v6vfDEQAMwRaFezXDwSglbxMMMI32x3zQw9UIJ Y3hqpqoGb/n89LAhnMEX9Lan0RsJEg+PhMznHnfnmJenMFr1k8Dp8aqYZevajz5vq2Q4 kZOFBFvWwfyLmTgiVKUWtzLxYOSfvi4KZoaGYjj7h5QIBX+p6Wx0nk73xxfJkUd4ySTt /3PA== X-Gm-Message-State: AOJu0YyBQDuWGt4hKI+SAJz4NbSPGFb3EghqXfYGKSrcFpF9cXTk0kGp s5ibV4iZAF/KyV9N1GjYm/lbVvG2HsRkweJUp3tSbKnKZLiA7b1KcyNPjEGxjaMrdk0EjeBYhSI = X-Gm-Gg: ASbGncsM85gjzOH5cm7Q1W+YcTW5XuT4bf+V0Co63XLsEvkiGAgEb0OyC4CYTP+nuqb 3kU36lfOgB6Ysslsbuk51+9KDW50IjSi5OOB7kih2Sx9JBGlRlBrMS4FYR8zB2+OtzEHjyPkUFR Y2ziNnUaT9AdcHT+Ta3oVy0sQFQBfX701HRvVL7e5TPiVyc22URWXYzuujDt9lXlTRRfhoNTWUH mxL2XsgV2EXwQP3Ox/lgO0n2ZKM2btJOokMC/ku3uDlQkU4B960zA2cIOEBllVBe4X9GXtcTwep 4RGoXyyaGRBajTevyIiZ+oqsK2ehDlcg9P202aAG3teKEM52N12tGPEAcIHm579FhQ== X-Google-Smtp-Source: AGHT+IETnDvZaXyJvo8vCuNMcLcWWTMYgeESXGmCCByCHldouC8cP8BYpeBoQyzHaR7B2YqanmaRKQ== X-Received: by 2002:a17:906:c001:b0:ab3:9923:ef46 with SMTP id a640c23a62f3a-ab39923f699mr3446352666b.11.1737995362205; Mon, 27 Jan 2025 08:29:22 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab675e11a1esm609701566b.33.2025.01.27.08.29.21 for <binutils@sourceware.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Jan 2025 08:29:22 -0800 (PST) Message-ID: <22965bdb-fe8c-4793-9809-6729acf8c44e@suse.com> Date: Mon, 27 Jan 2025 17:29:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v2 33/65] mn10200: use is_whitespace() From: Jan Beulich <jbeulich@suse.com> To: Binutils <binutils@sourceware.org> References: <2316ac5c-7870-4b46-9c80-eaecaef93a31@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <2316ac5c-7870-4b46-9c80-eaecaef93a31@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3022.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list <binutils.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/binutils>, <mailto:binutils-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/binutils/> List-Post: <mailto:binutils@sourceware.org> List-Help: <mailto:binutils-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/binutils>, <mailto:binutils-request@sourceware.org?subject=subscribe> Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org |
Series |
gas: whitespace handling
|
|
Checks
Context | Check | Description |
---|---|---|
linaro-tcwg-bot/tcwg_binutils_build--master-arm | fail | Patch failed to apply |
linaro-tcwg-bot/tcwg_binutils_build--master-aarch64 | fail | Patch failed to apply |
Commit Message
Jan Beulich
Jan. 27, 2025, 4:29 p.m. UTC
Wherever blanks are permissible in input, tabs ought to be permissible, too. This is particularly relevant when -f is passed to gas (alongside appropriate input). Also convert open-coded checks as well as ISSPACE() uses. At the same time use is_end_of_stmt() instead of kind-of-open- coded checks in adjacent code. --- v2: New.
--- a/gas/config/tc-mn10200.c +++ b/gas/config/tc-mn10200.c @@ -878,7 +878,7 @@ md_assemble (char *str) int match; /* Get the opcode. */ - for (s = str; *s != '\0' && !ISSPACE (*s); s++) + for (s = str; !is_end_of_stmt (*s) && !is_whitespace (*s); s++) ; if (*s != '\0') *s++ = '\0'; @@ -892,7 +892,7 @@ md_assemble (char *str) } str = s; - while (ISSPACE (*str)) + while (is_whitespace (*str)) ++str; input_line_pointer = str; @@ -929,7 +929,7 @@ md_assemble (char *str) errmsg = NULL; - while (*str == ' ' || *str == ',') + while (is_whitespace (*str) || *str == ',') ++str; if (operand->flags & MN10200_OPERAND_RELAX) @@ -1102,7 +1102,7 @@ md_assemble (char *str) str = input_line_pointer; input_line_pointer = hold; - while (*str == ' ' || *str == ',') + while (is_whitespace (*str) || *str == ',') ++str; } @@ -1127,10 +1127,10 @@ md_assemble (char *str) break; } - while (ISSPACE (*str)) + while (is_whitespace (*str)) ++str; - if (*str != '\0') + if (!is_end_of_stmt (*str)) as_bad (_("junk at end of line: `%s'"), str); input_line_pointer = str;