From patchwork Thu Oct 1 15:28:56 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jens Remus X-Patchwork-Id: 145111 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 34A2C4BB58A3 for ; Thu, 1 Oct 2026 15:29:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 34A2C4BB58A3 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=gHe7V//f X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 751464BAE7E9 for ; Thu, 1 Oct 2026 15:29:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 751464BAE7E9 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 751464BAE7E9 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790868551; cv=none; b=WVPS62gFYtEaUQgjKq8i2on5IRSpiPA8x94b11V6/WWo30KOgIQa3me8neXZ4clruEO0EjwaKlAFjc6U9cWIfUU1ulizpupISbFlREhOopWfz8QVIed5+MMQ+dbWedAUNtPgGeZ0sZt0WphomvoXQk3KmEoKDNivK+L4BaGwTnI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790868551; c=relaxed/simple; bh=aMfrtpJfBOiXKmBbBBiTd4B9RwqjV9I8XH/PnCjOsA0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ARO3jt+UVHAFrPHzSmOUCfxAyBlRuG14Hl4K5W3uQISzMrxdaL1fhplDnwk5ASZMSu3MXT/JpwSsJ6eJT/HtkRqAhxAhkHWWwu73UcDIcCqrL68ENFrkFUlxjg0a4QBNY00G4M3Uba98xKR7N92Y182mCsVYmbDHNyHhOUFORMU= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=gHe7V//f DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 751464BAE7E9 Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 691Dar4L1887560; Thu, 1 Oct 2026 15:29:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=1ZFDGlvtUewgHiUof S4+iVR8+Neqn+kGS/blfJ0CSo8=; b=gHe7V//fhBQPn/gw3fqjJuBB+VK6pwB5o vcwouf9KgUgYXVhwPymLVCPkM2sjB8eNdGSM9emsUG41DNRBVVFYmA7RbxwMuBjp MO0rhz2QN/+4hD6GcTaMlSyD51kQUZCaIxI+zNU6Agz1l9jMAsZWPo9oJmnRFqeP 6YUIbwEdt1XeUeL5WJXVHOra6WKjSNa7QoC3bwb2e7V8S7E3fTrC84wJpmcEr8yk TjU0x8FCOpHiyatRKaNkmwUyaCKV/lt0cSPycPexD5YEMzsGB+Ug6mPF5xt8uMrj 7lWwZm8CazbqauG8j6TEYKvzQpQfNDcspN7OI78XM2L54/N06DmKQ== Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4gx5s5m1eb-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 01 Oct 2026 15:29:01 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.11/8.18.1.11) with ESMTP id 691E2hO11000234; Thu, 1 Oct 2026 15:29:00 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4h0xcsejrw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 01 Oct 2026 15:28:59 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 691FSwuM6947276 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 1 Oct 2026 15:28:58 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D1F382004F; Thu, 1 Oct 2026 15:28:57 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A62E92006A; Thu, 1 Oct 2026 15:28:57 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.87.85.9]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 1 Oct 2026 15:28:57 +0000 (GMT) From: Jens Remus To: binutils@sourceware.org, Richard Earnshaw , Alice Carlotti , Chenghua Xu , Zhensong Liu , Palmer Dabbelt , Andrew Waterman , Jim Wilson , Nelson Chu , Kito Cheng Cc: Jens Remus Subject: [PATCH v2 1/3] aarch64: Fix h->got union phase confusion for DT_RELR Date: Thu, 1 Oct 2026 17:28:56 +0200 Message-ID: <20261001152854.3367296-6-jremus@linux.ibm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261001152854.3367296-5-jremus@linux.ibm.com> References: <20261001152854.3367296-5-jremus@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-Spam-Info: AW1haW4tMjYxMDAxMDA2MCBTYWx0ZWRfX71wSG3msKHgV oJgT9j8hDRxbleQkaF0uxBt3Fqf+lgSFjENlSeeUd0Yic4G2T38mmpURJVA5biyUgd1ppLSD5bS Wm/3qVjW8XIhkrtMhogQ8iYUIxxKTP4= X-Authority-Analysis: v=2.4 cv=HJ5WhYtv c=1 sm=1 tr=0 ts=6abe7c3d cx=c_pps a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17 a=660iZSQnnn4A:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=U7nrCbtTmkRpXpFmAIza:22 a=VnNF1IyMAAAA:8 a=Zxp1udWUC5FwEj-EubUA:9 X-Proofpoint-GUID: ylE_0D5PJ3Z2qXA4udplGTE8BXvuba3C X-Proofpoint-ORIG-GUID: Oxjs3CvIdbMJFSZyR89IlevbhQvdEsiQ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDAxMDA2MCBTYWx0ZWRfX348Qa2z+veD9 7nyfcC/jBaJKLSbNfFTAbKGIwieJXlyiR6LG3UQ9U1XE3w+t/SsuFiItzRJ5I8J7Zp5b0Ez3Chu lwzHjIetvIcbmuV+6LZGY7ar2Wx5ZnoIEUpjXZwM6Cn18Iw2cQXmf9g1WaKS0d14qKXxlyJqK7a 5NH1qCPvVKPvduCdzJ0MmPIpaZata2vidbC4WPEeb5dyuTU4DU/mvcZT3uP9NaBYcSt0VHjk7aG hMiyLOQsznDibfUSIpcc9EVRwnQuW0N8zFwwoygXOk6r6Icyfk478dY+l4GUMdDTBbxTDEWtDxt 6+Nj4P8tpLZq64AWCZly4CDSCxBM+Q8jIQRrhZQ4xChuCguD51h23LhEN1OXXZBj7jhywyfI1c6 W5gLbY+RadHPXxjnlomfi/AqwFgU7Y/u9rR3QPrwA6VB3HgW5mFo8nb/q9sQEoC7OkP0XZfKdQG JfDb+Btvbd6Gpjd0l3A== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-01_04,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 bulkscore=0 clxscore=1015 lowpriorityscore=0 spamscore=0 impostorscore=0 phishscore=0 priorityscore=1501 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2610010060 X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, RCVD_IN_PBL, SPF_HELO_NONE, SPF_PASS, TXREP shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org record_relr_dyn_got_relocs is called after allocate_dynrelocs has repurposed h->got from refcount to offset semantics. This goes along with a change in indication for no GOT entry allocated from h->got.refcount <= 0 to h->got.offset == (bfd_vma)-1. bfd/ * elfnn-aarch64.c (record_relr_dyn_got_relocs): Fix h->got union phase confusion. Signed-off-by: Jens Remus --- bfd/elfnn-aarch64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bfd/elfnn-aarch64.c b/bfd/elfnn-aarch64.c index ce060dd755b9..c89390e69493 100644 --- a/bfd/elfnn-aarch64.c +++ b/bfd/elfnn-aarch64.c @@ -9246,7 +9246,7 @@ record_relr_dyn_got_relocs (struct elf_link_hash_entry *h, void *inf) h = (struct elf_link_hash_entry *) h->root.u.i.link; if (h->type == STT_GNU_IFUNC && h->def_regular) return true; - if (h->got.refcount <= 0) + if (h->got.offset == (bfd_vma) -1) return true; if (elf_aarch64_hash_entry (h)->got_type != GOT_NORMAL) return true;