From patchwork Mon Aug 24 21:41:37 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vineet Gupta X-Patchwork-Id: 142120 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 703384BA79A3 for ; Mon, 24 Aug 2026 21:42:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 703384BA79A3 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=SVYguhf4 X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mta0.migadu.com (out-166.mta0.migadu.com [IPv6:2001:41d0:1004:224b::a6]) by sourceware.org (Postfix) with ESMTPS id A0BEC4BA798D for ; Mon, 24 Aug 2026 21:41:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A0BEC4BA798D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.dev ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A0BEC4BA798D Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2001:41d0:1004:224b::a6 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787607709; cv=none; b=hflyD4W9dZ0NoGEG5GKhlQcKDhLPt8SvPoxNSBLCfbP+oX1zLEW6zWJ/V3C0uFT2eroIn5XH7kt51kpRJidO1UwQjLX1kamReJ+Uk4z4A2MXoUlZyMWTYVWeWRiwf/jlDmNRdb/C3O/UqQQqA/HTMH+ELdMhTa7cbnsxtEMV0tA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787607709; c=relaxed/simple; bh=D69S4l9zCc6rLU/PO2G+f/9iQbB7Xcy+XNoHoeaT9oQ=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=KlL6LxmOHpsqchPpdDNQH0nudTZbOnOX2o9PJ52zleTuA17zgpXQw707aPLFEaVmWkOE9NpmYMov8hitQgHXPfFWrVO1nH/i2EIvnTkmZ5LaLX+tIQ802OyxEB7qPEvHd+2h99k5LHqkA7oztn6WHsNw5Ax/qSEllDCK5KCKyTU= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=SVYguhf4 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A0BEC4BA798D X-Envelope-To: binutils@sourceware.org DKIM-Signature: a=rsa-sha256; bh=D69S4l9zCc6rLU/PO2G+f/9iQbB7Xcy+XNoHoeaT9oQ=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1787607708; v=1; x=1788212508; b=SVYguhf4mtX+u76MVR7PgHQmSmOYoh0la2aUCFBnI/mRlyx6hxy8FD/X3uY2dD1v9nxoHx38 rqmUhRxHsYD99OYsyI0aNg9S8hr4d7YqIqKMOtzntemjEdghCTEv0J6rFcgHrGPoJALdbA8t2iv 6BBJbQgweYHoASMV17fMBKaE= X-Envelope-To: binutils@sourceware.org Received: from gvineet-fedora-PF5JGVFY.thefacebook.com (2620:10d:c090:500::4:2c42) by smtp.migadu.com with ESMTPS id 4af32cc1290901f3; Mon, 24 Aug 2026 21:41:48 +0000 X-Mizu-Trace-ID: 4af32cc1290901f3 X-Migadu-Flow: FLOW_OUT From: Vineet Gupta To: binutils@sourceware.org Cc: bpf@gcc.gnu.org, jose.marchesi@oracle.com, ast@kernel.org, Vineet Gupta Subject: [PATCH v2 1/2] gas: bpf: actually run the pseudo-C spacing test Date: Mon, 24 Aug 2026 14:41:37 -0700 Message-ID: <20260824214138.3964162-2-vineet.gupta@linux.dev> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260824214138.3964162-1-vineet.gupta@linux.dev> References: <20260824214138.3964162-1-vineet.gupta@linux.dev> MIME-Version: 1.0 X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_PASS, SPF_PASS, TXREP shortcircuit=no autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org spacing-pseudoc.{s,d} has been present since the pseudo-C dialect tests were added, but bpf.exp never had a run_dump_test entry for it, so it has never been executed. Enabling it exposes a second problem: the .d declares -EB while its expected encodings are little endian, so the test fails on byte order alone. Every other big endian BPF test carries a -be suffix in its name, and this file does not, so -EL is what was meant. With both fixed the test passes, and the flexible spacing it documents -- goto+1, goto1 and the same forms inside a conditional jump -- is covered from now on. gas/ * testsuite/gas/bpf/bpf.exp: Run spacing-pseudoc. * testsuite/gas/bpf/spacing-pseudoc.d: Assemble little endian, to match the expected encodings and the file name. --- gas/testsuite/gas/bpf/bpf.exp | 2 ++ gas/testsuite/gas/bpf/spacing-pseudoc.d | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/gas/testsuite/gas/bpf/bpf.exp b/gas/testsuite/gas/bpf/bpf.exp index f19322122527..74b0461f0bcb 100644 --- a/gas/testsuite/gas/bpf/bpf.exp +++ b/gas/testsuite/gas/bpf/bpf.exp @@ -76,6 +76,8 @@ if {[istarget bpf*-*-*]} { run_dump_test jcond-be run_dump_test jcond-be-pseudoc + run_dump_test spacing-pseudoc + # Overflow tests run_dump_test offset16-overflow run_dump_test disp16-overflow diff --git a/gas/testsuite/gas/bpf/spacing-pseudoc.d b/gas/testsuite/gas/bpf/spacing-pseudoc.d index 16f5763aeb00..48ea4d9a1a92 100644 --- a/gas/testsuite/gas/bpf/spacing-pseudoc.d +++ b/gas/testsuite/gas/bpf/spacing-pseudoc.d @@ -1,4 +1,4 @@ -#as: -EB -mdialect=pseudoc +#as: -EL -mdialect=pseudoc #source: spacing-pseudoc.s #objdump: -dr -M hex,pseudoc #name: spacing, pseudoc syntax