From patchwork Thu Aug 20 15:36:20 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Dubiec X-Patchwork-Id: 141846 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A69ED4BAE7E5 for ; Thu, 20 Aug 2026 15:44:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A69ED4BAE7E5 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=o2.pl header.i=@o2.pl header.a=rsa-sha256 header.s=20241105 header.b=gOtFMyxV X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mx-out.tlen.pl (mx-out.tlen.pl [193.222.135.145]) by sourceware.org (Postfix) with ESMTPS id 4C68F4BA2E06 for ; Thu, 20 Aug 2026 15:43:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4C68F4BA2E06 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=o2.pl Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=o2.pl ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4C68F4BA2E06 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=193.222.135.145 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787240622; cv=none; b=C/e6yLCkwP6FQjHNOkGbYjSmsCUtbwH4qOuPb+jDAUPze9i8N8zd2zzV8Qb4DX/ZuLOv0VrzxWtuJzNu12MdA6tNGXZvkvOVtoFEnGo8Wj5+dWcvhjcj6fR+dgrYV61kJczoqw+Ju2ORiy3jfmpotNbjb7kvhWEdcq0Q5KEo3pI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787240622; c=relaxed/simple; bh=MNI8fjbql+BEjJdI74J+GeVo+NvY+QbwAeOtdm9v8VE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=wv+D9Cco/5/dH+15xpXYsNZLbgp2GYrVpSpfxofjPDp0LA0VeKHOI3sOXXrzbnMJDu+gW7FaiLjtfryN7DzKNN9bSvalgOqCwO79Ix5EbfN2rxABS/uXPgTR4YSgf1NsgThFGsgtkB7oKqGKhgUz6oEeLZICxxWxHP4ekD1b4RI= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=o2.pl header.i=@o2.pl header.a=rsa-sha256 header.s=20241105 header.b=gOtFMyxV DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4C68F4BA2E06 Received: (wp-smtpd smtp.tlen.pl 40205 invoked from network); 20 Aug 2026 17:36:59 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=o2.pl; s=20241105; t=1787240220; bh=yiGr2rlosvijUgkfxTf/S1Nau6OeJ/DwCZiHOUcgZGc=; h=From:To:Cc:Subject; b=gOtFMyxVzi1A4cO4nhkfoVsLW2q+pwvT+aPHGyr7164QKNbi6rnhQpv6vF2LnUC35 VwDAjgMwR9aQRHbNnZPx2Zblm7B7jXtSxH56/5DIy7YHy/jXftj3qAEaWufrTbVNJQ AaY8krhAVpWIR2hi0OHNPBUZC1/gmrMqJ7goCynOixX3VqptR8dLWlWDSEi/8wwzzv dsQxEFuxNYAi+AFXWsxNTQIGKGozT60p7oNJlcyrjXUEqDuSxUp1FMhgDqV0/5xbQQ PMbAYnISXkoF1UZEQTPxeytDAO34AZVU2hSBWCwLkc4umakVx9GPHixqIbVGb+2oVl 6ccThKjH2+IOQ== Received: from jdxpc (ip-94-42-230-53.multimo.pl [94.42.230.53]) (envelope-sender ) by smtp.tlen.pl (WP-SMTPD) with TLS_AES_256_GCM_SHA384 encrypted SMTP for ; 20 Aug 2026 17:36:59 +0200 From: Jan Dubiec To: binutils@sourceware.org Cc: Jan Dubiec , Jeffrey Law Subject: [PATCH] H8/300: sim: Fix simulator hang caused by qsort on Windows/MinGW. Date: Thu, 20 Aug 2026 17:36:20 +0200 Message-ID: <20260820153650.1429626-1-jdx@o2.pl> X-Mailer: git-send-email 2.55.0 MIME-Version: 1.0 X-WP-MailID: e16ef027a9753d28925e5c7bee2e491a X-WP-AV: skaner antywirusowy Poczty o2 X-WP-SPAM: NO 0000005 [YSbB] X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, RCVD_IN_PBL, SPF_HELO_NONE, SPF_PASS, TXREP shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org See the comment below. I don't know why qsort behaves so strangely. It could be a bug, or simply a consequence of its being an unstable sort. Unfortunately, I don't have time to investigate the root cause. Signed-off-by: Jan Dubiec --- sim/h8300/compile.c | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/sim/h8300/compile.c b/sim/h8300/compile.c index 06988095228..c08f7704ef3 100644 --- a/sim/h8300/compile.c +++ b/sim/h8300/compile.c @@ -1568,6 +1568,41 @@ store2 (SIM_DESC sd, ea_type *arg, int n) return store_1 (sd, arg, n, 1); } +#ifdef __MINGW32__ +/* On Windows/MinGW, qsort for some reason produces a "shuffled" opcode +table instead of a sorted one, causing the entire simulator to hang. + +This is a simple insertion sort implementation, but it has virtually +no impact on simulator performance. */ + +#define qsort opcode_insertion_sort + +static void +opcode_insertion_sort(void *base, size_t nmemb, size_t size, + int (*compar)(const void *, const void *)) +{ + unsigned char *a = base; + struct h8_opcode tmp; + size_t i, j; + + if (nmemb < 2 || size == 0) + return; + + for (i = 1; i < nmemb; ++i) { + memcpy(&tmp, a + i * size, size); + + j = i; + while (j > 0 && compar(&tmp, a + (j - 1) * size) < 0) { + memcpy(a + j * size, a + (j - 1) * size, size); + --j; + } + + memcpy(a + j * size, &tmp, size); + } + +} +#endif /* #ifdef __MINGW32__ */ + /* Callback for qsort. We sort first based on availability (available instructions sort lower). When availability state is the same, then we use the first 4 bit nibble as a secondary