diff mbox series

[v1] gas: Fix copy-paste error in struct frag comment

Message ID 20260818071920.3486364-1-mengqinggang@loongson.cn
State New
Headers
Series [v1] gas: Fix copy-paste error in struct frag comment |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_binutils_build--master-aarch64 success Build passed
linaro-tcwg-bot/tcwg_binutils_check--master-aarch64 success Test passed
linaro-tcwg-bot/tcwg_binutils_build--master-arm success Build passed
linaro-tcwg-bot/tcwg_binutils_check--master-arm success Test passed

Commit Message

mengqinggang Aug. 18, 2026, 7:19 a.m. UTC 
  The comments for fr_offset and fr_symbol in struct frag were misleading.
fr_symbol is used to store the symbol associated with the frag,
not for the variable-length tail.
---
Changes in V1:
- Add ", if any".

 gas/frags.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alan Modra Aug. 22, 2026, 3:59 a.m. UTC | #1 
On Tue, Aug 18, 2026 at 03:19:20PM +0800, mengqinggang wrote:
> The comments for fr_offset and fr_symbol in struct frag were misleading.
> fr_symbol is used to store the symbol associated with the frag,
> not for the variable-length tail.
> ---
> Changes in V1:
> - Add ", if any".

Please apply.

>  gas/frags.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gas/frags.h b/gas/frags.h
> index ebb6fa626ac..dded4bb33f1 100644
> --- a/gas/frags.h
> +++ b/gas/frags.h
> @@ -48,7 +48,7 @@ struct frag {
>    offsetT fr_var;
>    /* For variable-length tail.  */
>    offsetT fr_offset;
> -  /* For variable-length tail.  */
> +  /* Symbol associated with the frag, if any.  */
>    symbolS *fr_symbol;
>    /* Points to opcode low addr byte, for relaxation.  */
>    char *fr_opcode;
> -- 
> 2.34.1
mengqinggang Aug. 23, 2026, 2:03 a.m. UTC | #2 
Applied,  thanks.


在 2026/8/22 11:59, Alan Modra 写道:
> On Tue, Aug 18, 2026 at 03:19:20PM +0800, mengqinggang wrote:
>> The comments for fr_offset and fr_symbol in struct frag were misleading.
>> fr_symbol is used to store the symbol associated with the frag,
>> not for the variable-length tail.
>> ---
>> Changes in V1:
>> - Add ", if any".
> Please apply.
>
>>   gas/frags.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/gas/frags.h b/gas/frags.h
>> index ebb6fa626ac..dded4bb33f1 100644
>> --- a/gas/frags.h
>> +++ b/gas/frags.h
>> @@ -48,7 +48,7 @@ struct frag {
>>     offsetT fr_var;
>>     /* For variable-length tail.  */
>>     offsetT fr_offset;
>> -  /* For variable-length tail.  */
>> +  /* Symbol associated with the frag, if any.  */
>>     symbolS *fr_symbol;
>>     /* Points to opcode low addr byte, for relaxation.  */
>>     char *fr_opcode;
>> -- 
>> 2.34.1
diff mbox series

Patch

diff --git a/gas/frags.h b/gas/frags.h
index ebb6fa626ac..dded4bb33f1 100644
--- a/gas/frags.h
+++ b/gas/frags.h
@@ -48,7 +48,7 @@  struct frag {
   offsetT fr_var;
   /* For variable-length tail.  */
   offsetT fr_offset;
-  /* For variable-length tail.  */
+  /* Symbol associated with the frag, if any.  */
   symbolS *fr_symbol;
   /* Points to opcode low addr byte, for relaxation.  */
   char *fr_opcode;