From patchwork Sun May 24 03:06:17 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Will Hawkins X-Patchwork-Id: 135511 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DE7194BAD17A for ; Sun, 24 May 2026 03:06:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DE7194BAD17A Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=obs-cr.20251104.gappssmtp.com header.i=@obs-cr.20251104.gappssmtp.com header.a=rsa-sha256 header.s=20251104 header.b=FUhJy4kB X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-ot1-x336.google.com (mail-ot1-x336.google.com [IPv6:2607:f8b0:4864:20::336]) by sourceware.org (Postfix) with ESMTPS id B83EC4B9DB43 for ; Sun, 24 May 2026 03:06:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B83EC4B9DB43 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=obs.cr Authentication-Results: sourceware.org; spf=none smtp.mailfrom=obs.cr ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B83EC4B9DB43 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::336 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779591982; cv=none; b=fpg4HfdC+l70jz1W6GC7C37neVzaspJU/BsskN9Be3uq5bsMBej7Kx5Y08ZIReoguDdaP5p5LNXMNpB3KqfVnXAB/VMNyucg/KhMZZSblr1ct9LvlvSt7Ll0n/wT+5Oq2EN1MqsVFcXR+grPYSbogb69KYqMN8qCkhW5F9nEYPU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779591982; c=relaxed/simple; bh=Snk/uQrgNBDWJ+EgPR6K/MtjQIckUwAqIMhJwCmkiqU=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=dRx4rgiS3T02Z0+ZQlPXfG+bcM0UBL70WFpnVyp4wtSZ8bk8k96OZ22jVIkj/i4+uax6s8+3Wf89wp+/bu0ocrmZPrjWwggLy1Hhj/kTAc4Py06JQCaHieEW2ZqcsS1aaeo0ZzaGAeZ7VdGknG0l+aBCuQZTpVRBzg7LA1sDXBw= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=obs-cr.20251104.gappssmtp.com header.i=@obs-cr.20251104.gappssmtp.com header.a=rsa-sha256 header.s=20251104 header.b=FUhJy4kB DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B83EC4B9DB43 Received: by mail-ot1-x336.google.com with SMTP id 46e09a7af769-7e634c4b74dso100757a34.1 for ; Sat, 23 May 2026 20:06:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=obs-cr.20251104.gappssmtp.com; s=20251104; t=1779591982; x=1780196782; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=PYUpjJlcAtDB1mzyv9Fs4/s9eMwbwlFtSXhYkRv5BL8=; b=FUhJy4kBSx7ZQwdfgxMrnUXomVTU1TZqlSTVkbPj8+qQernGjsfkAUGRxVIyPhyn9J C2NFJzk0EEWaWBr48feOHRYmL4vTsuTT1O+AZxJo6R4KTaNddTmLZ7uGe/DcV9v2RRA4 hd4sYqAFwgCs/mLL4qCZC/BkcgMI0ywuW8za+SCjKtSYsOH38IAPmpKcqlVNKk8w+9KB gnj+petMlfbG9AbTShDjbD3PZXn40yhPxA6Rnl4G7b5mpHxJfu5FJrAu50DUejaY++WE Pou4s3Xz2ktNdtWvOuHAzVTfo4ZoZwqaqsfojiNCujM7utvQkae3A39hv1PwqJnqN2eL BDdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779591982; x=1780196782; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PYUpjJlcAtDB1mzyv9Fs4/s9eMwbwlFtSXhYkRv5BL8=; b=CUKhnHO/c/tEyS3bqiDSns9zObVg+cruAecaBljWXfnqDeOn3k3/Jvvnb5CyxN9I10 pAdXD13zgWQxZ+VIRXPwwcRY1UYWguTtRNVUHOZAcvEZReJVUPyaMWKHtuecTZE6fYT1 enfSS3UDxE/aojlSZ0QL/4vKB7SLF43CCCKeDL8Y6KUnuji7n/0/qlu3hU0Ayzd7Sr58 m8LGQ00PJYBwklwWLj8+FHWXBV9fQKehhBy/JCdpAide6jMi4scziRT5U8BMKROWx5H3 HHFasV77G7NS/8JCiJxSCV7aKl7y57oyDsnwFY+hQRF8WkVuapqtbKIlEm1JI5Lq/Po1 goHg== X-Gm-Message-State: AOJu0YzD5JFmKdDJBq1mm6SHHNgVII9tY1CaU3MiDSdFxikxdPFD20rL dHQN/LkcLlQ+KSM8cWhcEOSGwHhbkQ2i/SaPsfDi/ZvsaZVVD0fkXBMjPmWZrhhRJUtghwl7vo+ WAdMziYw= X-Gm-Gg: Acq92OFHEtCvZbDbg/4eRlnX4tsfk040yT+kAuSoq5FJYoWOGbovw03NdjF6Q2WJ/9a RxU085fB5q6YnKnjLREGa/foQpUMlClO/tVGtRvZz4SEX4k3HpoCvdxu8cjFo644XovjJal42wI iw41eQL2v8styquIl6PuhRAgXcAiEvFOAif5FQS3VY+rePBAoTKoecL2mnGg7WbFoL0xHBxM+9i xP8TkKRSNyEmLBhIiH4i4s1Ywp+eQqXHqQwWEjp+20LY0imMtiEeRvmyvH2lmcGjz4xZfAN1vd9 /xt3pzf4ezed75HD5Ado95+13rRhFgU7l9K2G9qcfY0dmG4dlbpmXVfJEjfZ7Bt5IMzdNgg382B X4zP9zgL6qjqUKQoLmTOJ1X1KtVWoJHs0SmWKywNiIl0ENe4CNxhR2/2gib5s/InxOTWvuur/CJ cNSMcaGQef4V1bfg4qrqniObE31ut79kLYFnvyR11PVnb1bJt0YO141ps+sv8fl1PhrABhfhr8G q4g5hZYoKu0DH2Sl+PRU1/wEk7T6XiJpBlmzVEvncGLPhLJY4NsH/8RghCeaDk8TBbk X-Received: by 2002:a05:6830:264b:b0:7d7:e844:7f4e with SMTP id 46e09a7af769-7e5fee6e63cmr7083383a34.22.1779591982076; Sat, 23 May 2026 20:06:22 -0700 (PDT) Received: from ininer.rhod.uc.edu ([129.137.96.15]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7e606667796sm4401920a34.23.2026.05.23.20.06.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 May 2026 20:06:21 -0700 (PDT) From: Will Hawkins To: binutils@sourceware.org Cc: Will Hawkins Subject: [PATCH v2] x86/disasm: do not use format string without format specifiers Date: Sat, 23 May 2026 23:06:17 -0400 Message-ID: <20260524030619.1313131-1-hawkinsw@obs.cr> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, RCVD_IN_DNSWL_BLOCKED, RCVD_IN_PBL, SPF_HELO_NONE, SPF_NONE, TXREP, URIBL_BLOCKED shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org Fixes build failure with -Werror=format-security on i686. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34168 Signed-off-by: Will Hawkins --- v2: Update commit message to reference Bugzilla opcodes/i386-dis.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/opcodes/i386-dis.c b/opcodes/i386-dis.c index 1faf1fa7785..db1e4f7a7d5 100644 --- a/opcodes/i386-dis.c +++ b/opcodes/i386-dis.c @@ -10375,7 +10375,7 @@ print_insn (bfd_vma pc, disassemble_info *info, int intel_syntax) for (i = 0; i < MAX_OPERANDS; i++) if (ins.op_index[i] != -1 && ins.op_riprel[i]) { - i386_dis_printf (info, dis_style_comment_start, sep); + i386_dis_printf (info, dis_style_comment_start, "%s", sep); sep = ", "; (*info->print_address_func) ((bfd_vma)(ins.start_pc + (ins.codep - ins.start_codep) @@ -10384,11 +10384,11 @@ print_insn (bfd_vma pc, disassemble_info *info, int intel_syntax) } else if (*ins.cm_out[i]) { - i386_dis_printf (info, dis_style_comment_start, sep); + i386_dis_printf (info, dis_style_comment_start, "%s", sep); sep = ", "; i386_dis_printf (info, dis_style_symbol, "%s", ins.cm_out[i]); } - + ret = ins.codep - priv.the_buffer; out: info->private_data = NULL;