From patchwork Sat May 23 11:17:57 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Will Hawkins X-Patchwork-Id: 135498 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6AEE04BB593D for ; Sat, 23 May 2026 11:18:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6AEE04BB593D Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=obs-cr.20251104.gappssmtp.com header.i=@obs-cr.20251104.gappssmtp.com header.a=rsa-sha256 header.s=20251104 header.b=HZvkBmOn X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-ot1-x329.google.com (mail-ot1-x329.google.com [IPv6:2607:f8b0:4864:20::329]) by sourceware.org (Postfix) with ESMTPS id 3A54A4BAE7C2 for ; Sat, 23 May 2026 11:18:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3A54A4BAE7C2 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=obs.cr Authentication-Results: sourceware.org; spf=none smtp.mailfrom=obs.cr ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3A54A4BAE7C2 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::329 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779535083; cv=none; b=SkEJNFXxWs+nptouj52pAO749qCT8u64eltTr82moRKEQghsV5Rqk92EGKzwmVFhvdw+F9AGAfcyVUSB0n3tCfxKLNAcFlLdoAEiU7StkNqn/HDxAX3vGVshvt63uVqOubSqwmR6Z5XXcyyiX33gy19qkKT3jKI89IMVRL3YxOk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779535083; c=relaxed/simple; bh=cIfmfCCs9KYTlVyVqRfKIYD26sxQByCvPWZi5AQH5QM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=m2prNetfENxXup4ru86xJ2iKRB7wl7y4eVzrzK1sol51pcuGfSUzw+Bd6izBqfHGouSkg+s9VyZTY06cEyQRfnusvHXd8z84sZtrabCllNgcXVqTCPU39K2YD0coqQuo7exWoHSqp+DddwS2McVK/G1p4V3fxTvbfgOOnbNF5Cc= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=obs-cr.20251104.gappssmtp.com header.i=@obs-cr.20251104.gappssmtp.com header.a=rsa-sha256 header.s=20251104 header.b=HZvkBmOn DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3A54A4BAE7C2 Received: by mail-ot1-x329.google.com with SMTP id 46e09a7af769-7dcdaf06498so5449038a34.2 for ; Sat, 23 May 2026 04:18:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=obs-cr.20251104.gappssmtp.com; s=20251104; t=1779535082; x=1780139882; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=uvDGQ+quZzlnXFBwVblJcTPRZKJPD9EnI7ltrDs/7wo=; b=HZvkBmOnQNJGhvcXOwsQiXhaKMcBIF277k3+auMKxm+J2tJahz9xJ+JCHor/iSZJNj d9DF19RsXWf5RZcuZeNOI7mpXonoadbu0ivMFEJd7DA3Xh17U0pqrR/NA8T77SCmN1m0 EMeBcoJPiDSXZyybZtM4fDdU0eHbOpRe/y+1n25MRiCbp9eQbtMaw7jXBlDowiJ2Gba9 2vZar7y2ceaM1Eo/egtILbDBKeD++5Xf+arJf7lIEVp9xStlzZygsrUGY+YCnVTcNtEi Vp6a5vnVGWOrCKPwMXIK3MgagahcNfzGjJC6q2vvLA9tcoaVEAK8T3hjcJKFAbixtMNl VIBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779535082; x=1780139882; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=uvDGQ+quZzlnXFBwVblJcTPRZKJPD9EnI7ltrDs/7wo=; b=j8s/tSCekoXBIQtzqsEfkkQ3gkHXC4D0fn63AmX5yilXYbvxAaS2HpuKFhSlngxXZK 8X+S0tolVN0xW/4ASmqNMZt6aldMs865HSb364+oMD1Gn7uwQ7g6B1MU+PO2DmGz2/80 d3bA2jtTOiu8G52TGWqZvkDJ0xQtLPq8vdOzp5NvGpkyEWUS/sbd7Xs+sndqGdFwJx3N /D7a1Rms746/gTrdGd7ypz8Z7a3e88atGWhBS6cO/35K3PVLAOGJS4H+DSq/hg2FLJ6I 3MiXBWYDPRb9sOEt5UDlSBK3NsVSP6vyW8QfBCuZjWhPKu/iUhHK1B+oQJcwu2f5p2ks B2OQ== X-Gm-Message-State: AOJu0YzS8FI7NSx7prAqQn1ozGm+QqlVwS/DnVdSdI44Yx/6dp099DTv IYKkJ/IxubFLPZuz9di827/ykf9Rakoww3ktlCLDrDA/xsOV5QrXMGm74AEl/WSDlsK6KFp2F0a Fs5GtGhs= X-Gm-Gg: Acq92OFZKxxpAryBgdVq3FIQWyv6gN66OMtPoBEIyKwyyuzhkuQNwURj87zFKRTPDe4 K+DgSUeRENSYNyIbuXAR6cwIjUFV5ZRifFf95XIFxneHcExh1nZLaNKJUUQJTKUNobeLTMGTcPc g4e/BRfpXuuQrn7+1wz2MWFhWWHDAreUJi1ADzEux/tmSCuxb8r5ImZp+I0b+SCD0Hq/6SjQAjJ ZxnLrhcuRM3vuH3Sppyw2XHXqBqqmLpXGo9JPvMwhibHotgh1EQH2d0AKcKtORLLwx4taWY5fXb 4LbEB1h8Wu+/AiFx3K1rj3GcakA2Hx3burw6T7v2vuDZfloKsYKOt/Cd/upR0m5CIzNhbk3tV4p 3ovwAeq2HDJHcHzXuPi2VEchlLqqlwskGnl2gKJxB6iB6BKb9JqCkRV9i2QZ97WTx8/hzDqL/a3 DgFu6ROl2vBggxhG3OQWC0NQKyPdVPVWcSVlhraguAgHJ06nd5bOUdxD8IGFLIktkiKLuQp1Vcz cMD77PHJzlHLaLEd1xWcYiF/RLRE4aW3Jnz6XYbOrcefPof7aUG5vi5tNmAc2wurJ+skNwc6ssz ua4= X-Received: by 2002:a05:6830:3c8c:b0:7dc:c620:aa0c with SMTP id 46e09a7af769-7e5ff0b17abmr4700794a34.25.1779535082481; Sat, 23 May 2026 04:18:02 -0700 (PDT) Received: from ininer.rhod.uc.edu ([129.137.96.15]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7e6064828e6sm3023392a34.7.2026.05.23.04.18.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 May 2026 04:18:01 -0700 (PDT) From: Will Hawkins To: binutils@sourceware.org Cc: Will Hawkins Subject: [PATCH] x86/disasm: do not use format string without format specifiers Date: Sat, 23 May 2026 07:17:57 -0400 Message-ID: <20260523111759.1294571-1-hawkinsw@obs.cr> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, RCVD_IN_DNSWL_BLOCKED, RCVD_IN_PBL, SPF_HELO_NONE, SPF_NONE, TXREP shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org Signed-off-by: Will Hawkins --- opcodes/i386-dis.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/opcodes/i386-dis.c b/opcodes/i386-dis.c index 1faf1fa7785..db1e4f7a7d5 100644 --- a/opcodes/i386-dis.c +++ b/opcodes/i386-dis.c @@ -10375,7 +10375,7 @@ print_insn (bfd_vma pc, disassemble_info *info, int intel_syntax) for (i = 0; i < MAX_OPERANDS; i++) if (ins.op_index[i] != -1 && ins.op_riprel[i]) { - i386_dis_printf (info, dis_style_comment_start, sep); + i386_dis_printf (info, dis_style_comment_start, "%s", sep); sep = ", "; (*info->print_address_func) ((bfd_vma)(ins.start_pc + (ins.codep - ins.start_codep) @@ -10384,11 +10384,11 @@ print_insn (bfd_vma pc, disassemble_info *info, int intel_syntax) } else if (*ins.cm_out[i]) { - i386_dis_printf (info, dis_style_comment_start, sep); + i386_dis_printf (info, dis_style_comment_start, "%s", sep); sep = ", "; i386_dis_printf (info, dis_style_symbol, "%s", ins.cm_out[i]); } - + ret = ins.codep - priv.the_buffer; out: info->private_data = NULL;