From patchwork Fri May 22 12:16:18 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 135452 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EE43148F5366 for ; Fri, 22 May 2026 12:16:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EE43148F5366 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=n9EhHD4z; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ZKoKtsnG; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=n9EhHD4z; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ZKoKtsnG X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 7FEEA49002D5 for ; Fri, 22 May 2026 12:16:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7FEEA49002D5 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7FEEA49002D5 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779452180; cv=none; b=XEMhWlJD06+tIp9ITdjzR2SsA5HKA2EANg8hJjBx5e2iLfY9hEP1i1lNHHcGX4Ud0GInLt9/k9ZLKkhBX971jTDgfA0NmsZ3kFUUHjQel6r+0lWal+tEWz6B4aFqLzPu35dDYbwLmpMOm/JYPPe67nihp26+Pjs6MetsDpP6nPk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779452180; c=relaxed/simple; bh=roVbrpgIEHByittuOrlXvw7RjQQxQDwWfWLGZiehCqo=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=YyLgFAfBQX1kCcdYMN2s9sLv3aopfpp6bvb2BLxfz59SIcLxZXktusG27RkukaUg7J0fiQYTqtST30ECgNIBc8WPAwo49JzVbpElLSzkVm/XGM6gx2lN+vDjDVso6Y+zgHstf92TRSt0k5onNZM7Yole5x3N2t1bpN/IgiaOH88= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=n9EhHD4z; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ZKoKtsnG; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=n9EhHD4z; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ZKoKtsnG DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7FEEA49002D5 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9F5756BCA4 for ; Fri, 22 May 2026 12:16:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1779452179; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=u1QEtNePGdZNmXP00YRSxGbGC87QntrdSn36rXonYTs=; b=n9EhHD4zzviBuZwJ+FAxj+Kw6qMiTG/qz+1oU+8sODGYJLJWSJcezZw6abVnejuAcRWaN9 3+bdZLWchqEHZc4c1MYzINJ2GzE7rnvBS5JG/11C/qr6jJbem+9tf1E8y/ZNZngGrNL33W w5lEoEIRVYIBD6adB74LSxFiemdKEV8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1779452179; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=u1QEtNePGdZNmXP00YRSxGbGC87QntrdSn36rXonYTs=; b=ZKoKtsnGbOFb7RiTNoDv8q3vqoBz8j6IGpkPfJU5HDVwD5ZFV/JrnY8YYoSFsHOqcilLyq MdL4sERruxkQ3oBQ== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1779452179; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=u1QEtNePGdZNmXP00YRSxGbGC87QntrdSn36rXonYTs=; b=n9EhHD4zzviBuZwJ+FAxj+Kw6qMiTG/qz+1oU+8sODGYJLJWSJcezZw6abVnejuAcRWaN9 3+bdZLWchqEHZc4c1MYzINJ2GzE7rnvBS5JG/11C/qr6jJbem+9tf1E8y/ZNZngGrNL33W w5lEoEIRVYIBD6adB74LSxFiemdKEV8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1779452179; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=u1QEtNePGdZNmXP00YRSxGbGC87QntrdSn36rXonYTs=; b=ZKoKtsnGbOFb7RiTNoDv8q3vqoBz8j6IGpkPfJU5HDVwD5ZFV/JrnY8YYoSFsHOqcilLyq MdL4sERruxkQ3oBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6F2F0593A8 for ; Fri, 22 May 2026 12:16:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id F7apGRNJEGofbAAAD6G6ig (envelope-from ) for ; Fri, 22 May 2026 12:16:19 +0000 From: Tom de Vries To: binutils@sourceware.org Subject: [PATCH] [binutils] Handle implicit const in .debug_names Date: Fri, 22 May 2026 14:16:18 +0200 Message-ID: <20260522121618.1460707-1-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 X-Spam-Score: -2.80 X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,imap1.dmz-prg2.suse.org:helo]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[binutils@sourceware.org]; RCVD_TLS_ALL(0.00)[] X-Spam-Level: X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org I tried to use readelf to read the debug info for gdb test-case gdb.dwarf2/debug-names-tu-dwarf5.exp, and ran into some trouble reading the .debug_names section: ... $ readelf -w debug-names-tu-dwarf5 ... Symbol table: [ 1] #eddb6232 _start: <0><1> DW_TAG_subprogram DW_IDX_compile_unit=0 [ 2] #53a2ae86 struct_with_int_member:readelf: Warning: Unrecognized form: 0 readelf: Error: end of data encountered whilst reading LEB <0x3><2> DW_TAG_structure_type DW_IDX_type_unit=0 DW_IDX_GNU_language=0 DW_IDX_type_unitreadelf: Warning: Unrecognized form: 0 readelf: Error: end of data encountered whilst reading LEB ... The .debug_names abbreviation table contains a DW_FORM_implicit_const entry: ... .uleb128 0x2003 /* DW_IDX_GNU_language */ .uleb128 0x21 /* DW_FORM_implicit_const */ .sleb128 0x0002 /* DW_FORM_implicit_const value: DW_LANG_C */ ... and readelf doesn't support this. Add support for DW_FORM_implicit_const in display_debug_names, such that we get the expected: ... Symbol table: [ 1] #eddb6232 _start: <0><1> DW_TAG_subprogram DW_IDX_compile_unit=0 [ 2] #53a2ae86 struct_with_int_member: <0x3><2> DW_TAG_structure_type \ DW_IDX_type_unit=0 DW_IDX_GNU_language=2 ... --- binutils/dwarf.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) base-commit: 6dc6342541de90fbe8726c11c5a45f9475ffb815 diff --git a/binutils/dwarf.c b/binutils/dwarf.c index 42386154b49..4720dd717fa 100644 --- a/binutils/dwarf.c +++ b/binutils/dwarf.c @@ -12132,6 +12132,12 @@ display_debug_names (struct dwarf_section *section, void *file) READ_ULEB (form, abbrevptr, abbrev_table_end); if (xindex == 0 && form == 0) break; + + if (form == DW_FORM_implicit_const) + { + int64_t implicit_const; + READ_SLEB (implicit_const, abbrevptr, abbrev_table_end); + } } } @@ -12222,7 +12228,12 @@ display_debug_names (struct dwarf_section *section, void *file) if (tagno >= 0) printf (" %s", get_IDX_name (xindex)); - entryptr = read_and_display_attr_value (0, form, 0, + + int64_t implicit_const = 0; + if (form == DW_FORM_implicit_const) + READ_SLEB (implicit_const, abbrevptr, abbrev_table_end); + + entryptr = read_and_display_attr_value (0, form, implicit_const, unit_start, entryptr, unit_end, 0, offset_size,