From patchwork Thu May 7 19:44:00 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 134652 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DA8C64BA23F3 for ; Thu, 7 May 2026 19:46:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DA8C64BA23F3 X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 239444BA2E15 for ; Thu, 7 May 2026 19:46:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 239444BA2E15 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 239444BA2E15 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778183181; cv=none; b=LS6guIcOSTVcKRRxXjuwOCA2/xiMJqRajz1cCfIYT2MqymJJpRtol8T40f10LfKKNqoT3zX85ENeEZt6Xb6qIvTXhw113BzsNa2ntygKr9wLusS3HaXST6mzi2jQdTXNNzju3KxN0DIhgTI+xTGI9qIyEMkkMVgUPxcyrg+Ag70= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778183181; c=relaxed/simple; bh=RNaXZp82jh2TWdZD6tYPAGU8OoGkC5Yza0mZ5Rq6bEw=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=G6V0usupVyhajB3oV8UT77b9Oz5lj+7SCaftsgJBHuvKQERJTd8JxCNpumUw7ZyqHQmdcbeDqtnvh5oVRyaLv5cXs4Alw1jjywKR4RsFf8ARgnUWbxhTPX04KRa5pXYAFCCMCrmtGIAPirDH08bkkSpe5e4SHxBxFn5Za4pGG3I= ARC-Authentication-Results: i=1; sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 239444BA2E15 Received: by simark.ca (Postfix) id 3FCE01E0D1; Thu, 07 May 2026 15:46:19 -0400 (EDT) From: Simon Marchi To: binutils@sourceware.org Cc: Luis Machado , Simon Marchi Subject: [PATCH v2 4/4] include: add reference URLs in elf/amdgpu.h Date: Thu, 7 May 2026 15:44:00 -0400 Message-ID: <20260507194615.943267-5-simon.marchi@efficios.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260507194615.943267-1-simon.marchi@efficios.com> References: <20251031175411.1303161-1-luis.machado@amd.com> <20260507194615.943267-1-simon.marchi@efficios.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1165.8 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_NONE, KAM_DMARC_STATUS, KAM_SHORT, LOCAL_AUTHENTICATION_FAIL_DMARC, LOCAL_AUTHENTICATION_FAIL_SPF, RCVD_IN_DNSWL_BLOCKED, SPF_HELO_PASS, SPF_SOFTFAIL, TXREP, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org During review, a question was "where are those numbers that you are adding defined". Add some URLs pointing to the source of truth for those numbers. Change-Id: I11b7cb351a9b818fca66a532bfcd27286ec0ddfd --- include/elf/amdgpu.h | 28 ++++++++++++++++++++++------ 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/include/elf/amdgpu.h b/include/elf/amdgpu.h index c0bd74edfa01..ec703caafdb7 100644 --- a/include/elf/amdgpu.h +++ b/include/elf/amdgpu.h @@ -23,7 +23,9 @@ #include "elf/reloc-macros.h" /* e_ident[EI_ABIVERSION] values, when e_ident[EI_OSABI] is - ELFOSABI_AMDGPU_HSA. */ + ELFOSABI_AMDGPU_HSA. + + https://llvm.org/docs/AMDGPUUsage.html#amdgpu-elf-header-enumeration-values-table */ #define ELFABIVERSION_AMDGPU_HSA_V2 0 #define ELFABIVERSION_AMDGPU_HSA_V3 1 @@ -36,6 +38,10 @@ #define EF_AMDGPU_MACH 0x0ff #define EF_AMDGPU_MACH_AMDGCN_MIN 0x020 +/* EF_AMDGPU_MACH_* values + + https://llvm.org/docs/AMDGPUUsage.html#amdgpu-ef-amdgpu-mach-table */ + #define EF_AMDGPU_MACH_AMDGCN_GFX600 0x020 #define EF_AMDGPU_MACH_AMDGCN_GFX601 0x021 #define EF_AMDGPU_MACH_AMDGCN_GFX700 0x022 @@ -89,12 +95,16 @@ #define EF_AMDGPU_MACH_AMDGCN_GFX12_5_GENERIC 0x05b #define EF_AMDGPU_MACH_AMDGCN_GFX9_4_GENERIC 0x05f -/* Code object v3 machine flags. */ +/* Code object v3 machine flags. + + https://llvm.org/docs/AMDGPUUsage.html#amdgpu-elf-header-e-flags-table-v3 */ #define EF_AMDGPU_FEATURE_XNACK_V3 0x100 #define EF_AMDGPU_FEATURE_SRAMECC_V3 0x200 -/* Code object v4 (and later) machine flags. */ +/* Code object v4 (and later) machine flags. + + https://llvm.org/docs/AMDGPUUsage.html#amdgpu-elf-header-e-flags-table-v4-v5 */ #define EF_AMDGPU_FEATURE_XNACK_V4 0x300 #define EF_AMDGPU_FEATURE_XNACK_UNSUPPORTED_V4 0x000 @@ -108,16 +118,22 @@ #define EF_AMDGPU_FEATURE_SRAMECC_OFF_V4 0x800 #define EF_AMDGPU_FEATURE_SRAMECC_ON_V4 0xc00 -/* Code object v6 machine flags. */ +/* Code object v6 machine flags. + + https://llvm.org/docs/AMDGPUUsage.html#amdgpu-elf-header-e-flags-table-v6-onwards */ #define EF_AMDGPU_GENERIC_VERSION_V 0xff000000 #define EF_AMDGPU_GENERIC_VERSION_V_SHIFT 24 -/* Notes. */ +/* Notes. + + https://llvm.org/docs/AMDGPUUsage.html#code-object-v3-and-above-note-records */ #define NT_AMDGPU_METADATA 32 -/* Relocations. */ +/* Relocations. + + https://llvm.org/docs/AMDGPUUsage.html#amdgpu-elf-relocation-records-table */ START_RELOC_NUMBERS (elf_amdgpu_reloc_type) RELOC_NUMBER (R_AMDGPU_NONE, 0)