From patchwork Tue Sep 16 00:16:00 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Hanson X-Patchwork-Id: 120320 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 47D5F3858CD1 for ; Tue, 16 Sep 2025 00:20:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 47D5F3858CD1 X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-106111.protonmail.ch (mail-106111.protonmail.ch [79.135.106.111]) by sourceware.org (Postfix) with ESMTPS id 873E23858D1E for ; Tue, 16 Sep 2025 00:16:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 873E23858D1E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=andrewhanson.dev Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrewhanson.dev ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 873E23858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=79.135.106.111 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757981798; cv=none; b=fanG/NpDKLGEgg3YnDSjhuCdYyr2co1Ju+Z+u955hDrTv5H1pOZGZUiTrNhft/3XQSZfI6mxHuCdPusr71JtSfnF9/zlPAhFxnuPK5ou4hzVEYOsi4yAmimer+CTQBKMjTw8F5e0eD1WFS3zj5h03R5kf5z+BR6bOU5Ly2Q2hUE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757981798; c=relaxed/simple; bh=5fpe5GOV+TksTyJ/HZX41gBK9CIIvRQWt2Y/QTUH5EE=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=s+hgNOsI8hxQ9Ysl7WN0QrgnWqBRVAoEDg0TVFLAJFQ0vounBNLnARL3ndMmH34XITQ/XiQ81BnUtyGOKlYACZ4VYRm0tS7seXazbJV/ygzpVCx2pdO+LTTnt4kGCNI0ip+obwveStfUw4w3DHqIp1nY+f0eS5DyX0mZcbkmdp4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 873E23858D1E X-Pm-Submission-Id: 4cQjB42g4Gz1DDXl From: Andrew Hanson To: binutils@sourceware.org Cc: jbeulich@suse.com, Andrew Hanson Subject: [PATCH v2 1/3] include/binary-io.h: guard O_BINARY usage with defined check Date: Mon, 15 Sep 2025 20:16:00 -0400 Message-ID: <20250916001618.412638-1-andrew@andrewhanson.dev> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 X-Spam-Status: No, score=-13.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_PASS, SPF_PASS, TIME_LIMIT_EXCEEDED autolearn=unavailable version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org include/ * binary-io.h: Fix -Wundef compiler warning when O_BINARY is not defined. Wrap the check to ensure portability across platforms. Signed-off-by: Andrew Hanson --- include/binary-io.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/binary-io.h b/include/binary-io.h index 2f4be43a7c1..beeb0f76c25 100644 --- a/include/binary-io.h +++ b/include/binary-io.h @@ -35,7 +35,7 @@ # undef O_BINARY # undef O_TEXT #endif -#if O_BINARY +#if defined(O_BINARY) && O_BINARY # if defined __EMX__ || defined __DJGPP__ || defined __CYGWIN__ # include /* declares setmode() */ # else