diff mbox series

[3/4] testsuite: elf: avoid clashing mbind test names

Message ID 20250915154151.2595921-4-rearnsha@arm.com
State New
Headers
Series Cleanup duplicate test names |

Commit Message

Richard Earnshaw Sept. 15, 2025, 3:41 p.m. UTC 
  It's not entirely clear to me why the mbind tests section12b.d and
section16b.d both use 16 in their test names, but it is clearly
undesirable that both have identical names.  Disambiguate them by
adding '(unique)' to section16b.d, since that is the distinguishing
feature of the two tests.
---
 gas/testsuite/gas/elf/section16b.d | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jan Beulich Sept. 16, 2025, 2:01 a.m. UTC | #1 
On 15.09.2025 17:41, Richard Earnshaw wrote:
> It's not entirely clear to me why the mbind tests section12b.d and
> section16b.d both use 16 in their test names, but it is clearly
> undesirable that both have identical names.  Disambiguate them by
> adding '(unique)' to section16b.d, since that is the distinguishing
> feature of the two tests.

I think the 16 wants changing to 12 instead.

Jan

> ---
>  gas/testsuite/gas/elf/section16b.d | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gas/testsuite/gas/elf/section16b.d b/gas/testsuite/gas/elf/section16b.d
> index 6e085c3cab4..1c2e5bdcfb2 100644
> --- a/gas/testsuite/gas/elf/section16b.d
> +++ b/gas/testsuite/gas/elf/section16b.d
> @@ -1,7 +1,7 @@
>  #source: section16.s
>  #as: --no-pad-sections
>  #objdump: -s
> -#name: mbind section contents 16
> +#name: mbind section contents 16 (unique)
>  # RX annoyingly reorders the sections so that they do not match the sequence
>  # expected below.
>  #xfail: rx-*-*
Richard Earnshaw (foss) Sept. 16, 2025, 9:21 a.m. UTC | #2 
On 16/09/2025 03:01, Jan Beulich wrote:
> On 15.09.2025 17:41, Richard Earnshaw wrote:
>> It's not entirely clear to me why the mbind tests section12b.d and
>> section16b.d both use 16 in their test names, but it is clearly
>> undesirable that both have identical names.  Disambiguate them by
>> adding '(unique)' to section16b.d, since that is the distinguishing
>> feature of the two tests.
> 
> I think the 16 wants changing to 12 instead.

Ah, yes.  I see that section12a.d has 12 in its name.  I was worried initially that 
this might be something to do with the test contents rather than just the file name.

Will fix section12b.d instead.

R.

> 
> Jan
> 
>> ---
>>  gas/testsuite/gas/elf/section16b.d | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/gas/testsuite/gas/elf/section16b.d b/gas/testsuite/gas/elf/section16b.d
>> index 6e085c3cab4..1c2e5bdcfb2 100644
>> --- a/gas/testsuite/gas/elf/section16b.d
>> +++ b/gas/testsuite/gas/elf/section16b.d
>> @@ -1,7 +1,7 @@
>>  #source: section16.s
>>  #as: --no-pad-sections
>>  #objdump: -s
>> -#name: mbind section contents 16
>> +#name: mbind section contents 16 (unique)
>>  # RX annoyingly reorders the sections so that they do not match the sequence
>>  # expected below.
>>  #xfail: rx-*-*
>
diff mbox series

Patch

diff --git a/gas/testsuite/gas/elf/section16b.d b/gas/testsuite/gas/elf/section16b.d
index 6e085c3cab4..1c2e5bdcfb2 100644
--- a/gas/testsuite/gas/elf/section16b.d
+++ b/gas/testsuite/gas/elf/section16b.d
@@ -1,7 +1,7 @@ 
 #source: section16.s
 #as: --no-pad-sections
 #objdump: -s
-#name: mbind section contents 16
+#name: mbind section contents 16 (unique)
 # RX annoyingly reorders the sections so that they do not match the sequence
 # expected below.
 #xfail: rx-*-*