[v1] aarch64 tests: escape dot in regex pattern to really match a dot

Message ID 20250409105654.407399-1-matthieu.longo@arm.com
State New
Headers
Series [v1] aarch64 tests: escape dot in regex pattern to really match a dot |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_binutils_build--master-arm success Build passed
linaro-tcwg-bot/tcwg_binutils_build--master-aarch64 success Build passed
linaro-tcwg-bot/tcwg_binutils_check--master-arm fail Patch failed to apply
linaro-tcwg-bot/tcwg_binutils_check--master-aarch64 fail Patch failed to apply

Commit Message

Matthieu Longo April 9, 2025, 10:56 a.m. UTC
  This patch fixes a mistake in the matching pattern of some AArch64 tests.
It escapes a dot in regex patterns to really match a dot.

Tested on aarch64-none-linux-gnu, and no regression found.

Regards,
Matthieu.

---
 gas/testsuite/gas/aarch64/pac_ab_key.d                 | 2 +-
 gas/testsuite/gas/aarch64/pac_compat_cfi_window_save.d | 2 +-
 gas/testsuite/gas/aarch64/pac_negate_ra_state.d        | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
  

Comments

Richard Earnshaw April 9, 2025, 3:56 p.m. UTC | #1
On 09/04/2025 11:56, Matthieu Longo wrote:
> This patch fixes a mistake in the matching pattern of some AArch64 tests.
> It escapes a dot in regex patterns to really match a dot.
> 
> Tested on aarch64-none-linux-gnu, and no regression found.
> 

This was benign, since the the regex '.' would also match a literal '.'.

But since you've written the patch and this is more correct, OK.

R.

> Regards,
> Matthieu.
> 
> ---
>  gas/testsuite/gas/aarch64/pac_ab_key.d                 | 2 +-
>  gas/testsuite/gas/aarch64/pac_compat_cfi_window_save.d | 2 +-
>  gas/testsuite/gas/aarch64/pac_negate_ra_state.d        | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/gas/testsuite/gas/aarch64/pac_ab_key.d b/gas/testsuite/gas/aarch64/pac_ab_key.d
> index 4012d14f275..04d5fa41822 100644
> --- a/gas/testsuite/gas/aarch64/pac_ab_key.d
> +++ b/gas/testsuite/gas/aarch64/pac_ab_key.d
> @@ -7,7 +7,7 @@
>  
>  .+:     file .+
>  
> -Contents of the .eh_frame section:
> +Contents of the \.eh_frame section:
>  
>  0+ 0+10 0+ CIE
>    Version:               1
> diff --git a/gas/testsuite/gas/aarch64/pac_compat_cfi_window_save.d b/gas/testsuite/gas/aarch64/pac_compat_cfi_window_save.d
> index 8e59086c1b4..6ef77aeaa6d 100644
> --- a/gas/testsuite/gas/aarch64/pac_compat_cfi_window_save.d
> +++ b/gas/testsuite/gas/aarch64/pac_compat_cfi_window_save.d
> @@ -22,7 +22,7 @@
>  
>  .+:     file .+
>  
> -Contents of the .eh_frame section:
> +Contents of the \.eh_frame section:
>  
>  0+ 0+10 0+ CIE
>    Version:               1
> diff --git a/gas/testsuite/gas/aarch64/pac_negate_ra_state.d b/gas/testsuite/gas/aarch64/pac_negate_ra_state.d
> index f49cebcbfde..fa29c7f3b90 100644
> --- a/gas/testsuite/gas/aarch64/pac_negate_ra_state.d
> +++ b/gas/testsuite/gas/aarch64/pac_negate_ra_state.d
> @@ -4,7 +4,7 @@
>  
>  .+:     file .+
>  
> -Contents of the .eh_frame section:
> +Contents of the \.eh_frame section:
>  
>  0+ 0+10 0+ CIE
>    Version:               1
  

Patch

diff --git a/gas/testsuite/gas/aarch64/pac_ab_key.d b/gas/testsuite/gas/aarch64/pac_ab_key.d
index 4012d14f275..04d5fa41822 100644
--- a/gas/testsuite/gas/aarch64/pac_ab_key.d
+++ b/gas/testsuite/gas/aarch64/pac_ab_key.d
@@ -7,7 +7,7 @@ 
 
 .+:     file .+
 
-Contents of the .eh_frame section:
+Contents of the \.eh_frame section:
 
 0+ 0+10 0+ CIE
   Version:               1
diff --git a/gas/testsuite/gas/aarch64/pac_compat_cfi_window_save.d b/gas/testsuite/gas/aarch64/pac_compat_cfi_window_save.d
index 8e59086c1b4..6ef77aeaa6d 100644
--- a/gas/testsuite/gas/aarch64/pac_compat_cfi_window_save.d
+++ b/gas/testsuite/gas/aarch64/pac_compat_cfi_window_save.d
@@ -22,7 +22,7 @@ 
 
 .+:     file .+
 
-Contents of the .eh_frame section:
+Contents of the \.eh_frame section:
 
 0+ 0+10 0+ CIE
   Version:               1
diff --git a/gas/testsuite/gas/aarch64/pac_negate_ra_state.d b/gas/testsuite/gas/aarch64/pac_negate_ra_state.d
index f49cebcbfde..fa29c7f3b90 100644
--- a/gas/testsuite/gas/aarch64/pac_negate_ra_state.d
+++ b/gas/testsuite/gas/aarch64/pac_negate_ra_state.d
@@ -4,7 +4,7 @@ 
 
 .+:     file .+
 
-Contents of the .eh_frame section:
+Contents of the \.eh_frame section:
 
 0+ 0+10 0+ CIE
   Version:               1