diff mbox series

ld/testsuite: group archives for fatpr20103

Message ID 20250404065432.148010-1-chigot@adacore.com
State New
Headers
Series ld/testsuite: group archives for fatpr20103 |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_binutils_build--master-arm success Build passed
linaro-tcwg-bot/tcwg_binutils_build--master-aarch64 success Build passed
linaro-tcwg-bot/tcwg_binutils_check--master-aarch64 success Test passed
linaro-tcwg-bot/tcwg_binutils_check--master-arm success Test passed

Commit Message

Clément Chigot April 4, 2025, 6:54 a.m. UTC 
  In order for the dead symbol to be always found, archives must be
gathered within a group.
---
 ld/testsuite/ld-plugin/lto.exp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Clément Chigot April 23, 2025, 9:08 a.m. UTC | #1 
On Fri, Apr 4, 2025 at 8:56 AM Clément Chigot <chigot@adacore.com> wrote:
>
> On Fri, Apr 4, 2025 at 8:54 AM Clément Chigot <chigot@adacore.com> wrote:
> >
> > In order for the dead symbol to be always found, archives must be
> > gathered within a group.
>
> FYI, this regression showed up when testing arm-elf or aarch64-elf
> with gcc-14. I'm not sure this is the right solution thus I'll be glad
> to amend if needed.

Gentle ping

> > ---
> >  ld/testsuite/ld-plugin/lto.exp | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/ld/testsuite/ld-plugin/lto.exp b/ld/testsuite/ld-plugin/lto.exp
> > index 556bbe9beea..8d7bf5805cc 100644
> > --- a/ld/testsuite/ld-plugin/lto.exp
> > +++ b/ld/testsuite/ld-plugin/lto.exp
> > @@ -1305,8 +1305,8 @@ if { [check_lto_fat_available] } {
> >         ] \
> >      ]
> >      pr20103 "-O2 -flto" "tmpdir/thinpr20103a.a tmpdir/thinpr20103b.a tmpdir/thinpr20103c.a"
> > -    pr20103 "-O2 -flto" "tmpdir/fatpr20103a.a tmpdir/fatpr20103b.a tmpdir/fatpr20103c.a"
> > -    pr20103 "-O2" "tmpdir/fatpr20103a.a tmpdir/fatpr20103b.a tmpdir/fatpr20103c.a"
> > +    pr20103 "-O2 -flto" "-Wl,--start-group tmpdir/fatpr20103a.a tmpdir/fatpr20103b.a tmpdir/fatpr20103c.a -Wl,--end-group"
> > +    pr20103 "-O2" "-Wl,--start-group tmpdir/fatpr20103a.a tmpdir/fatpr20103b.a tmpdir/fatpr20103c.a -Wl,--end-group"
> >
> >      if { [at_least_gcc_version 4 9] } {
> >         run_cc_link_tests [list \
> > --
> > 2.34.1
> >
diff mbox series

Patch

diff --git a/ld/testsuite/ld-plugin/lto.exp b/ld/testsuite/ld-plugin/lto.exp
index 556bbe9beea..8d7bf5805cc 100644
--- a/ld/testsuite/ld-plugin/lto.exp
+++ b/ld/testsuite/ld-plugin/lto.exp
@@ -1305,8 +1305,8 @@  if { [check_lto_fat_available] } {
 	] \
     ]
     pr20103 "-O2 -flto" "tmpdir/thinpr20103a.a tmpdir/thinpr20103b.a tmpdir/thinpr20103c.a"
-    pr20103 "-O2 -flto" "tmpdir/fatpr20103a.a tmpdir/fatpr20103b.a tmpdir/fatpr20103c.a"
-    pr20103 "-O2" "tmpdir/fatpr20103a.a tmpdir/fatpr20103b.a tmpdir/fatpr20103c.a"
+    pr20103 "-O2 -flto" "-Wl,--start-group tmpdir/fatpr20103a.a tmpdir/fatpr20103b.a tmpdir/fatpr20103c.a -Wl,--end-group"
+    pr20103 "-O2" "-Wl,--start-group tmpdir/fatpr20103a.a tmpdir/fatpr20103b.a tmpdir/fatpr20103c.a -Wl,--end-group"
 
     if { [at_least_gcc_version 4 9] } {
 	run_cc_link_tests [list \