[V2,1/2] gas: sframe: adjust warning text for DW_CFA_val_offset case

Message ID 20250204231024.3168487-2-indu.bhagat@oracle.com
State New
Headers
Series sframe: partially process some .cfi_escape |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_binutils_build--master-arm success Build passed
linaro-tcwg-bot/tcwg_binutils_build--master-aarch64 success Build passed
linaro-tcwg-bot/tcwg_binutils_check--master-aarch64 success Test passed
linaro-tcwg-bot/tcwg_binutils_check--master-arm success Test passed

Commit Message

Indu Bhagat Feb. 4, 2025, 11:10 p.m. UTC
  [New in V2]

Soon we will invoke the same API for handling DW_CFA_val_offset in a
.cfi_escape directive.  The current substring ".cfi_val_offset" can be
confusing for the user to see.  Change it.

gas/
	* gen-sframe.c (sframe_xlate_do_val_offset): Adjust the warning
	message.
---
 gas/gen-sframe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Jan Beulich Feb. 7, 2025, 10:24 a.m. UTC | #1
On 05.02.2025 00:10, Indu Bhagat wrote:
> [New in V2]
> 
> Soon we will invoke the same API for handling DW_CFA_val_offset in a
> .cfi_escape directive.  The current substring ".cfi_val_offset" can be
> confusing for the user to see.  Change it.
> 
> gas/
> 	* gen-sframe.c (sframe_xlate_do_val_offset): Adjust the warning
> 	message.

OK.

Jan
  

Patch

diff --git a/gas/gen-sframe.c b/gas/gen-sframe.c
index 13478efab6b..a592e0f718d 100644
--- a/gas/gen-sframe.c
+++ b/gas/gen-sframe.c
@@ -1134,7 +1134,7 @@  sframe_xlate_do_val_offset (struct sframe_xlate_ctx *xlate_ctx ATTRIBUTE_UNUSED,
       /* Ignore SP reg, if offset matches assumed default rule.  */
       || (cfi_insn->u.ri.reg == SFRAME_CFA_SP_REG && cfi_insn->u.ri.offset != 0))
     {
-      as_warn (_("skipping SFrame FDE; %s register %u in .cfi_val_offset"),
+      as_warn (_("skipping SFrame FDE; DW_CFA_val_offset with %s register %u"),
 	       sframe_register_name (cfi_insn->u.ri.reg), cfi_insn->u.ri.reg);
       return SFRAME_XLATE_ERR_NOTREPRESENTED; /* Not represented.  */
     }