From patchwork Wed Jan 15 11:03:46 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 104823 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 31D04385DDEE for ; Wed, 15 Jan 2025 11:06:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 31D04385DDEE Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=O4PmFKBu X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by sourceware.org (Postfix) with ESMTPS id 3A8F9385DDCD for ; Wed, 15 Jan 2025 11:03:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3A8F9385DDCD Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3A8F9385DDCD Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::636 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736939037; cv=none; b=WJ/zFrwKWmfnPqWr+Rn1f1gRZGn4IjD9RhdQSWQQRwaPsiIkeWLA3w+fr4ztXgFbIzRwBKEwPkBBDMa1oUCBGRTF4ip6Cu7rle5tU2l/e5N1PqqRJvq/GsJYsInIHr8qLELr4U0z8KR4ZKV8A1kA64il85Sal5nWmS4/MU1POzQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736939037; c=relaxed/simple; bh=DbuspnL4Z9f+u+emPJivx2bLfiJwvR0VF7Rtpbi6xgE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Ad2Q76kPfriXcv9DNtqKIDgKNwtREt6PwFEHh0u7ryQUe+mF79PoGziPComOpSJdRNya5j+2lgo3q8lPN8omgTcsRx8483azVEvJtUM348Lr61AWqnGShxoijQJX16Csh+x0nYC+0/xNfanmr2+TqAyHo7RN2tvNWDY5CcQJdUw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3A8F9385DDCD Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-216401de828so108710475ad.3 for ; Wed, 15 Jan 2025 03:03:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736939036; x=1737543836; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DcZrg7W/KFA0hTTGsd0JQOx5jjlKWGOSsWu50sJUbQw=; b=O4PmFKBucONcgcMFdcIhDxrWmVrsxGycuEYYQY1JP9+GpgVZ62nJJpbH4LD684Vghc RS8Zs18myi3boCR388cmjj45HgsOjwYytRejopJEgc8SzGRuV+pqwcxejmYvf4RfAvut Gs9grmUWUJkKuAwaNfg0qHTKO9k3+K7PEf2igteSN/KKVqiN0BLsvdUuZZki66PHDQAL vLzersGIZql8mIu7bJ8vm6pOTXOocHd9C6XlZORJvTyyyam0v4eEuSB1rRQiqGzYeL38 6zJAq2DEzh5GKzbk12hHCx0tpbC1B8vU6UoPlJKZ5u8XUwmltukyg6dqS1bu2dfZ5tfL tAdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736939036; x=1737543836; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DcZrg7W/KFA0hTTGsd0JQOx5jjlKWGOSsWu50sJUbQw=; b=m+sOQglT6/TTdVSrukwTxn6jlHN9HplsHwIBp+MrarX5087G2/AVyxsO6zzBdRfaZU nwXdf98wGclR/PVzzZjQr8K7wHq+s+nun7QT/ZVzpMuQzhkdvAYLHQdiSCNCsDxAQYYn Kd8VUiebP6fUTxKavTT9OmajiLGWSOScrB5RTucTaPWbuSE23j5zT1iy8smq7d7SWPeT eIvo6AnOLPHWYb0EoNGrS6T7LqrEHnbTlaw0J0QqgNwnnLuM4VYfvFurSKJC3PNIzcHC uzu4aGZAC/ubNOXfGnHUC6rZoQZTYh9CY3LeRcfcNcUh7El3KU3a/vIgpqAxSs8GGxV1 aSyg== X-Gm-Message-State: AOJu0YxY7QZeEl65lIwV42rON00rp7izKp4V+otA+QvRtq4N2gzqdMVW e1D2nxfI/3ni71FazDH+w+fs3UmjW2ePBO0lTfKurNnkFzgX7wCm X-Gm-Gg: ASbGncvfkR9cAbKFkYtZ22RJKLEAey7qBYcAKL8ZI+7/SbLEmRG87U6gzikRTIqK2Kn IDcZP3kf8Ge7nFMzwAXzY5wTcbJI2GctommIB6bS/sDf2G/gHbLmyjybAKPCXOLW8rYbDxJkcFx FqMtsP3/rNcMG2XQN5ncjJg2/oeZ0g740xEFoj2J/GMsbRNwfOMoyBSWYwY+m6rVPQ80/fRipCf wOwFa9qvUD6I8U6cB+Tbrq4F9CCqhhdRxggOorTFFlcYJoLi/Ctq3QO5z9zpkE/rPHyEQ== X-Google-Smtp-Source: AGHT+IEoVcmLGZAZpEUp7b3UMGwweDXEIkZC8PxIPr0EN1WkiAH2Y1GiQgsfwi728U7oRVG4KunCmA== X-Received: by 2002:a17:902:e545:b0:215:4a31:47d8 with SMTP id d9443c01a7336-21a83f36d79mr419991035ad.9.1736939036092; Wed, 15 Jan 2025 03:03:56 -0800 (PST) Received: from gnu-tgl-3.localdomain ([220.196.194.88]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21a9f21c49fsm79399245ad.118.2025.01.15.03.03.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jan 2025 03:03:55 -0800 (PST) Received: from gnu-tgl-3.. (localhost [IPv6:::1]) by gnu-tgl-3.localdomain (Postfix) with ESMTP id D592DC0242; Wed, 15 Jan 2025 19:03:47 +0800 (CST) From: "H.J. Lu" To: binutils@sourceware.org Cc: amodra@gmail.com, nickc@redhat.com Subject: [PATCH v2 1/2] ld: Correct ldelf_place_orphan Date: Wed, 15 Jan 2025 19:03:46 +0800 Message-ID: <20250115110347.1718501-2-hjl.tools@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250115110347.1718501-1-hjl.tools@gmail.com> References: <20250115110347.1718501-1-hjl.tools@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-3018.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org Remove the extra for loop and if statement in ldelf_place_orphan. * ldelf.c (ldelf_place_orphan): Remove the extra for loop and if statement. Signed-off-by: H.J. Lu --- ld/ldelf.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/ld/ldelf.c b/ld/ldelf.c index a66d1d21394..dfe8032f255 100644 --- a/ld/ldelf.c +++ b/ld/ldelf.c @@ -2275,19 +2275,17 @@ ldelf_place_orphan (asection *s, const char *secname, int constraint) { struct orphan_save *ho, *horig; - for (ho = hold; ho < hold + sizeof (hold) / sizeof (hold[0]); ++ho) for (ho = hold, horig = orig_hold; ho < hold + ARRAY_SIZE (hold); ++ho, ++horig) { *ho = *horig; if (ho->name != NULL) - if (ho->name != NULL) - { - ho->os = lang_output_section_find (ho->name); - if (ho->os != NULL && ho->os->flags == 0) - ho->os->flags = ho->flags; - } + { + ho->os = lang_output_section_find (ho->name); + if (ho->os != NULL && ho->os->flags == 0) + ho->os->flags = ho->flags; + } } orphan_init_done = true; }