From patchwork Tue Dec 3 06:26:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Jiang, Haochen" X-Patchwork-Id: 102279 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9776A3858C51 for ; Tue, 3 Dec 2024 06:28:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9776A3858C51 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=INOEyeSZ X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by sourceware.org (Postfix) with ESMTPS id 04CE83858CDA for ; Tue, 3 Dec 2024 06:26:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 04CE83858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 04CE83858CDA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=192.198.163.7 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1733207185; cv=none; b=hN1r0EWqjSUUxVypTmxakFxM7G0esNgHM0xu/2CRJyLieBIRZS/qy497NodA428ec8KMe/fMSIczDsvDHX0RwnJrQTYcyZ2A8hGXlJ1sRWApmkQMzKshOiaBh2ja/O6FbZnwWa1YYgGG9BO+zvEgSptqTzDeno8wscdiTiLV0mQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1733207185; c=relaxed/simple; bh=wWPfd32f88XLm0UQiGJ3Je190BVpp6M2hyUItCa5dpI=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=jtdkC7jvVrpSMd5IbybHkE4mw3mrVF3m82jpjjcw3Hi9l4etQ6LXdT2oWagzH/SmMNk/LGU/a4unDVS88dSEaLHxRWusXOAbOWi29sC32W1YYGLzsjXRLElT3PnWyZ/Qa0X+Oi0cgegTbHuscY0rFCSMDkEiAXPvMIOjJz5tZgc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 04CE83858CDA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1733207185; x=1764743185; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=wWPfd32f88XLm0UQiGJ3Je190BVpp6M2hyUItCa5dpI=; b=INOEyeSZj+jSpG/udnjs/zQ/m7wGFKzQgcQwmWNpZLnVjVREF2QuRgnV ckdYY/dBNzKZnL593/Yo0z8xihh668DoznsQHFajvSDxLyYKyv7HGm+2B pjq9HWBu/Mfvj0femRC81z1OcSVXojuFtfE/h2KdGEtSYzcK7Q3nYWATJ tZyH7KhCeqskVJCPbyy7cf7sfkBbvhdxIFJMCU3txJPCfFV5AAwheUQWr /KpvQ1QjDxZ41wyG9/SjviPJr/KTzyI5RtR/20/hBHW5xV527JU9Xygx6 L4IIDeRdH5KHKvrtvz8QnWssZnLYpEzMfnqdSHM25kEmqZWB4FCReQvIL Q==; X-CSE-ConnectionGUID: ouja0gIDRyq5vLN59GaAIQ== X-CSE-MsgGUID: BmWy8kM7T7S4r2M1H5epNA== X-IronPort-AV: E=McAfee;i="6700,10204,11274"; a="58810281" X-IronPort-AV: E=Sophos;i="6.12,204,1728975600"; d="scan'208";a="58810281" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Dec 2024 22:26:24 -0800 X-CSE-ConnectionGUID: RmmlEiGPQlqpgIPN0isL8w== X-CSE-MsgGUID: ezpuPmrmS66ITZgvEhG9tA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,204,1728975600"; d="scan'208";a="93225078" Received: from shliclel4217.sh.intel.com ([10.239.240.127]) by orviesa010.jf.intel.com with ESMTP; 02 Dec 2024 22:26:22 -0800 From: Haochen Jiang To: binutils@sourceware.org Cc: jbeulich@suse.com, hjl.tools@gmail.com Subject: [PATCH] x86: Add %ME for instructions do not need {evex} prefix with memory Date: Tue, 3 Dec 2024 14:26:21 +0800 Message-Id: <20241203062621.209543-1-haochen.jiang@intel.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_NONE, TXREP, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org From: "H.J. Lu" Hi all, As mentioned in https://sourceware.org/bugzilla/show_bug.cgi?id=32403, there are several insts with superfluous {evex} prefix with memory operand. This patch will remove those prefix while still keeping the prefix for register operand. Tested on x86_64-pc-linux-gnu. Ok for trunk? Thx, Haochen --- For several instructions including vps{l,r}l{d,q,w,dq} and vpsra{d,q,w}, their VEX part do not have the following version: vpsrlw $0x1f,(%r15,%rcx,4),%xmm0 Thus, {evex} prefix should not be inserted when their second operand is memory, while we still need them for register as second operand. Add a new macro %ME to solve this problem. gas/ChangeLog: PR binutils/32403 * testsuite/gas/i386/x86-64.exp: Run new test. * testsuite/gas/i386/x86-64-evex-me.d: New test. * testsuite/gas/i386/x86-64-evex-me.s: Ditto. opcodes/ChangeLog: PR binutils/32403 * i386-dis-evex-reg.h: Use %ME instead of %XE for vps{l,r}l{w,dq} and vpsra{d,q,w}. * i386-dis-evex-w.h: Use %ME instead of %XE for vps{l,r}l{d,q}. * i386-dis.c (struct dis386): Add comment for %ME. (putop): Handle %ME. Co-authored-by: Haochen Jiang Signed-off-by: H.J. Lu --- gas/testsuite/gas/i386/x86-64-evex-me.d | 21 +++++++++++++++++++++ gas/testsuite/gas/i386/x86-64-evex-me.s | 15 +++++++++++++++ gas/testsuite/gas/i386/x86-64.exp | 1 + opcodes/i386-dis-evex-reg.h | 12 ++++++------ opcodes/i386-dis-evex-w.h | 8 ++++---- opcodes/i386-dis.c | 6 ++++++ 6 files changed, 53 insertions(+), 10 deletions(-) create mode 100644 gas/testsuite/gas/i386/x86-64-evex-me.d create mode 100644 gas/testsuite/gas/i386/x86-64-evex-me.s diff --git a/gas/testsuite/gas/i386/x86-64-evex-me.d b/gas/testsuite/gas/i386/x86-64-evex-me.d new file mode 100644 index 00000000000..5b4bfd23665 --- /dev/null +++ b/gas/testsuite/gas/i386/x86-64-evex-me.d @@ -0,0 +1,21 @@ +#objdump: -dw +#name: x86-64 AVX512 instructions do not need {evex} prefix with memory + +.*: +file format .* + + +Disassembly of section .text: + +0+ <_start>: +\s*[a-f0-9]+:\s*62 d1 7d 08 71 14 8f 1f\s+vpsrlw\s+\$0x1f,\(%r15,%rcx,4\),%xmm0 +\s*[a-f0-9]+:\s*62 d1 7d 08 71 24 8f 1f\s+vpsraw\s+\$0x1f,\(%r15,%rcx,4\),%xmm0 +\s*[a-f0-9]+:\s*62 d1 7d 08 71 34 8f 1f\s+vpsllw\s+\$0x1f,\(%r15,%rcx,4\),%xmm0 +\s*[a-f0-9]+:\s*62 d1 7d 08 72 24 8f 1f\s+vpsrad\s+\$0x1f,\(%r15,%rcx,4\),%xmm0 +\s*[a-f0-9]+:\s*62 d1 fd 08 72 24 8f 1f\s+vpsraq\s+\$0x1f,\(%r15,%rcx,4\),%xmm0 +\s*[a-f0-9]+:\s*62 d1 7d 08 73 1c 8f 1f\s+vpsrldq\s+\$0x1f,\(%r15,%rcx,4\),%xmm0 +\s*[a-f0-9]+:\s*62 d1 7d 08 73 3c 8f 1f\s+vpslldq\s+\$0x1f,\(%r15,%rcx,4\),%xmm0 +\s*[a-f0-9]+:\s*62 d1 7d 08 72 14 8f 1f\s+vpsrld\s+\$0x1f,\(%r15,%rcx,4\),%xmm0 +\s*[a-f0-9]+:\s*62 d1 7d 08 72 34 8f 1f\s+vpslld\s+\$0x1f,\(%r15,%rcx,4\),%xmm0 +\s*[a-f0-9]+:\s*62 d1 fd 08 73 14 8f 1f\s+vpsrlq\s+\$0x1f,\(%r15,%rcx,4\),%xmm0 +\s*[a-f0-9]+:\s*62 d1 fd 08 73 34 8f 1f\s+vpsllq\s+\$0x1f,\(%r15,%rcx,4\),%xmm0 +#pass diff --git a/gas/testsuite/gas/i386/x86-64-evex-me.s b/gas/testsuite/gas/i386/x86-64-evex-me.s new file mode 100644 index 00000000000..ad7d3f226d7 --- /dev/null +++ b/gas/testsuite/gas/i386/x86-64-evex-me.s @@ -0,0 +1,15 @@ +# Check instructions do not need {evex} prefix under memory operand + + .text +_start: + vpsrlw $0x1f,(%r15,%rcx,4),%xmm0 + vpsraw $0x1f,(%r15,%rcx,4),%xmm0 + vpsllw $0x1f,(%r15,%rcx,4),%xmm0 + vpsrad $0x1f,(%r15,%rcx,4),%xmm0 + vpsraq $0x1f,(%r15,%rcx,4),%xmm0 + vpsrldq $0x1f,(%r15,%rcx,4),%xmm0 + vpslldq $0x1f,(%r15,%rcx,4),%xmm0 + vpsrld $0x1f,(%r15,%rcx,4),%xmm0 + vpslld $0x1f,(%r15,%rcx,4),%xmm0 + vpsrlq $0x1f,(%r15,%rcx,4),%xmm0 + vpsllq $0x1f,(%r15,%rcx,4),%xmm0 diff --git a/gas/testsuite/gas/i386/x86-64.exp b/gas/testsuite/gas/i386/x86-64.exp index fee227d2a4d..379d1aee12f 100644 --- a/gas/testsuite/gas/i386/x86-64.exp +++ b/gas/testsuite/gas/i386/x86-64.exp @@ -242,6 +242,7 @@ run_dump_test "x86-64-evex-lig-2" run_dump_test "x86-64-evex-wig1" run_dump_test "x86-64-evex-wig1-intel" run_dump_test "x86-64-evex-wig2" +run_dump_test "x86-64-evex-me" run_dump_test "evex-no-scale-64" run_dump_test "x86-64-sse2avx" run_dump_test "x86-64-unaligned-vector-move" diff --git a/opcodes/i386-dis-evex-reg.h b/opcodes/i386-dis-evex-reg.h index eda0e824aef..7c4401ffaad 100644 --- a/opcodes/i386-dis-evex-reg.h +++ b/opcodes/i386-dis-evex-reg.h @@ -2,11 +2,11 @@ { { Bad_Opcode }, { Bad_Opcode }, - { "%XEvpsrlw", { Vex, EXx, Ib }, PREFIX_DATA }, + { "%MEvpsrlw", { Vex, EXx, Ib }, PREFIX_DATA }, { Bad_Opcode }, - { "%XEvpsraw", { Vex, EXx, Ib }, PREFIX_DATA }, + { "%MEvpsraw", { Vex, EXx, Ib }, PREFIX_DATA }, { Bad_Opcode }, - { "%XEvpsllw", { Vex, EXx, Ib }, PREFIX_DATA }, + { "%MEvpsllw", { Vex, EXx, Ib }, PREFIX_DATA }, }, /* REG_EVEX_0F72 */ { @@ -14,7 +14,7 @@ { "vprol%DQ", { Vex, EXx, Ib }, PREFIX_DATA }, { VEX_W_TABLE (EVEX_W_0F72_R_2) }, { Bad_Opcode }, - { "%XEvpsra%DQ", { Vex, EXx, Ib }, PREFIX_DATA }, + { "%MEvpsra%DQ", { Vex, EXx, Ib }, PREFIX_DATA }, { Bad_Opcode }, { VEX_W_TABLE (EVEX_W_0F72_R_6) }, }, @@ -23,11 +23,11 @@ { Bad_Opcode }, { Bad_Opcode }, { VEX_W_TABLE (EVEX_W_0F73_R_2) }, - { "%XEvpsrldqY", { Vex, EXx, Ib }, PREFIX_DATA }, + { "%MEvpsrldqY", { Vex, EXx, Ib }, PREFIX_DATA }, { Bad_Opcode }, { Bad_Opcode }, { VEX_W_TABLE (EVEX_W_0F73_R_6) }, - { "%XEvpslldqY", { Vex, EXx, Ib }, PREFIX_DATA }, + { "%MEvpslldqY", { Vex, EXx, Ib }, PREFIX_DATA }, }, /* REG_EVEX_0F38C6_L_2 */ { diff --git a/opcodes/i386-dis-evex-w.h b/opcodes/i386-dis-evex-w.h index 27053b49b9c..f6c5d8389e3 100644 --- a/opcodes/i386-dis-evex-w.h +++ b/opcodes/i386-dis-evex-w.h @@ -50,21 +50,21 @@ }, /* EVEX_W_0F72_R_2 */ { - { "%XEvpsrld", { Vex, EXx, Ib }, PREFIX_DATA }, + { "%MEvpsrld", { Vex, EXx, Ib }, PREFIX_DATA }, }, /* EVEX_W_0F72_R_6 */ { - { "%XEvpslld", { Vex, EXx, Ib }, PREFIX_DATA }, + { "%MEvpslld", { Vex, EXx, Ib }, PREFIX_DATA }, }, /* EVEX_W_0F73_R_2 */ { { Bad_Opcode }, - { "%XEvpsrlq", { Vex, EXx, Ib }, PREFIX_DATA }, + { "%MEvpsrlq", { Vex, EXx, Ib }, PREFIX_DATA }, }, /* EVEX_W_0F73_R_6 */ { { Bad_Opcode }, - { "%XEvpsllq", { Vex, EXx, Ib }, PREFIX_DATA }, + { "%MEvpsllq", { Vex, EXx, Ib }, PREFIX_DATA }, }, /* EVEX_W_0F76 */ { diff --git a/opcodes/i386-dis.c b/opcodes/i386-dis.c index ea3a8e2f860..bc42c48630c 100644 --- a/opcodes/i386-dis.c +++ b/opcodes/i386-dis.c @@ -1819,6 +1819,8 @@ struct dis386 { "XV" => print "{vex} " pseudo prefix "XE" => print "{evex} " pseudo prefix if no EVEX-specific functionality is is used by an EVEX-encoded (AVX512VL) instruction. + "ME" => Similar to "XE", but only print "{evex} " when there is no + memory operand. "NF" => print "{nf} " pseudo prefix when EVEX.NF = 1 and print "{evex} " pseudo prefix when instructions without NF, EGPR and VVVV, "NE" => don't print "{evex} " pseudo prefix for some special instructions @@ -10594,6 +10596,10 @@ putop (instr_info *ins, const char *in_template, int sizeflag) { switch (last[0]) { + case 'M': + if (ins->modrm.mod != 3) + break; + /* Fall through. */ case 'X': if (!ins->vex.evex || ins->vex.b || ins->vex.ll >= 2 || (ins->rex2 & 7)