Message ID | 20241023104816.501176-5-matthieu.longo@arm.com |
---|---|
State | Accepted |
Headers |
Return-Path: <binutils-bounces~patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4B1B33858424 for <patchwork@sourceware.org>; Wed, 23 Oct 2024 10:50:23 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2062d.outbound.protection.outlook.com [IPv6:2a01:111:f403:2614::62d]) by sourceware.org (Postfix) with ESMTPS id 6F9543858401 for <binutils@sourceware.org>; Wed, 23 Oct 2024 10:49:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6F9543858401 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6F9543858401 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:2614::62d ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1729680576; cv=pass; b=ob/aTGeYhXJZcNmPxUTdDP12AoJRHlM/RxN5osaeFbmYy6I8LqV70gtFd43v5XmP5FHYPRiuk4yN+O27jLqurzwIYP47fw+ctP3ew7RbPiKrYNuagoG95PWy74/IH5u0nNFD6z2yWIE9t0YXjaDk85iMqsLZHOAAKxTzmczVc/Y= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1729680576; c=relaxed/simple; bh=W+sODps4UlPe2X944kY40DI21fiBJZPwsWtDMwzMGo0=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=U2oA2rOjhE3RNvG7+TulLUQpMUtxzfVDdXQLlXKZ4Ksjx7k7nIuPKNqskkdTHzrI9VGQvmiwdCt93SwuhR6w+Z67y5TBMBKExtlZZunJ8cq19JvLbjwZGCooLDK9UvkGNKODDSb91P5raEAXhCz/9nClZLuFmX+3vrN4XHKC614= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=YGoHM8VnTZSCMANcYXZU185IZw1Hr23IXJJKXmN+siBuJ1aPAfYIkPcyY+XHT1B/spTASPZJ1KXAQhHXM+668fex+qC2bZ1zOUn3ScU+TusEjac7z02/5RVJw+8Y86MQLrx3cWaMpncdO9WvKKYkY2PzCHKkXz5hGVyf365caHHGG2RnEip8btBXqtZiprOtNczGZiYr6MXgzA1sj+uShWyyklrEQoq9p93BPRnudrrdLVgD4sTWMOwNMYmC48d649GTcT96htZWahIXA+UJW7y5tVtYH+H1aKpn2xFUkqAFatBXEuJDL/QLZ9ie2UdkO/H4UHsKkHhLudBdxVYBnw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zhh/kRCKXlMYEZaBnVOKjMpKfbP0083PgQmjFcDDAr8=; b=isi+pn3H3sdO+2NE691p9JG9GKYBtdaQxPIrxOOEuTvVfDc3leQQLtqba2GNCCFp5E0jzUAbKpITAxXrmtFyIUVPIg1mdSHl85GdCdkQzQTeNK2gaMujR+3Z1DrL4B6y2f4RZDp0V2hxa6/bZLlUNxtwMoU6t1qUeSZzBtry1/KWkEtT3OdKBNh5hFEheamX45K/zFvVOCwiIJlb79mhg/rDwiQ233FheJ1Qq8Yor3OaCJVuvOXj7BItUrkBJzHN2ju4YDhWTnSZff7OsrvrBOoMlH2YHS6RSLuz8hJh4h5zR86kv/B8i8TvbYQ0P+f32Fe8wGCAdGECixj22lr/4Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zhh/kRCKXlMYEZaBnVOKjMpKfbP0083PgQmjFcDDAr8=; b=r5n4ZFuaPUHr4hBc+UHyGfcWyXqtdcaYZdhVCzS05gGJzAA88ou429z1EsC2Vc0mpZg0R4yR2C3PgnsD7abTkBFKTW9igTzR7OPX1WacVzLohXMhA/POFQuWqFdyX57Qw0oUtY6LX8e8d2Qs3H5P4/B3vtBpWymNq4myQo44D1w= Received: from AM6P192CA0108.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:8d::49) by GVXPR08MB7701.eurprd08.prod.outlook.com (2603:10a6:150:6d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.20; Wed, 23 Oct 2024 10:49:26 +0000 Received: from AM1PEPF000252E1.eurprd07.prod.outlook.com (2603:10a6:209:8d:cafe::39) by AM6P192CA0108.outlook.office365.com (2603:10a6:209:8d::49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.17 via Frontend Transport; Wed, 23 Oct 2024 10:49:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM1PEPF000252E1.mail.protection.outlook.com (10.167.16.59) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8093.14 via Frontend Transport; Wed, 23 Oct 2024 10:49:25 +0000 Received: ("Tessian outbound da7ba6582322:v473"); Wed, 23 Oct 2024 10:49:24 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 6351e4a7f57daea2 X-TessianGatewayMetadata: 0Tdy9Jx7DXi4pF9c0d8GuKdSta0YoSL+aWw9sg/CjkMRC/ZkTjlNgKPkkfDaRre/ON+7ECNAEH2B/zrSZIuLP9Cbl3iASUiwEFLZf9bwmr8VrqmVGWUtO+FuYtucXdRymGOoFDrx8WzrMH8+UoO0mZDBcoc1K/amfKFwBwF3H7s= X-CR-MTA-TID: 64aa7808 Received: from L624e19b44ec8.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E0375A63-3C96-4986-AB22-3910179282D8.1; Wed, 23 Oct 2024 10:49:17 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id L624e19b44ec8.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 23 Oct 2024 10:49:17 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HX+dWQyfk6WIJVDFlMAgohvZRqByQKptiAa1ePztbjgysbDWvrBE4MM2ZePJ19SPySUilaIMMQvfw/iFbJfkoE+PXODELQ3xmKsSZuJZAUC7jodoTe3UtYFhbDuOrnjWeosMBcfdrK0WgPH27tloFPLxC+KT6wJ/kEGeRIbLEz5CU0H+4Zy35AlMDESYTLCtaxLiMo3zqnQ9+yOBMPkGCPrVWNsMPqrwsiBY0P/uJKbr079wKxaXDdxb5g35UYmlY2ULvyc03ZOhuVhqkAj04pBqQnYeT5QKpfsMdZpXI1v+yLHlXzgMCVoxkgLNcvMlrc23ijMoIretfpGFrYLuQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zhh/kRCKXlMYEZaBnVOKjMpKfbP0083PgQmjFcDDAr8=; b=QpXpwe7eJLT/M+ViZDzS1WtF6GbJqkl4OQtfnzkJi3DosfoSGrdlCtXQwtbwFJsQuxono5ycq0URjlrbo00QHM1Om8N60Vkj6EJUv/K5dyNPcPV/3RzJOAZF0LRBAAgc4z+XgH/ZaCttcQSo/9TXoa7g9cJVma26vNam8ClsOsYc2TS6Q3YpLk+w1/Hhh56ycLYR4vPLm+ZBXykBEXi9CKy4A81i3LwQs2K1kDzu1RN/P/z3h4WyPJijhQ+lrnqV2FeXN4dW/sSy1ozPFrr5bEn6K1SqSKJd4MSSQcDX0ajFvGK7KwYpXFiCgD0yPX7d+R5ndx6A+b0ZBDcwZgxuWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zhh/kRCKXlMYEZaBnVOKjMpKfbP0083PgQmjFcDDAr8=; b=r5n4ZFuaPUHr4hBc+UHyGfcWyXqtdcaYZdhVCzS05gGJzAA88ou429z1EsC2Vc0mpZg0R4yR2C3PgnsD7abTkBFKTW9igTzR7OPX1WacVzLohXMhA/POFQuWqFdyX57Qw0oUtY6LX8e8d2Qs3H5P4/B3vtBpWymNq4myQo44D1w= Received: from AM0PR06CA0115.eurprd06.prod.outlook.com (2603:10a6:208:ab::20) by DU0PR08MB9156.eurprd08.prod.outlook.com (2603:10a6:10:417::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.18; Wed, 23 Oct 2024 10:49:12 +0000 Received: from AM3PEPF0000A795.eurprd04.prod.outlook.com (2603:10a6:208:ab:cafe::f2) by AM0PR06CA0115.outlook.office365.com (2603:10a6:208:ab::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.16 via Frontend Transport; Wed, 23 Oct 2024 10:49:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C Received: from nebula.arm.com (40.67.248.234) by AM3PEPF0000A795.mail.protection.outlook.com (10.167.16.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8093.14 via Frontend Transport; Wed, 23 Oct 2024 10:49:12 +0000 Received: from AZ-NEU-EXJ01.Arm.com (10.240.25.132) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 23 Oct 2024 10:49:03 +0000 Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EXJ01.Arm.com (10.240.25.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 23 Oct 2024 10:49:03 +0000 Received: from PW070M4K.arm.com (10.57.85.41) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Wed, 23 Oct 2024 10:49:02 +0000 From: Matthieu Longo <matthieu.longo@arm.com> To: <binutils@sourceware.org> CC: Richard Earnshaw <richard.earnshaw@arm.com>, Nick Clifton <nickc@redhat.com>, Matthieu Longo <matthieu.longo@arm.com> Subject: [PATCH v1 4/8] aarch64: improve debuggability on array of enum Date: Wed, 23 Oct 2024 11:48:12 +0100 Message-ID: <20241023104816.501176-5-matthieu.longo@arm.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241023104816.501176-1-matthieu.longo@arm.com> References: <20241023104816.501176-1-matthieu.longo@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AM3PEPF0000A795:EE_|DU0PR08MB9156:EE_|AM1PEPF000252E1:EE_|GVXPR08MB7701:EE_ X-MS-Office365-Filtering-Correlation-Id: 997e5387-ee27-40f3-d7f1-08dcf3505c6f X-LD-Processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; ARA:13230040|36860700013|1800799024|82310400026|376014; X-Microsoft-Antispam-Message-Info-Original: B0kf+0kkQaphkyR3swm5FxU7bjw1uF6sKcKRxjfs5Urqer1CHUZtsV9o3bDdH5O1IPmI447gcR0tCrE+6fTHJygFUfrMz686CYPN/8rC2JouMhH8fh2rCFXrKAy4lh0e2BY1da48+ru+E4jCth1CHd0g35j1oXZ48SThmFUkJA6D4HrTeSoJm69lUCgkRZGnxORzdngT0Ou/aZs0UbSS4oxG97ai23gRBMbVRHfMhDoaGV1qB3fOHx7f7ztLfoK6kvl6PzXzcsUaJG+u9XqQfZ4fVfpj83qrAaz6TlNzRgCzxZlnmII+47BuKK674PeW7pa7I0w4w516sIdJD2LuFg1DIA056HmPxS+UobzpTPkI7XOhmFVoChhbxPntw19ndTPNbcmgq5WXjbsq2jrB89qFGA2e0JPAYilijXNEECbegKP4BDTK8L/jY49qsYDGe8PPpL8aY2/cdA5M6FW0CJgarWt5ZwhybNtEAmYGIl+NnASmoGWv//YClU0+godpu/byJtPuICDSWvIud1UlxRUMhQ2/xqU46cWbHG4mXLcAdTmhCxaAHtXe77TRRe1CciZ7YQxM1BOnPKtqE8FxSY4VSn+tlq3lLgsWSevqaBDGecPTrhTweB8c5NGQlDiMoVLc58ka4eY7SZRo2qcJvz2sSB7UbII4pQ78k8JSYZxpYs6jzxtPYw3XwLTz49DUPcM5Z6no+hLJa/M9Tr3PeTu82TZUvaunn6wXw2nki8O0dn+lcu3fOJZ8w6pJOJhvrEhBBNLWoqr4iglNss8Op0t4Gb7ymdBOe7YeNEyh//KptbHxL2N2/DMxhfNJS1cEHote2pPYxcyFZ0nC9bZW8YQKmH3DMR2T7reZ7iRvHCZwVEww2Ub++johDTaNQRZnnO9alQwxWnl0Lp6s8oD8MgMniZYbBPkxP5KBhsPddHwkDeq+mtKoPxVGnjVJIwq9CMLpA7O9T4av0o18lFwylEZJ3JI4U5KbiDNi/hNIF0aDB9oXYwoTtapHcDFq2ny0E1x6n3STkENjhMGQuVTdmSkhfvBeHIm/YspWzmupgvYyqChJqwJ0iPCoRKPhezgGn+cTFGzvLp9VFccp2fkxsdAi+ANi1bnlYeBub4LP08FhR+rMpaN3XsCZaF/JqNL0Qysi8XiIkD6p2Qs4VOx72KEVxB2LjhAxEPLbRcqW81M7XcOtvSriUQdIc5vjfYgsotU66zKJk0SGhvaro3Fv8vxhqK1206naSsf9JBWzCyKWA+ml940b9A7B7XwB9ax/i3k4lZfs4Az3TEbN6Z6+IoO2oI2GLvoRBBdABJyaA3kDvb9OD3LLCSio1TeqpuQaJGT1okGtOv4/PY2/UXizEXqlWbBIAsmYQ5py8QA1aRsTmyT61pz+f7qz7Pd/O4xCxj8J3v1Cjl+MxRFv0uP2/g== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:nebula.arm.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(36860700013)(1800799024)(82310400026)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9156 X-MS-Exchange-SkipListedInternetSender: ip=[2603:10a6:208:ab::20]; domain=AM0PR06CA0115.eurprd06.prod.outlook.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM1PEPF000252E1.eurprd07.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 99f6797a-972d-497f-0598-08dcf350548e X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|376014|1800799024|82310400026|35042699022; X-Microsoft-Antispam-Message-Info: OWV8Smh/yWvHGlkU7lJSbDeLORaY9dkNdT50ptopb4HLTyVfp+yzGe65htd6XeyvsFqVgSlRpwCO67k+rHSau7yGX7tGQ1+CAL+buCUYjXaowgU1OjIPZhwCWA/Ux0mpo7muzfCznwdfc1+zT+/FHDXT9ZCO5YIk4Kdh8HbHfo8UzSUT7P7qnNiK1fraF7iVUBp78rxy93nm8FlsYCl1pZXR5jNFV1UA2FiJS0HNo6UFHtXskEjF2Xzt1jJidxuGMIlhFj6FzQdRJ6WZITU+awGkP9wnGvkfYieleXHJUFyaJVARgD4VhcO3P/n9AgTmMmOlz9z7fZ0LICJWrINSA5CzrtYC5qHl4PruM35XBwAkx73V9zcEZKFqKahHzDYzhjDgnFqtNrbZiFsOVXA5GoLu16fmr+P49j5zjthBDCrvaKoDoHm/Oh8aYY5S6/1UYb7cPytff5fxp95U65NnmwFGpk9e2eqFLLWG7o1WkT6wH1e+5q7u6zzNVSzEmXKNZM3uSfkcsq9k7eWJKQXOotf1DoTdtPU7wKrdZ2go//X7Zyj5FhTG8lbJk/y64uU9OFwrYULxq540GfWTXL0Kyb3gqOEwWxv3oxSXzQyiAjaBY1kXFnFeUrgr2nBQNmlSJ0BK5o8AbvglCSr3KLD5vgA7W+nOFxOXCkFcXBdPdmJ5SYZQ9eBDgfw8UnOvfGr1cTdjXO5/jykVYs1/PdL++e+iKSHXotWN9DMWqnU9VqPIrGE1uVEZOkzgw45n+WoSRwUxWWlCo60ZIsiOjC9r51PvX9tguM+BdVonMcecbvKtmAO3UBCdxHJUdVwMjotOQouhk/qo8f822NFsDjTqmo5OQURmHhw8WDsZCcPmNd7bc9gkfspH5wJWPKBwi+Py2rLF8PlB/scepgAU16Hq2QKC4LtJ1ggP9gZEwT+uk7l+c37PPuh/6B+q8ye5B3CYpzilIFzbhIgSTe+2HKoVgGnQ4zY30on5ZeJKXM9SNYLWzJ9jNx1Q9S5ORs6kuRXpbWH/cw/j6AifTYOZVm6849+NcfYyKxur4kOLcYHecdA/K+KeaqGnDlDoEYcFErvzoICftL/kOxMBkW9DHGX6UR028we7Rp63CK8qWDfnTuA5gbOV0vPColIt+2gpHVL/HECQrkVzcrbnX74bfpFmRgsVUJnBUtJjI2BfUHJI+BeGHm/V/gcSqSDg7Bc4dkBFmxCd4AsLvhh14GnpO1TCjbMy84iGttNfJ+TEYeSbdm1fvbBJ0Dm8WpNqXPS9sMrtFKnzQSNEoeym8E54P9O3iDO5dlFeBcjR7TPQISyjMFA6XQbsNnMzFBHft19ej4pzPu75GFtHpkOuE2lneu9zuj/vll/LNQzIrPZJlXXbmGAa7HBI9Xt/nwzOqwGY7xi5XWDWY0p++ioazD4LhS7oUg== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230040)(36860700013)(376014)(1800799024)(82310400026)(35042699022); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2024 10:49:25.3065 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 997e5387-ee27-40f3-d7f1-08dcf3505c6f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM1PEPF000252E1.eurprd07.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB7701 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FORGED_SPF_HELO, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NONE, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list <binutils.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/binutils>, <mailto:binutils-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/binutils/> List-Post: <mailto:binutils@sourceware.org> List-Help: <mailto:binutils-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/binutils>, <mailto:binutils-request@sourceware.org?subject=subscribe> Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org |
Series |
small refactorings before posting PAuth_LR patch series
|
|
Checks
Context | Check | Description |
---|---|---|
linaro-tcwg-bot/tcwg_binutils_build--master-arm | success | Build passed |
linaro-tcwg-bot/tcwg_binutils_build--master-aarch64 | success | Build passed |
linaro-tcwg-bot/tcwg_binutils_check--master-aarch64 | success | Test passed |
linaro-tcwg-bot/tcwg_binutils_check--master-arm | success | Test passed |
Commit Message
Matthieu Longo
Oct. 23, 2024, 10:48 a.m. UTC
The current space optmization on enum aarch64_opn_qualifier forced its encoding using an unsigned char. This "hard-coded" optimization has the bad consequence of making the array of such enums being completely unreadable when debugging with GDB because the enum type is lost along the way. Keeping this space optimization, and the enum type as well, is possible when the declaration of the enum is tagged with attribute((packed)). attribute((packed)) is a GNU extension, and is wrapped in the macro ATTRIBUTE_PACKED (defined in ansidecl.h), and should be used instead. --- include/opcode/aarch64.h | 6 +++--- opcodes/aarch64-opc.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-)
Comments
On 23/10/2024 11:48, Matthieu Longo wrote: > The current space optmization on enum aarch64_opn_qualifier forced its > encoding using an unsigned char. This "hard-coded" optimization has the > bad consequence of making the array of such enums being completely > unreadable when debugging with GDB because the enum type is lost along > the way. > Keeping this space optimization, and the enum type as well, is possible > when the declaration of the enum is tagged with attribute((packed)). > attribute((packed)) is a GNU extension, and is wrapped in the macro > ATTRIBUTE_PACKED (defined in ansidecl.h), and should be used instead. > --- > include/opcode/aarch64.h | 6 +++--- > opcodes/aarch64-opc.c | 6 +++--- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/include/opcode/aarch64.h b/include/opcode/aarch64.h > index c96bad61ca0..1955ca45c67 100644 > --- a/include/opcode/aarch64.h > +++ b/include/opcode/aarch64.h > @@ -985,7 +985,7 @@ enum aarch64_opnd_qualifier > > /* Special qualifier used for indicating error in qualifier retrieval. */ > AARCH64_OPND_QLF_ERR, > -}; > +} ATTRIBUTE_PACKED; This is one of those cases where C++ really does do this better: "enum aarch64_opnd_qualifier : uint8_t". But while we are still using C, this is OK. R.
diff --git a/include/opcode/aarch64.h b/include/opcode/aarch64.h index c96bad61ca0..1955ca45c67 100644 --- a/include/opcode/aarch64.h +++ b/include/opcode/aarch64.h @@ -985,7 +985,7 @@ enum aarch64_opnd_qualifier /* Special qualifier used for indicating error in qualifier retrieval. */ AARCH64_OPND_QLF_ERR, -}; +} ATTRIBUTE_PACKED; /* Instruction class. */ @@ -1236,8 +1236,8 @@ enum err_type #define AARCH64_MAX_OPND_NUM 7 /* Maximum number of qualifier sequences an instruction can have. */ #define AARCH64_MAX_QLF_SEQ_NUM 10 -/* Operand qualifier typedef; optimized for the size. */ -typedef unsigned char aarch64_opnd_qualifier_t; +/* Operand qualifier typedef */ +typedef enum aarch64_opnd_qualifier aarch64_opnd_qualifier_t; /* Operand qualifier sequence typedef. */ typedef aarch64_opnd_qualifier_t \ aarch64_opnd_qualifier_seq_t [AARCH64_MAX_OPND_NUM]; diff --git a/opcodes/aarch64-opc.c b/opcodes/aarch64-opc.c index 05e1a248622..93ae8767dfe 100644 --- a/opcodes/aarch64-opc.c +++ b/opcodes/aarch64-opc.c @@ -768,9 +768,9 @@ aarch64_get_expected_qualifier (const aarch64_opnd_qualifier_seq_t *qseq_list, it can mean no qualifier for the operand, or the qualifer sequence is not in use (when all qualifiers in the sequence are NILs), we have to handle this special case here. */ - if (known_qlf == AARCH64_OPND_NIL) + if (((enum aarch64_opnd) known_qlf) == AARCH64_OPND_NIL) { - assert (qseq_list[0][known_idx] == AARCH64_OPND_NIL); + assert (((enum aarch64_opnd) qseq_list[0][known_idx]) == AARCH64_OPND_NIL); return qseq_list[0][idx]; } @@ -781,7 +781,7 @@ aarch64_get_expected_qualifier (const aarch64_opnd_qualifier_seq_t *qseq_list, if (saved_i != -1) /* More than one sequences are found to have KNOWN_QLF at KNOWN_IDX. */ - return AARCH64_OPND_NIL; + return AARCH64_OPND_QLF_NIL; saved_i = i; } }