diff mbox series

[v1,1/8] aarch64: make comment clearer about the location

Message ID 20241023104816.501176-2-matthieu.longo@arm.com
State Accepted
Headers
Series small refactorings before posting PAuth_LR patch series |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_binutils_build--master-arm success Build passed
linaro-tcwg-bot/tcwg_binutils_build--master-aarch64 success Build passed
linaro-tcwg-bot/tcwg_binutils_check--master-aarch64 success Test passed
linaro-tcwg-bot/tcwg_binutils_check--master-arm success Test passed

Commit Message

Matthieu Longo Oct. 23, 2024, 10:48 a.m. UTC 
  The enum aarch64_opnd_qualifiers in include/opcode/aarch64.h needs to
stay in sync with the array of struct operand_qualifier_data which
defines various properties for the different type of operands. For
instance, for:
- registers: the size of the register, the number of elements.
- immediates: lower and upper bits to determine the range of values.
---
 include/opcode/aarch64.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Richard Earnshaw (lists) Nov. 5, 2024, 5:11 p.m. UTC | #1 
On 23/10/2024 11:48, Matthieu Longo wrote:
> The enum aarch64_opnd_qualifiers in include/opcode/aarch64.h needs to
> stay in sync with the array of struct operand_qualifier_data which
> defines various properties for the different type of operands. For
> instance, for:
> - registers: the size of the register, the number of elements.
> - immediates: lower and upper bits to determine the range of values.
> ---
>  include/opcode/aarch64.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/opcode/aarch64.h b/include/opcode/aarch64.h
> index bc779c973d6..2858e2aeb82 100644
> --- a/include/opcode/aarch64.h
> +++ b/include/opcode/aarch64.h
> @@ -899,7 +899,8 @@ enum aarch64_opnd
>  /* Qualifier constrains an operand.  It either specifies a variant of an
>     operand type or limits values available to an operand type.
>  
> -   N.B. Order is important; keep aarch64_opnd_qualifiers synced.  */
> +   N.B. Order is important.
> +   Keep aarch64_opnd_qualifiers (opcodes/aarch64-opc.c) synced.  */
>  
>  enum aarch64_opnd_qualifier
>  {

OK.

R.
diff mbox series

Patch

diff --git a/include/opcode/aarch64.h b/include/opcode/aarch64.h
index bc779c973d6..2858e2aeb82 100644
--- a/include/opcode/aarch64.h
+++ b/include/opcode/aarch64.h
@@ -899,7 +899,8 @@  enum aarch64_opnd
 /* Qualifier constrains an operand.  It either specifies a variant of an
    operand type or limits values available to an operand type.
 
-   N.B. Order is important; keep aarch64_opnd_qualifiers synced.  */
+   N.B. Order is important.
+   Keep aarch64_opnd_qualifiers (opcodes/aarch64-opc.c) synced.  */
 
 enum aarch64_opnd_qualifier
 {