From patchwork Tue Oct 8 04:35:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nelson Chu X-Patchwork-Id: 98474 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CF92E385B50D for ; Tue, 8 Oct 2024 04:36:19 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from NelsondeMacBook-Pro.local (60-250-206-252.hinet-ip.hinet.net [60.250.206.252]) by sourceware.org (Postfix) with ESMTP id 9F0693858D29 for ; Tue, 8 Oct 2024 04:35:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9F0693858D29 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=NelsondeMacBook-Pro.local ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9F0693858D29 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=60.250.206.252 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728362150; cv=none; b=EdkFoHX758yM7VAeYTFfAlABbZLeKoLzDpndahYQRCp/sTagINg6jjRPSH7/tf4ZVTFkHUjcjjeyIsB5jNcEI+zOXPId3xI0F9N/0ZYdT9bEJ0axGtxbmGXlDNEPnn4MhADLdbu5VSz1cegSn2D1b/kH1fCDJjMkHUnSzc3I4Xg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728362150; c=relaxed/simple; bh=Cs8Og1usvrzqw9M63FjOY+7BvI4LpAG8vtzeddOtPyA=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=F6uOKLgJz8EXlgxeoBN59vINY1v6BhO/lRqbghxkQHcvwrMpKDhaOWBLvXVgtTu7e4uGXK8rYaRmgF0uHAZVdVZKzukVhJuYJy2ZqlSGQ/PRJkRf++30iYvkN9cFh7nxQgxNGMHOmPvTkraOz5P4eBBgEOoBWQd+/Z8MqFn7ob8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by NelsondeMacBook-Pro.local (Postfix, from userid 501) id A0AB3231810B; Tue, 8 Oct 2024 12:35:44 +0800 (CST) From: Nelson Chu To: binutils@sourceware.org, jim.wilson.gcc@gmail.com, palmer@rivosinc.com, andrew@sifive.com, jbeulich@suse.com Cc: lifang_xia@linux.alibaba.com, Nelson Chu Subject: [PATCH] RISC-V: Don't report warnings when linking different privileged spec objects. Date: Tue, 8 Oct 2024 12:35:43 +0800 Message-Id: <20241008043543.13433-1-nelson@rivosinc.com> X-Mailer: git-send-email 2.39.3 (Apple Git-146) MIME-Version: 1.0 X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, KHOP_HELO_FCRDNS, NO_DNS_FOR_FROM, RDNS_DYNAMIC, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org Since only the abandoned privileged spec v1.9.1 will have conflict csrs, to keep the compatible we still report warnings when linking privileged spec v1.9.1 objects with others. But don't report warnings for other compatible cases because it is actually a bit noisy and useless... bfd/ * elfnn-riscv.c (riscv_merge_attributes): Only report warnings when linking the abandoned privileged spec v1.9.1 object with others. ld/ * testsuite/ld-riscv-elf/attr-merge-priv-spec-failed-01.d: Removed. * testsuite/ld-riscv-elf/attr-merge-priv-spec-failed-02.d: Removed. * testsuite/ld-riscv-elf/attr-merge-priv-spec-failed-03.d: Removed. * testsuite/ld-riscv-elf/attr-merge-priv-spec-failed-04.d: Removed. * testsuite/ld-riscv-elf/attr-merge-priv-spec-failed-05.d: Removed. * testsuite/ld-riscv-elf/attr-merge-priv-spec-failed-06.d: Removed. * testsuite/ld-riscv-elf/ld-riscv-elf.exp: Updated. --- bfd/elfnn-riscv.c | 17 +++-------------- .../attr-merge-priv-spec-failed-01.d | 12 ------------ .../attr-merge-priv-spec-failed-02.d | 12 ------------ .../attr-merge-priv-spec-failed-03.d | 13 ------------- .../attr-merge-priv-spec-failed-04.d | 13 ------------- .../attr-merge-priv-spec-failed-05.d | 13 ------------- .../attr-merge-priv-spec-failed-06.d | 13 ------------- ld/testsuite/ld-riscv-elf/ld-riscv-elf.exp | 6 ------ 8 files changed, 3 insertions(+), 96 deletions(-) delete mode 100644 ld/testsuite/ld-riscv-elf/attr-merge-priv-spec-failed-01.d delete mode 100644 ld/testsuite/ld-riscv-elf/attr-merge-priv-spec-failed-02.d delete mode 100644 ld/testsuite/ld-riscv-elf/attr-merge-priv-spec-failed-03.d delete mode 100644 ld/testsuite/ld-riscv-elf/attr-merge-priv-spec-failed-04.d delete mode 100644 ld/testsuite/ld-riscv-elf/attr-merge-priv-spec-failed-05.d delete mode 100644 ld/testsuite/ld-riscv-elf/attr-merge-priv-spec-failed-06.d diff --git a/bfd/elfnn-riscv.c b/bfd/elfnn-riscv.c index 4844412a4d4..eda23af3af1 100644 --- a/bfd/elfnn-riscv.c +++ b/bfd/elfnn-riscv.c @@ -4071,20 +4071,9 @@ riscv_merge_attributes (bfd *ibfd, struct bfd_link_info *info) else if (in_priv_spec != PRIV_SPEC_CLASS_NONE && in_priv_spec != out_priv_spec) { - _bfd_error_handler - (_("warning: %pB use privileged spec version %u.%u.%u but " - "the output use version %u.%u.%u"), - ibfd, - in_attr[Tag_a].i, - in_attr[Tag_b].i, - in_attr[Tag_c].i, - out_attr[Tag_a].i, - out_attr[Tag_b].i, - out_attr[Tag_c].i); - - /* The privileged spec v1.9.1 can not be linked with others - since the conflicts, so we plan to drop it in a year or - two. */ + /* The abandoned privileged spec v1.9.1 can not be linked with + others since the conflicts. Keep the check since compatible + issue. */ if (in_priv_spec == PRIV_SPEC_CLASS_1P9P1 || out_priv_spec == PRIV_SPEC_CLASS_1P9P1) { diff --git a/ld/testsuite/ld-riscv-elf/attr-merge-priv-spec-failed-01.d b/ld/testsuite/ld-riscv-elf/attr-merge-priv-spec-failed-01.d deleted file mode 100644 index 7f987070ea0..00000000000 --- a/ld/testsuite/ld-riscv-elf/attr-merge-priv-spec-failed-01.d +++ /dev/null @@ -1,12 +0,0 @@ -#source: attr-merge-priv-spec-a.s -#source: attr-merge-priv-spec-c.s -#as: -#ld: -r -#warning: .*use privileged spec version 1.11.0 but the output use version 1.10.0 -#readelf: -A - -Attribute Section: riscv -File Attributes - Tag_RISCV_arch: [a-zA-Z0-9_\"].* - Tag_RISCV_priv_spec: 1 - Tag_RISCV_priv_spec_minor: 11 diff --git a/ld/testsuite/ld-riscv-elf/attr-merge-priv-spec-failed-02.d b/ld/testsuite/ld-riscv-elf/attr-merge-priv-spec-failed-02.d deleted file mode 100644 index f86ef10b6bc..00000000000 --- a/ld/testsuite/ld-riscv-elf/attr-merge-priv-spec-failed-02.d +++ /dev/null @@ -1,12 +0,0 @@ -#source: attr-merge-priv-spec-c.s -#source: attr-merge-priv-spec-a.s -#as: -#ld: -r -#warning: .*use privileged spec version 1.10.0 but the output use version 1.11.0 -#readelf: -A - -Attribute Section: riscv -File Attributes - Tag_RISCV_arch: [a-zA-Z0-9_\"].* - Tag_RISCV_priv_spec: 1 - Tag_RISCV_priv_spec_minor: 11 diff --git a/ld/testsuite/ld-riscv-elf/attr-merge-priv-spec-failed-03.d b/ld/testsuite/ld-riscv-elf/attr-merge-priv-spec-failed-03.d deleted file mode 100644 index cfbb23328a6..00000000000 --- a/ld/testsuite/ld-riscv-elf/attr-merge-priv-spec-failed-03.d +++ /dev/null @@ -1,13 +0,0 @@ -#source: attr-merge-priv-spec-a.s -#source: attr-merge-priv-spec-d.s -#source: attr-merge-priv-spec-c.s -#as: -#ld: -r -#warning: .*use privileged spec version 1.11.0 but the output use version 1.10.0 -#readelf: -A - -Attribute Section: riscv -File Attributes - Tag_RISCV_arch: [a-zA-Z0-9_\"].* - Tag_RISCV_priv_spec: 1 - Tag_RISCV_priv_spec_minor: 11 diff --git a/ld/testsuite/ld-riscv-elf/attr-merge-priv-spec-failed-04.d b/ld/testsuite/ld-riscv-elf/attr-merge-priv-spec-failed-04.d deleted file mode 100644 index 4332597daa4..00000000000 --- a/ld/testsuite/ld-riscv-elf/attr-merge-priv-spec-failed-04.d +++ /dev/null @@ -1,13 +0,0 @@ -#source: attr-merge-priv-spec-d.s -#source: attr-merge-priv-spec-a.s -#source: attr-merge-priv-spec-c.s -#as: -#ld: -r -#warning: .*use privileged spec version 1.11.0 but the output use version 1.10.0 -#readelf: -A - -Attribute Section: riscv -File Attributes - Tag_RISCV_arch: [a-zA-Z0-9_\"].* - Tag_RISCV_priv_spec: 1 - Tag_RISCV_priv_spec_minor: 11 diff --git a/ld/testsuite/ld-riscv-elf/attr-merge-priv-spec-failed-05.d b/ld/testsuite/ld-riscv-elf/attr-merge-priv-spec-failed-05.d deleted file mode 100644 index bb6573df51f..00000000000 --- a/ld/testsuite/ld-riscv-elf/attr-merge-priv-spec-failed-05.d +++ /dev/null @@ -1,13 +0,0 @@ -#source: attr-merge-priv-spec-c.s -#source: attr-merge-priv-spec-d.s -#source: attr-merge-priv-spec-a.s -#as: -#ld: -r -#warning: .*use privileged spec version 1.10.0 but the output use version 1.11.0 -#readelf: -A - -Attribute Section: riscv -File Attributes - Tag_RISCV_arch: [a-zA-Z0-9_\"].* - Tag_RISCV_priv_spec: 1 - Tag_RISCV_priv_spec_minor: 11 diff --git a/ld/testsuite/ld-riscv-elf/attr-merge-priv-spec-failed-06.d b/ld/testsuite/ld-riscv-elf/attr-merge-priv-spec-failed-06.d deleted file mode 100644 index 9d97ff99a7b..00000000000 --- a/ld/testsuite/ld-riscv-elf/attr-merge-priv-spec-failed-06.d +++ /dev/null @@ -1,13 +0,0 @@ -#source: attr-merge-priv-spec-d.s -#source: attr-merge-priv-spec-c.s -#source: attr-merge-priv-spec-a.s -#as: -#ld: -r -#warning: .*use privileged spec version 1.10.0 but the output use version 1.11.0 -#readelf: -A - -Attribute Section: riscv -File Attributes - Tag_RISCV_arch: [a-zA-Z0-9_\"].* - Tag_RISCV_priv_spec: 1 - Tag_RISCV_priv_spec_minor: 11 diff --git a/ld/testsuite/ld-riscv-elf/ld-riscv-elf.exp b/ld/testsuite/ld-riscv-elf/ld-riscv-elf.exp index 0ee20255551..7b1b2aa285d 100644 --- a/ld/testsuite/ld-riscv-elf/ld-riscv-elf.exp +++ b/ld/testsuite/ld-riscv-elf/ld-riscv-elf.exp @@ -165,12 +165,6 @@ if [istarget "riscv*-*-*"] { run_dump_test "attr-merge-priv-spec-03" run_dump_test "attr-merge-user-ext-01" run_dump_test "attr-merge-stack-align-failed" - run_dump_test "attr-merge-priv-spec-failed-01" - run_dump_test "attr-merge-priv-spec-failed-02" - run_dump_test "attr-merge-priv-spec-failed-03" - run_dump_test "attr-merge-priv-spec-failed-04" - run_dump_test "attr-merge-priv-spec-failed-05" - run_dump_test "attr-merge-priv-spec-failed-06" run_dump_test "attr-phdr" run_dump_test "relax-max-align-gp" run_dump_test "uleb128"