From patchwork Tue Jul 30 15:36:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick Alcock X-Patchwork-Id: 94793 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 95708385C6CA for ; Tue, 30 Jul 2024 15:40:40 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 00F27385B503 for ; Tue, 30 Jul 2024 15:37:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 00F27385B503 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 00F27385B503 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1722353866; cv=pass; b=k5LEAGm9Vn8uJIORRQzE4klC41tlCqf0rwPbVjDWAvYVg3RVAYdCxqtpsmFIO8Hwm3wpi6zf5ej+GQsUI2vJH9AsjpTWWDcgIfTEMfz7cvbliK/B4T/0KiJYivB4OKOghiZTG2/WkZlAjSudcO3BTYsANiRUAckM7g621ufQGH8= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1722353866; c=relaxed/simple; bh=c+QuiZwd9BXJAms3NdwJ8ytaEP/puq9uM4y38Lf88FE=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=MTvLF8ccAJEkoyvkhG3xBV150F7yQK2qTlZ8WwuVX9RR5tSrdJWsOty3E07wJlp18jAjPN6FX48g+WLB8nMdLwUAs4Wze3pAcybGa/ug+kV9iGNq3Y/EUJgoBKA6ufWyf43U8F1G2q5w2TerXBnoVD8azV1IswFarMxA47prsl4= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 46UFMbnC010403 for ; Tue, 30 Jul 2024 15:37:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= from:to:subject:date:message-id:in-reply-to:references :content-transfer-encoding:content-type:mime-version; s= corp-2023-11-20; bh=p1UF5dkS4lLLYV50LlDUK6JSqeiqLlCVmC53cWmj5LE=; b= gRR6eJjCGOFcLlA++P3bp4VpLkkjDdwcCroQA4xpTwN0F1AEUpLm1A8IIjNMg7jF JeY0vFilHlSJ4za7xFlP+sWGaIqSKkFNjw7PVUWBCRUr5cmvVtPqaEjxT8fwmAxI NGdvejUnGL/aanZ8zZFE2c6UcHlpA6qFWpl9m1oSa2uXHh+xKLvlOGRWCXqTUSpx 7Pv/XWCxhX13A3VpgBA2p0T9oJZ7k3OwhgyNSXfBzRw8KwILFx14N09g7f5Eg3jJ NqaZXIjqtzlwX5HwiqvQQ5Cl0xjZeNqU1bn5KQRcm/jJjL6g9NBmXy5gV0CNrZIi Wz1+u+arYrcK3h86pCaAjg== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 40mqtanc40-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 30 Jul 2024 15:37:42 +0000 (GMT) Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 46UF0YTX002828 for ; Tue, 30 Jul 2024 15:37:41 GMT Received: from nam02-dm3-obe.outbound.protection.outlook.com (mail-dm3nam02lp2041.outbound.protection.outlook.com [104.47.56.41]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 40nrn7c3k6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 30 Jul 2024 15:37:41 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZBwQ12pPFZShjuKwEWr8hUF00eHGHZFPPD1i2YlU9VUvBPapaXB8h4S+sLbs3N/DuCiE+fMxk1MuhsAfGfjmOI7L9SpyNzv7eo6ISgsUgU16O3Yku79/DEXLeRvGo/fVlVBJx26gWjdvC4KaWBn9uUpj3LgaCb6eji3FB8ucWUNsHul0nRDsydlGnfAbXd0sbPQdBZt4a1PQ1io7JCXxyLWa14sN/CrfYXOsNd/bLPWVU2J8yLGr9zlPzytQ/ZfMT7qaQ7+XrHBUFgnV7OXOxstsF3eY3Oi+PyWoRd9dFSmLsQ0sC8a7Y/miZWt3/cfTGgW2u5QbYOjxPyB7TGNrBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p1UF5dkS4lLLYV50LlDUK6JSqeiqLlCVmC53cWmj5LE=; b=l2Y/QIrwcgqNHcBorXmyQdQq+J34uIzu9kFnzxMtE+NGz0WCaBWJuA+BTNySCC1rejiqoHqk3Vnvcx8ex5N58IFZGYivjirTcSMCnj0rJHnjQoOf6BvPn7/CcJa0pp5O+QELOEA/Lt3mfHV/8F/aF3iNex8dTYwhG+1e6xF0s2ScC/ZpdEFbKTybiWQPJOqsN8rbZtO9Q9lBTxgL2nxUGzhl+zA4APmIgF3/2JeSUuvrwwhNAtsjeV0unmVh72ta8EEv6CJTR33URGdBhw/cBek/nKmZHK60aSMnUkaz/lExGMXh9nMFE97gACdopEUarIyLd2DJGSfq1cvzHAcG5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p1UF5dkS4lLLYV50LlDUK6JSqeiqLlCVmC53cWmj5LE=; b=UdHF+Y1g97dqECFwJM6cAzelayDcMb17CeK7gifhML9pzXX6RyCwxinNwCkTWzE/6nyE7w1o8w50W2yeletrAHYtHeozn1YCJ6ssrEhzfUR2BoH5iT2YAgyvXqeLXlKy7+MABIbCXnDJI6eW18py9U4XdjSOgs8Ommp/FxzWqUI= Received: from MW4PR10MB6608.namprd10.prod.outlook.com (2603:10b6:303:22e::8) by DM4PR10MB7476.namprd10.prod.outlook.com (2603:10b6:8:17d::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7807.28; Tue, 30 Jul 2024 15:37:39 +0000 Received: from MW4PR10MB6608.namprd10.prod.outlook.com ([fe80::b53a:ccc1:c190:c5df]) by MW4PR10MB6608.namprd10.prod.outlook.com ([fe80::b53a:ccc1:c190:c5df%6]) with mapi id 15.20.7807.026; Tue, 30 Jul 2024 15:37:39 +0000 From: Nick Alcock To: binutils@sourceware.org Subject: [PATCH 07/19] libctf: improve ECTF_NOPARENT error message Date: Tue, 30 Jul 2024 16:36:55 +0100 Message-ID: <20240730153707.168357-8-nick.alcock@oracle.com> X-Mailer: git-send-email 2.45.2.276.g4ac82df17e In-Reply-To: <20240730153707.168357-1-nick.alcock@oracle.com> References: <20240730153707.168357-1-nick.alcock@oracle.com> X-ClientProxiedBy: LO4P265CA0063.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2af::16) To MW4PR10MB6608.namprd10.prod.outlook.com (2603:10b6:303:22e::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW4PR10MB6608:EE_|DM4PR10MB7476:EE_ X-MS-Office365-Filtering-Correlation-Id: 09b9dc24-4974-4d1c-2683-08dcb0ad8b2b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: bX6dI97d5NIKjB0UknoTwTuMVpnMQZm1VvTKWC41HlmBo5s+NJ27CoZmswP5rN+7e8YWXf77c2aaVUi2x5zn2rx8EV6tPt87dAiE7r4V7xV2uLdj+c2TlY8JclVRbOtXHk+9qKMZcg63tJ+wSvCHsPD66QDiTyv4EixlhR3KuOZfn0kS2corzEF2z4yBegIqq6XnW/bYbbFUOpZp5GkIKTgKt0n41dNRgVcekP8N9ojyJfMl5dGhNEvUDieUPlRmqUiR6pgJGAB/rTYEalllNBxl4cO7lU9pwSSY0vtrhRZcRf6PvXSHLrop0rJ2uIVphiZH03Mb/56egxCYw6sUWuPM9fLHDqQUo8nBN2St6VzpQgyjWGnVbaUv8HWazbBKHhpTB2ehg7Ne+sQ6mYhpIzLAgQvH+vctF8wAyJPIkSqAMR2AsK1ItIjYw6qjj7kibRO+CHoPLl6QJfuCE9iGRTMVGsc4gEmrHtlP5QAaGe0RludwJb0NDU2OL/GmsCw8htAH0KTxrh9LdbSpz1SPVB1sXJX2KRC8BivOi9fUfc5HLBmF1gKKX31ic/oG2cpIo7CzUnGJo/ReeVBqAnyCZbLNT5gEc4mLsrUJ62Pg0dhHr8WsErlC9QKpDDr/SnA7k++leQQyU4/pv74r/98R8/Dwcgg9sZ8QmhQiQlpTHWcheKUwP14ewrrjFHXJ/G/WucJJCxlP6qM3G866BqY0TqjWzhcLPX7K+KyWRTKCPgpQ7TXVaQkXxEjv52PcG5srtPSzC0NO3vHgJ4w/psDn2Qh8988zlS0S4BmJPD3PQVFs//dhDhkAoPignYcBXxombY0hdPhuWiKJSg2LsVyoUf68lV9rS6n31R6UOX9iQ7GaeQ0xXOs7aJ3u1rhMxvA19tLBiuMlkXOtWuRVcS8sZAbDBzyRISmlNnoGG/zi2Moshr2eSnpYH730Zubs9xgH92UU7rrDuX9Jga+/5yc7O7cCBJGwdMlKF8k1ALGc7SUX25Lxo73E5IPrxvEOaOSdx9umfD5Uq3EcoL+IeyJ02qPLQFj+AIrBA2GaFmKZWwIN6JqQTJVS7nFPJ7cBLJmAKIAdKtdMzgYW+jG6z4xEiAokIW/1PmaESkDW/8Nr3HQ8n0w7hCSc8XRztJuBaKUsvLOEarv1tbDXjvTGiUNWnYjhU3FN8wWUt2MeNlD4qofNabga6nymgcSR2MA6h113RmrEV8HPlGi4ZlqnU4k9oG71nmInexrGZxuwdhUPGyV6o16eAPRjIb5i+da6t+mXiOf6Uwc+4kvwOmFGy0dXrH/h4uEtK03xA+Th5AXT5kQ7/VY2B05P1U03UnXFyPObm/Y+6yAAKEj8JATI00GVbw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW4PR10MB6608.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ZoIq3wl+9f9pU7JcujmJ1cNrO5UnWTQqSdw5ljT6ypw2l70ZpyKiZyo6BlIgjRI5J41hyo8rmK3F6qOuCfUHIi2J/S9f3szWHg7DCdHNJ03SvLdxz+CvXMSG1SPrD/zZGbg+aroL8BVNPj6ldX85TFenjuj1et6rW1OPrxZgY4oyj9XhzCedgUSpPnyZei3Kz3CdYDZAPsjb4Kp2QhhzIYysNDaVci7FMkFEOyTwdRFPbT1JfNkm/xYQ1wi3YzZDVjjdFaU90yqljPRxZD1S4294tAqHBoD42Wnno/JZOgZPM7/Ble7FHZTL8yju55xR6QDK3V93W6i7WOiuJ0VXXp1qaYexNDH3fx++4Cb/hzCNvRR2Vxe7lsf72c/P0NMYODKXfuCUb8JQPXcv7uLDZk+KZfC7G5u19BWsTz/7DUbAp/j2diT/znTcdtRajNu1XC7WEIiEDFngEILyyHjEsZ8QNHbw2coDNe4ct+FgEx9eilQbQ98z6jTaCkccw3pQk+/WWWO02AjzNuVHMRS4/pW5THHreMdit3H0DLOKTGYuds7QSGtqZrZ7THJCKD6SOekM525x+Gd2OCSd7usfq+/vam5eUo3Z2p8Opyh3qWtSzdvQqAwvLOni/4i+7NZTSCpb4C2lY4VaGxNgMC/6j3h7ejobsBR4/ah19fiNIWi49OvQm/7FEm70r3Eo7Z8j207eTRVMwkqQjzcVHhjNirR4L7nZI/zOhM/SsZPv5inMfcSSxs0+bV3Xjx/wGXEm8GUtWkYZ8LxnI+pDdb4iDjXV08ZVNd5yJWjy87LguTJRHsxB5lyVFk0+fzXMYTW+aHzMzsKNn79t3LiB+5zTzW/YGUtb1OtynTU0EloFOnZXEejBlYepTCysSs6W005+phct4jkZIuVYr7eqji4oDVosXot5T8o/JD4a7nSM/u8FOEEvUQbtkKTBDeKuNEHYtkkBC3oupyD2yfLmcVaDiphOT3RSRqO8mPhJBI22LBD1GcU6JXhSCvolI4irjMUQ9YJPhAZYUsC5J5CX6LHhQjI7B3Owndw5+ECrRhQbXtHH5uLYPEhyhFEiCOz8QOCq5hMsPusfQls1ReVzD2Dv/lXXLgbZJ5lC6s1aE4Wp1kgcA7e98ilVN9wpWfZZksHJwgVINBkxn9TvNfRj+SkRCho9IiJJPGyT4Ilz8RlkRErgWINkjIbgxqHBBeMrJ8ZTT7a2j5A8c7zdSejuTYxzQIArQlgpCKqg/7p573e/ferCx4c+CLCD+K2kwqbMK6EjKA7j90O9sjoWwJoTR6UtwDen+Q68Bwj6UZNgF7zK3Brm4RK24Asw0s+O3Xa6C4LchiBWQq6MWsalW2T9QhI8EYgprPdi95FVLvuQSRqIQ/LcpZ/Ed0xbalywWDlgxRYrJhyQvgtOHHW0lcZRyhDH4JdCrbtn87txWQRTuqF9H8NgUbNIJu0sdv8T31HplHEpVJdMTwaCUnN1xLysRETrTJpijVU4tXp7PHVlZCneab9dZw3Nybzlw16HObfaKUoQMgflSdFPk+aeByuNgeM5ThYIgPq3tJ2z7vnI2TJUOJ5d+sAvMhRxxh8sqnT7ckVusHJAN1NRcSiI5DWWAW8/DA== X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: LqGGXQ8tt0jbzKBoMR+xL5v0QlGX8QpJ4Lv4ZtDQgIeGzAW71LFXnBO8bspCQM/nFmEUDN3lcS9Jc9mg7agjQNn1sCw9G6xRxGs4gBG7V7AvLZs6DsvQBme5Jig1U9vx1MUdOLFu3orBfU8/qUX68FXFqnS3odPo36m8gYcY/ObLDGAi31GzL2TpcWaq19IBNDb6ESz34s8rAy37B6SCFLq028cqirFcx/RlyQWTmhY0FChXRzMRLQq0K/cvn2SXsDyHCqjhsPYhrJpd4fnhatsTLuEmdmGUsZKBaVeZH0a+P8ctoEyH/liQr2x+9K5+O94WN6AjRhL9amnve1Gp16JZIj5mVqgntA7c2/tswpsepNA4xdZ2ym/bLsLqsef4pKrbpI635TvAiIePKPvC0ooNg7CwgC/iLJ8m5KYqgwz+bLGd0/6ZwibutpuzRZ3RLw5cxy5bsdKs/vbaTvAzyf3Fz0waLO/PpAyZPyX2wC4Nksv/zvBFCN8NfuIwICCXI6bUgkA4z6iaVJV7DEJOLt5S/vY16ihWbHHrM6p45xo8lwmCMk4zdn57oTXEKx/89WJj9FSxd3s99RoiXFIYo2tTlmWPNxe2A++ysjImCAc= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 09b9dc24-4974-4d1c-2683-08dcb0ad8b2b X-MS-Exchange-CrossTenant-AuthSource: MW4PR10MB6608.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jul 2024 15:37:39.2595 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: A75lphD4TVUZGUcqz9PNpT5kUzJNvXqaMSh5KHxd3lRK3GvAm0VVJHKoInu9KoY2AsVtVHswP/Ad1RodmYn9Yw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB7476 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-07-30_12,2024-07-30_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 mlxlogscore=864 suspectscore=0 bulkscore=0 phishscore=0 adultscore=0 malwarescore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2407110000 definitions=main-2407300106 X-Proofpoint-GUID: Wt5FUsejHiLIa7vExsHhilSSi5mpiDuK X-Proofpoint-ORIG-GUID: Wt5FUsejHiLIa7vExsHhilSSi5mpiDuK X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org This erorr doesn't just indicate that there is no parent dictionary (that's routine, and true of all dicts that are parents themselves) but that a parent is *needed* but wasn't found. include/ * ctf-api.h (_CTF_ERRORS) [ECTF_NOPARENT]: Improve error message. ld/ * testsuite/ld-ctf/diag-parname.d: Adjust. --- include/ctf-api.h | 2 +- ld/testsuite/ld-ctf/diag-parname.d | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/ctf-api.h b/include/ctf-api.h index f1087bc0542..ad5add23706 100644 --- a/include/ctf-api.h +++ b/include/ctf-api.h @@ -196,7 +196,7 @@ typedef struct ctf_snapshot_id _CTF_ITEM (ECTF_NOCTFDATA, "File does not contain CTF data.") \ _CTF_ITEM (ECTF_NOCTFBUF, "Buffer does not contain CTF data.") \ _CTF_ITEM (ECTF_NOSYMTAB, "Symbol table information is not available.") \ - _CTF_ITEM (ECTF_NOPARENT, "The parent CTF dictionary is unavailable.") \ + _CTF_ITEM (ECTF_NOPARENT, "The parent CTF dictionary is needed but unavailable.") \ _CTF_ITEM (ECTF_DMODEL, "Data model mismatch.") \ _CTF_ITEM (ECTF_LINKADDEDLATE, "File added to link too late.") \ _CTF_ITEM (ECTF_ZALLOC, "Failed to allocate (de)compression buffer.") \ diff --git a/ld/testsuite/ld-ctf/diag-parname.d b/ld/testsuite/ld-ctf/diag-parname.d index f8fcd683a9d..4672f71ae9b 100644 --- a/ld/testsuite/ld-ctf/diag-parname.d +++ b/ld/testsuite/ld-ctf/diag-parname.d @@ -2,4 +2,4 @@ #source: diag-parname.s #ld: -shared --ctf-variables #name: Diagnostics - No parent dictionary -#warning: CTF linking failed; output will have no CTF section: The parent CTF dictionary is unavailable +#warning: CTF linking failed; output will have no CTF section: The parent CTF dictionary is needed but unavailable