diff mbox series

[07/19] libctf: improve ECTF_NOPARENT error message

Message ID 20240730153707.168357-8-nick.alcock@oracle.com
State New
Headers
Series libctf: various bugfixes (including a write into freed memory), and loosen constraints on enums |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_binutils_build--master-arm fail Patch failed to apply
linaro-tcwg-bot/tcwg_binutils_build--master-aarch64 fail Patch failed to apply

Commit Message

Nick Alcock July 30, 2024, 3:36 p.m. UTC 
  This erorr doesn't just indicate that there is no parent dictionary
(that's routine, and true of all dicts that are parents themselves)
but that a parent is *needed* but wasn't found.

include/
	* ctf-api.h (_CTF_ERRORS) [ECTF_NOPARENT]: Improve error message.

ld/
	* testsuite/ld-ctf/diag-parname.d: Adjust.
---
 include/ctf-api.h                  | 2 +-
 ld/testsuite/ld-ctf/diag-parname.d | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/include/ctf-api.h b/include/ctf-api.h
index f1087bc0542..ad5add23706 100644
--- a/include/ctf-api.h
+++ b/include/ctf-api.h
@@ -196,7 +196,7 @@  typedef struct ctf_snapshot_id
   _CTF_ITEM (ECTF_NOCTFDATA, "File does not contain CTF data.") \
   _CTF_ITEM (ECTF_NOCTFBUF, "Buffer does not contain CTF data.") \
   _CTF_ITEM (ECTF_NOSYMTAB, "Symbol table information is not available.") \
-  _CTF_ITEM (ECTF_NOPARENT, "The parent CTF dictionary is unavailable.") \
+  _CTF_ITEM (ECTF_NOPARENT, "The parent CTF dictionary is needed but unavailable.") \
   _CTF_ITEM (ECTF_DMODEL, "Data model mismatch.") \
   _CTF_ITEM (ECTF_LINKADDEDLATE, "File added to link too late.") \
   _CTF_ITEM (ECTF_ZALLOC, "Failed to allocate (de)compression buffer.") \
diff --git a/ld/testsuite/ld-ctf/diag-parname.d b/ld/testsuite/ld-ctf/diag-parname.d
index f8fcd683a9d..4672f71ae9b 100644
--- a/ld/testsuite/ld-ctf/diag-parname.d
+++ b/ld/testsuite/ld-ctf/diag-parname.d
@@ -2,4 +2,4 @@ 
 #source: diag-parname.s
 #ld: -shared --ctf-variables
 #name: Diagnostics - No parent dictionary
-#warning: CTF linking failed; output will have no CTF section: The parent CTF dictionary is unavailable
+#warning: CTF linking failed; output will have no CTF section: The parent CTF dictionary is needed but unavailable