Message ID | 20240730153707.168357-5-nick.alcock@oracle.com |
---|---|
State | New |
Headers |
Return-Path: <binutils-bounces~patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AB2A4385DDCC for <patchwork@sourceware.org>; Tue, 30 Jul 2024 15:38:48 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id E699E3858282 for <binutils@sourceware.org>; Tue, 30 Jul 2024 15:37:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E699E3858282 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E699E3858282 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1722353856; cv=pass; b=XGA+vpOBc7O3Jkp1kSR+lVfewuCsH9IBGdHcSt8dWQeCtZ9knMjPIbrxGigmrMX8fV4TtjFXLbyAiAHJviFkf7TDQ4Ow+OZiFbwT2Dz2ZalYc7W446PJ/hy3AQkXlihyAXi9Qnpv46Hv3XREuLDeVXEJeYiT/U2QpYHnkT2Uw8c= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1722353856; c=relaxed/simple; bh=T0GhCoHr7DaE0V3FSD/wn71O4mJTj/EInDbcp8lAsJQ=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=lzqSsIdi29noS5S3os/cRKUZZmZjtmsABJuHPZHxvaaWX6L0xXfGWweUGIUgbxd9h76LoJul62vVG5uwBF1ldvRC1dla+WOAI1nxVZ9dFERkAjeBJ+rz+Hkch17yPW8oqfcJNuW2PwNvYOe3jG7psGV9W+tFcUXedLxQIiYTDjw= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 46UFMWVm006639 for <binutils@sourceware.org>; Tue, 30 Jul 2024 15:37:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= from:to:subject:date:message-id:in-reply-to:references :content-transfer-encoding:content-type:mime-version; s= corp-2023-11-20; bh=uM/cnluH2/koHW7nQlYTyxsRirbz/ckIVbYxFMWvWeQ=; b= dIF4Ij1OlW3pmYZlsZtyjDv1H1kDt7YCZjFfsIZp+RvXcv88WiXk8Ji7foLSsVQJ yfIHhFyFWtTMEAB8UjA4l51J0ujg4g8ZcuGbjlwy+ZDN0oDjG/Tlu/7w3ZFPvQRP 1y8VeL4494Fd1k3EVZnv258TleIzZV8vLTmkAhoo0rPm8LoD3aTvDSV+OBDdAB7m oK8WSUceFdVYEo905Zhg9cSy+ePNOv8aFeWQvALLogREk5cczP+kayLP1YLJwNAx XTI9xs8BJOsz2tCeP9a1Axv5Lew6tz9wrkUWKa8MfENgym/Ylbcva5TnhJ7jAG7U yvfHUl5+ufX5HSAvl8PiHA== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 40mrs8n9yk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for <binutils@sourceware.org>; Tue, 30 Jul 2024 15:37:32 +0000 (GMT) Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 46UEW8Mq035624 for <binutils@sourceware.org>; Tue, 30 Jul 2024 15:37:32 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2048.outbound.protection.outlook.com [104.47.70.48]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 40nvnwdy0n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for <binutils@sourceware.org>; Tue, 30 Jul 2024 15:37:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nVGutpgh4bIjaq4JzvPKvMizrhOlXUKtkgvO0KWjUw9KQAlQAa7eRehADT5MqFgWcYWlj2EQ2W+LSdDTM6ILlsFINDfo//G1C0BEF/2zwyyoHk/w/KoHYfvYpaTIql1MevEKVVFg3BMWjhyumTK5/vrbJx4fdJArfUbDBsr8Zd4KSTzMfMaSHUJi1lVDQjAV6t+rktV9fa+2O9N5frd74XlwtOYRJSE0sMXXm0kP0J8ParinHC6u2SkYORdQmbUpQNB0hWpO4HzUbU5ZPYDH3cq8VAFP9RzTVn5JvPAhkksSuz6XQFYKi5FujrBXNL/1XNZnfId+oUWxBmcN31dVNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uM/cnluH2/koHW7nQlYTyxsRirbz/ckIVbYxFMWvWeQ=; b=iRRV5pIwwR/4zOgSUwPWkUAxSUpXxC1mM/A3TR4knt9NhPKgi5w0ZW9GcBmwMX2px8VCASHDnT4ATU7futA6/0ZGK9QV+HPtTqosFoGzUYkza3ZTqQyW442QBvNO1RyZ2oVuLmburXsU87A99a7moy96yCFGLLMnqoTEBu+sRUvT/6RbOq1YITWYK3J15qorlfPBXwtnpTkXfhrVVmMu+FOcd4Xh5HuXIvUw73qpqWZ0JF2+gzAUib0/2wGLVPdlJbuJK9WxnCiAJhGnpszLPu5L0Dvn+1XvRuG2Ln6Ztw3jXn5f2pDwPDHHuLnRJgwsvYXi89h1mgGqV0bBx46+IA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uM/cnluH2/koHW7nQlYTyxsRirbz/ckIVbYxFMWvWeQ=; b=B808AivRTdX5YYuXjZ0+DTdpwGTf4E88MeZKDrtKyzkL3TKea3M8upa5JmMTwzlc63WIG5r/43JBu6VZyZY+tU0mMS69KiYFMWG2EEaYG37lEAoFpdNphb0+cHyIl3EfCWsVnMQkQlISfESLOOW+6PuQotD8aDv6U3hxbvmriC0= Received: from MW4PR10MB6608.namprd10.prod.outlook.com (2603:10b6:303:22e::8) by DM4PR10MB7476.namprd10.prod.outlook.com (2603:10b6:8:17d::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7807.28; Tue, 30 Jul 2024 15:37:29 +0000 Received: from MW4PR10MB6608.namprd10.prod.outlook.com ([fe80::b53a:ccc1:c190:c5df]) by MW4PR10MB6608.namprd10.prod.outlook.com ([fe80::b53a:ccc1:c190:c5df%6]) with mapi id 15.20.7807.026; Tue, 30 Jul 2024 15:37:29 +0000 From: Nick Alcock <nick.alcock@oracle.com> To: binutils@sourceware.org Subject: [PATCH 04/19] libctf, dump: correctly dump non-root-visible types Date: Tue, 30 Jul 2024 16:36:52 +0100 Message-ID: <20240730153707.168357-5-nick.alcock@oracle.com> X-Mailer: git-send-email 2.45.2.276.g4ac82df17e In-Reply-To: <20240730153707.168357-1-nick.alcock@oracle.com> References: <20240730153707.168357-1-nick.alcock@oracle.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: LO4P265CA0225.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:315::10) To MW4PR10MB6608.namprd10.prod.outlook.com (2603:10b6:303:22e::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW4PR10MB6608:EE_|DM4PR10MB7476:EE_ X-MS-Office365-Filtering-Correlation-Id: 015dfff5-8886-4ce4-5b87-08dcb0ad8572 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: uKjfF1z04+TtHBIz6f9JtgZL5EynktXOmVqIwFAI15u4CF8R43vVPIA4nLU8v93pyr7+9DaVZXwVj1ghKM13rW2GFnYRTcraAs2UiiJM65dhx++4S5EPJdG1snzJoowotVJ2z3JaXepd91LFKlpT9wPOWOwX+C8lPAqcFJOjfvtlfpBDUni2c3EkMvghouJ3YDmD0KYzPMcTpSveileTRrXtvsxI05FOv5Lw4mpksTxgpH0BelaiTi1oRdS9bM0nNOVRrjKMuaibQrkiBSng4KUVtznJsuThkqKWh6WE9EzhAgEUnZhUs/+U4D6gp2JOjZ0c/TYrp9WqfdMhL8VLnxzFehlDMqe4lQ6Asmr7F8yxDcIguL6e2IiOfKncJNYAAaecyXXkveXRYN9TF2a075dm0z88oyOSJEOJeiuocBgSpfhILI/MXm12gTTyVU9YezrNlqkdJhbBF2ukjhawBYYa4eGRE1lsYwjPVclTv/SnuUcNObiDT0EdEpmv57f+x8o5McElpcDqm7IFrVxBONpT9q12s/JkDD7z77qCVtIOhxT/QP7XCYMWD3HAGeRJu1gR5VhakplGoqim4jA4Mlp9nrXdV9tXwTzfmLTKXdVSMrdPwGBjZlTtSp6QPY01zrQ9QPGmCCpa+5133njTbsU5HYYcI4fpZwUFY7Ed2HbizvjEJS8XDMRrmvvUnaMO6x8fn4sn9H/QAOZDIRPUAeXsSRdP6poYg8zeJWpcUD717gvEtYVH/ojYOo1XkdXihsXDbpkzKG8pBJkR7e8h0K8OhsByjqYNZsOcQSwUnDaSp0WRpiUfg/d+8y5DfNsD3wSDtq2i/4FgkeTjpE+kSNXaJzqgLWMpxAAJeZuXg/f6NBVHtagZIYmQYQmzLWwJbbLc16xHf32/K9Ft3eChPQ2dzyJiCGh65ft1KRTCbKi57mQc0SbE91YwJDBrFVD8FsDYUtG4cvES/nXjp6pKlk9Vg0Ws7ROWOjOkw01m1yMA74CAaEEmzO7hv6Fpnoa7Zkk8JAftpZGLwKEOxonKAXCw3h2UwouPpJoBsAfHAyG6xw9Ys4dTJv2Dpev6YfrRDMNSoz16Be9+hcuQa+MJ+LBQOGbX2RQq6MuOJNSZpEkm9ZeBe5j+cVW7o8tVaHtDVV0/ZHJPrZE1hM2LtU02/MnUONRDlHTxQrfbA5T6unw+c2abvTILx3heErygICIGegW1x8LoD8XNblFvv41CdqMkhhnuZG4/rTBPDUCk6F0tFJj9V3ng1aUpSIRr4RmsrP4OW2BFkRJvB1GqPDeNyBk7fzsdmITzqK80iFoDadPHg9yXOKdD3KRyVVmVblIMSGWk0vpE7Dht0VjtR1f+TA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW4PR10MB6608.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: zThFGAaT4zcrt/thFZiW3meRBSwaPlrrSF+xUteCt1XViPxgHDRl/cfGqS88M7Twc6ns0DeIf7tMKyZyaKqkEZr+faP8UPVYnvJe7EUvhlzc6rJjyb2zlSgXlz/J/aFzipCRzv//2CNUKqiwCnXRDJpFi+bYspSxFITZDgtEH27DDsFvKIQL41+yZ5UClJLsHEEQXLHu4yVUPMrp4trcjVBA8i3+xX5GtcHot1DHiJDElai405CfaUiTx3QibWs2lJmiXsooMFFEywIouA4d1XijmBDW/AbmlqnWhc6UBIIJNEG9tS+MQJ6AKLHqZRyS2rOdvzecM1c1t0TNNfrfhJiTk2lfkxHgx/yB4b4m1fswhuzz1SOagtTBzV+boz43ClCc0u7Ws/4gM0vB3L98CZbYyVgwl52KpJEfXfp2+Uf4xR3+tmVSMyrIwdS0Ay84ReLpcLzC7cvp1rwzrVjsSObsPXkHrKUj2R7qkhnF4R4VBz1XrZfY8hQzw2Mm6vNeiI1ShnR4atkN94c+zu7aKZTlj98xuhDu1d9q+z4Wb1VTFa0NKLDdjrOo8m/PLb3uw1duqQi0Xz/5tF1Rojq8md1lOSUi1LO+kmLi80nrpwWmt25Y4mu8gP8iu+2iPB5EMgz2X/oIrvX1DbTl6GuD70TsBym3VPHPq36fLWDW71I2dMWO0B7S61mj8UzNbCClA9pOj7X25c+SxRqpEJwh5YQRLQ6hNFwnukAQgeYm0tOeOyIh8Rw2YXvsef5jiI3TFsaRvkzc01ltHdEoGICnKvQ/gRU8ogWYsjMNBpDbLHUbNEYc4UmJOVI2vmXs0oFWctePWPdfmTpWKjj1jG03vI2nDf1C4TpZ877ATwNBQlgLQhxi9ROdc7e8yceAd3SwFXwmD76TPiI7EmWlV7mQVwWKMsZED/FMzPkl51d/BsmTluZYJUVuv/Zn/LnOZ1BgRQm66u7t+qDAGOOh13cI2RqHi2ku6T/vwRGpBioeq8F/vvEEraTLY0+YKVVHVfBHeiTUEnkLNNDWPGgr+zb1IV0S9OItrdeMkB5FdRIYr1HwYjEV0OIXzhKVIfbk3NhxwvcmVMhHkybDn/uJOoyUQFoWkWmvcOMJeltDMWZTkEATILdhR+W3ricp5q/YA2ZuFnInbivEILyKj+RxJxYycINynediPpZIR+He3dDfMaqv81mlUyiuLPhyhe6pv8pZfe7x3psbxZD+aDHiDZYc3zvUBEJLTwFkFGcDJDj4WvXwT1peekuOJ0F0F/xHBuKEyz6fKR+Ek9QleSzH20zlLLkY06mCdH3hw/aUxdhk7e2kCCKGeFP+RqVcNQhGB88l9Uq06MI+Tou0xCSay6hN+z+lKC8h5q8eaizvIp7WwsFtP4Va6yCpNlGr9vGwEy4uIsCyn4u0s1/AsV/pH8GrNvS9PsGLAfCDmGBohCHEZYAOvVXhPGhsA6IZY2Pt8biGhlBCPMuSubmBhFWnWL4EXk72SSNhXWQMqU82YerNWqvrakb1zowtLIXYKSIXNJ3p7iswNUa42ihreA5mEco4oAvzjjGb+P4ftTVodiLEeVhIFLP/y9wu9sB6DtqfbhBuX/OshoC6wfDEKFPv7+oNwA== X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: KOmGU9IGhqroPBX0hSpbulao4SPRPCqMNDZ2qHMyj7u+jVJ0SFDKR7Dk1V4AIIdlOyHS33mg5x7K1B8jX8EsLY/U1Sb5GkrT6u/o/5GAXTNyXHofZ02GsdVB13894kCgOnDJfazwI91hluHeUY/J5SRCuubDzw8R03Ee3lyCo8aST5XFXcvU7Rjnp8geBJy6g9auPgV8f66wt3t2LHCU8TcXxurWUY9c6KWDWh8e0kGCRnZG5Q4UAcufOcXdmZW2A7UcGJG7s6ThpO9ZruHyQLQ4N1DpWz0kobNHSETbIdNgtyjlc9/Z68kJQgfb5dzDz4T4AGV3BupeLFHPt2jJr6lmdnPcm0dMS7kBB5jNCN2SXmjXg8sMCAiZdCJFbgEfBiOQ1ORFG5VQYqAfJmQdd+suD/3WUoUG/lL6q6+fUFVesRC28IOjrBegOE9DcntYe6ml9odd60L3xOitFxNLIrEQsClF6ZSEs1Y3jGBXsrTRsSQlkUd8KbIhnsyDYfvdvs8WN+GVVWZpN18IRb9JZBFHRJJtqYul06y8qW5wtjTSHRe7udORPrC5VRd9QsLEsQ4I0SD/D2BAm3u6vLgbT52VsSvAigKrtaIQW1G8d+A= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 015dfff5-8886-4ce4-5b87-08dcb0ad8572 X-MS-Exchange-CrossTenant-AuthSource: MW4PR10MB6608.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jul 2024 15:37:29.5271 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hdOMWfC9e22ktUBIW/QzpSXDv5g9s/2vBqK6e2CshqMSDhIO0YjC2LhQ1r9WTzduUEjAg/xGtnY03EBz1eojTg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB7476 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-07-30_12,2024-07-30_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 mlxlogscore=999 mlxscore=0 suspectscore=0 malwarescore=0 bulkscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2407110000 definitions=main-2407300106 X-Proofpoint-GUID: 5XHLrabQmMeFqz1gKDCNBOl5PRlWHAFS X-Proofpoint-ORIG-GUID: 5XHLrabQmMeFqz1gKDCNBOl5PRlWHAFS X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list <binutils.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/binutils>, <mailto:binutils-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/binutils/> List-Post: <mailto:binutils@sourceware.org> List-Help: <mailto:binutils-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/binutils>, <mailto:binutils-request@sourceware.org?subject=subscribe> Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org |
Series |
libctf: various bugfixes (including a write into freed memory), and loosen constraints on enums
|
|
Checks
Context | Check | Description |
---|---|---|
linaro-tcwg-bot/tcwg_binutils_build--master-arm | fail | Patch failed to apply |
linaro-tcwg-bot/tcwg_binutils_build--master-aarch64 | fail | Patch failed to apply |
Commit Message
Nick Alcock
July 30, 2024, 3:36 p.m. UTC
The flag test when dumping non-root-visible tyeps was doubly wrong: the flags word is a *bitfield* containing CTF_ADD_ROOT as one possible value, so needs | and & testing, not just ==, and CTF_ADD_NONROOT is 0, so cannot be tested for this way: one must check for the non-presence of CTF_ADD_ROOT. libctf/ * ctf-dump.c (ctf_dump_format_type): Fix non-root flag test. --- libctf/ctf-dump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libctf/ctf-dump.c b/libctf/ctf-dump.c index 80a3b265297..cd41996084d 100644 --- a/libctf/ctf-dump.c +++ b/libctf/ctf-dump.c @@ -106,7 +106,7 @@ ctf_dump_format_type (ctf_dict_t *fp, ctf_id_t id, int flag) const char *idstr = ""; id = new_id; - if (flag == CTF_ADD_NONROOT) + if (!(flag & CTF_ADD_ROOT)) { nonroot_leader = "{"; nonroot_trailer = "}";