Message ID | 20240730153707.168357-13-nick.alcock@oracle.com |
---|---|
State | New |
Headers |
Return-Path: <binutils-bounces~patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DC9B0385DDD2 for <patchwork@sourceware.org>; Tue, 30 Jul 2024 15:41:26 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id D9742385C6CE for <binutils@sourceware.org>; Tue, 30 Jul 2024 15:38:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D9742385C6CE Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D9742385C6CE Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1722353882; cv=pass; b=t9U3Pk1jCG//XRs174hzQJ8OPlX7EL4sWE/HpbNnLVGTUiwke6CO0XMnJI/FoHTH+zF6wyiW7EbIjn/M7RyA3/wWMWpdv5mQf9uA7874kHzJqo1pDBTiB+4pivjekzzYqSlc8PKuth53gtncCohUU8Iayqz8umERgFK2HLCrYcE= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1722353882; c=relaxed/simple; bh=IrM4MqugrqfJsA7ULcfLxQ2LIyytLSrfF5ign2WaOu0=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=Yah96oS9lLISQck7tOhZPgx4/ZomE5hJH50Ju6NLv+bIl84M56ntMRgpxvMpbuM719BbRJ1xDFGjzBnUG8/zD99RMVBRS8B6RYx3y486fw9cokfyus21rDjnw3I1jwhwJckQvMXro4Oz0zAauNQmi3NpXSGA1dpQLhlulfevds0= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 46UFMbRj010418 for <binutils@sourceware.org>; Tue, 30 Jul 2024 15:38:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= from:to:subject:date:message-id:in-reply-to:references :content-transfer-encoding:content-type:mime-version; s= corp-2023-11-20; bh=kXrRNUMg/3j5r6FJPWwA5nnqg34uucbmkOIn7veJ/7E=; b= LHiN9u3XOx5alB/dL6itc0mT7JWUZzh0Y1oMpOg3JGG6OrMD6xiRGVHyKsZOLn5F j7kBjdCBO3XY+ctAn54wzAJuEZ71akhSWubPpCfxoECCyeYRv3RDgnvadM+ZgPv1 ElC+l98RFtPq0Cuf5sVXS180ChOG53AZke5zYT2kUDv2qYzhL45RFxCxMwZ4E+P2 nMbBGnd4pQ3D4REmoGclzJTQ5xOzWTdVjCPomqbzrmJrPhNvCTzmxAJCPQ1mDO9V SYamjYaIkkB1upUi2in9yvKMhcmGrh/h1+27kCehxWVvxYW56mwjp7T/of2EGHeI XIyvqb5iqPGgiwUnfLzT0A== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 40mqtanc52-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for <binutils@sourceware.org>; Tue, 30 Jul 2024 15:37:59 +0000 (GMT) Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 46UFV3lp012341 for <binutils@sourceware.org>; Tue, 30 Jul 2024 15:37:58 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2100.outbound.protection.outlook.com [104.47.58.100]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 40nkh6sqeg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for <binutils@sourceware.org>; Tue, 30 Jul 2024 15:37:58 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Wcgi2mbDvegtjYNRiLZfY8hTYp7SnoBDLyYt1j3JCbDLp5SYRbefVJBGM/OVLRtv/j4vGwnFMt8ELnzCME099OXloNiwn/G7cZO9JV2Rq/SFCOUtm6nDe6G+5sz0ejWbMMC7TNQU9PlNQU09vdmlfmUp7I5h7b8hxf4Gab8TJDSnbcq5XOS7jh7N23QPPLfl3lU+G4/UEI6DQA4aIbfRROu8MWTef7RP+xNdHaN5Wk2ygvtLqTsduV48gdYAwgfi0wlBzg+15Yv8V/oyOf12uhdganNJ0fmiBhms2Uk9mS1ZJbXZF1ELCgcQUNPBjFsnwQsYeQsUNkA+z2bvixKFmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kXrRNUMg/3j5r6FJPWwA5nnqg34uucbmkOIn7veJ/7E=; b=htrzXMGR5k5Tz3WL6lNXs3iYtqWV3viVa/YFHadq3d4I5U6TLdOlpof+V4sTHR3LJQay5FruKqa2aPmxTMDptbtHHUTJdC8Df92loSgRwfGGsQEvbPq+QGjpxNHVUhU4fNbuDi1qsDJTcZa7gMqodz2ljv4uyrnWu7xp9kIh7ElXES0Ms0fW/qjuj/ISCK1gfeKv1dtarv1IaZq32HyJusydjjYmpFo2+ZdBVWlHwLtifrz+Tl2lqkMYjN/Cy4Vip4Q964dZCbRz2j2P2BUb3T8i9QBJe6lieK663Scxu41k3/jwO7QqRJAgqR4Q/Fc0xFIImcD0qkMzzWBCW0wXVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kXrRNUMg/3j5r6FJPWwA5nnqg34uucbmkOIn7veJ/7E=; b=hOUGMHwpT2XwhpIe4M1+aRivTKzIY9R1sFdYaOIfssEx0hcWukP7xbDRN8l397LhoToby8Dw8MThUZLQhN2wQONjfeKRH5seW95+v6ay3HGLEic4SLogNu6arR8ZsEulOAUeNep20qdU8RdJRIE64CdpeIHPB/Qy0yLvksICGgs= Received: from MW4PR10MB6608.namprd10.prod.outlook.com (2603:10b6:303:22e::8) by DM4PR10MB7476.namprd10.prod.outlook.com (2603:10b6:8:17d::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7807.28; Tue, 30 Jul 2024 15:37:56 +0000 Received: from MW4PR10MB6608.namprd10.prod.outlook.com ([fe80::b53a:ccc1:c190:c5df]) by MW4PR10MB6608.namprd10.prod.outlook.com ([fe80::b53a:ccc1:c190:c5df%6]) with mapi id 15.20.7807.026; Tue, 30 Jul 2024 15:37:56 +0000 From: Nick Alcock <nick.alcock@oracle.com> To: binutils@sourceware.org Subject: [PATCH 12/19] libctf: link: fix error handling Date: Tue, 30 Jul 2024 16:37:00 +0100 Message-ID: <20240730153707.168357-13-nick.alcock@oracle.com> X-Mailer: git-send-email 2.45.2.276.g4ac82df17e In-Reply-To: <20240730153707.168357-1-nick.alcock@oracle.com> References: <20240730153707.168357-1-nick.alcock@oracle.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: LO4P123CA0448.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a9::21) To MW4PR10MB6608.namprd10.prod.outlook.com (2603:10b6:303:22e::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW4PR10MB6608:EE_|DM4PR10MB7476:EE_ X-MS-Office365-Filtering-Correlation-Id: 365f17ce-4a0e-49a0-7760-08dcb0ad9575 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: bx4/Nhz4yL7KlppWWqZhD9SXLGCoaqodXXZwmqLSpuZ/ciPhk8O9W+ADuis3q/QvHa/WUUeAzT45p3weciyMqDcVOzZvRPxOW2CroZ+8XE8FgvJOHI3IFVeDlVprkYa+CswemLb9PLGms14ostWWuCxkkkU1LeL73fQJiKDZaQc2Eqc/oxuEswaT8+qSLIP19xvwKXOmjNsXfwfKzH105tn2yqfhVHAIfyjGM38gXllYLfmw5LZTQL0FsnyNl8WZ/FCAPrqnkVlAoZXTSEu/NKfrbyRx3HbO8Zx25RqBSlvNuoZVXq2ljy1HB7mkM13ESp9dH3F/hVyE4uNVwsjXJJ3sW1axGK0byW3oiurj9bKOaHpUZ5gWkzuIQZhmBci8rBts7TGje+Vq1p6X81URibuu/K9fvzYTVhxeMTCHM5R3JEk5qJ2AnPGKgK2xT+Ly60NIdWnY+hiyhbAKcFDBWEDLHZP0ocNfwMewAfbvxYfp6V1aqCoS4TsmW38yUdMxhXKbDkD7OABxZZFMF4mL/kcPtFOwpBrduX72/I6LbheMDgjbwCG6CQ4RIDZ9e72yBHjofpBlbAwuXMyGedn/45Lrexnzx0f9VOcAoUEEKmcsM1j4dGbzE+xgDCBQSL+6rMmdl2kWMXqHHZC2KzVwLzDV1rhlZTbPn2vE/ZcXOeD1QHzqFurBTwq/p7wWkc76zFXSbyBQaYgi3zRsLDZof/WWo0WInzFvbryTdvqiy/ksSbVpQgeusI3C0ezF2NAgqTmdktOlYXn/82LTLjZXJqnP5m6Kz3xjs2gB3lFbYKvWUGbsNPyd0cRrMoP1UFOvizCJbeY6xWvWOzv9MR/cjzJIRZvMoE+jkUjEuxmlpoWMuCQakK/70NhXooajjwmcbw9dl50/EUxjp7C3USMhvHpXSZFSX33FtLU0VtA4uwwbzLHOGdw01I/qbRfbwVQk1NDzaDLM3nL/g70OHFiXo8Ge3MCJ7J6NQT1a+Lz1kMsqfWcMmDhYs00CJcwUxNDAxy542A/CPClNmfH6BJNlYGsUoPhNwixboKbkhxiaDk5lJw7kSa9gMOt/iJgJloDjK69cFPegA8OvZGaRlPTG2ORfJigU2i5XNVhczKxGO/IvVKEp5ulFvGr9tRW/Eis6OX/UBpn8YejVKlnTGwh/yz5Cc2RwXy/BjGWh9w5zz8eOntQBJg15oHFgP91Wj3YmfeP9J69Sn+79NWTQNU2NZMSSNlWPmcvpjw+hKmC4VYX0h9+l+56ac7JGfG/khNqYxIGzXB8SO/ePKX/0uBKP9wzVMFPvkFlE/818xBolkn8DiLYQv9QoJoUywMrreayHiN4NrMDD4lP0dxhpXFAiyA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW4PR10MB6608.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: PRePk+T2nPUn0ePQ6CIYqJi6HKiICmVTJ9hx4z5KCY5o6/evrhZVoGFOHA9KRG31GzN88ZLn7++Cbl+YuHQv6B9QUn9iFBLo2812lVTQ/fn0i5elRjniUUx/dD5VJ9FdvSkP8mWgD20Fn/ym2n2adHGjzQfUStu8SfRX0h8Lf5kYZRVW+xx+OvYeMC2xQZz1cXvrIdiKPwDBgHMe02eGheO2NfseEBWtL8Jt9dcFUR+EHr5NElmwnm/XXkLB8SgLE9JAwCkqV4IkepyLnKbFlHjzbcd2NCfmwmp5rq07TeYuXgCiprrR2oTRyYXLsePECxJ165eXG3vJQNOdO8fyj2O/nVKOPKLFZExhdUDX4aSeRJJsogbuSncu63bq2nY3jCbc1HC9XHIDsUAfkhiEERmKhwMHu45IdKCwkd8oH1OApf7U8+9VA1jZ6TqUn23j+sOKUYB9Z9+jyrF2gF1z83C4t6r5Spku/zo7zVRFKayoOBXPa9gy3u/jsuTgjnvxHXdiPzqzShMhexjEjWPsIMHN9sweclvfjeU1YPH6J9Hy9KhtezekG3g9CW6jsu4Lw4GPtjHcqXEb6XAO5/yb0gtXsJdOhsMi9vAnKqf7D9YyuDhGHvpgDE+exTNVvscmSkLzXP8l+9YydxAw5senVsd3XMJHeVY+dbW9XpOQmggAUxMzabdFnQmVK+ThaL4KX8n88wabJ5oYwprwm1W32/lVSrRdZ5+1nEZFYkjFHM3mJNtsPM2r7K3wMmvwKrlN7MyzJ/5AOYXxzqI9Y9mAt82RC9LkWooQBss4SvSPq7B69wDLfR/W4X0mxS+C7oHQdyIxFcFpyv4F6r689CbEbnP2EUBwy9n7eYX9XwE8R5d/vA1AvtVR7CKv8lar4o+k0R4f7UaHmaX+WBVnS159J59NAwgV8tgsf3wmtsS8mIoaF853xvZdqPAS4uKIhYX0yhSjwNTaXGP49TREzc6glSt/qwrIbg00WyIyJZ/VWCpfAfv6iz2pdRIa9n/A+ezr6hxsSQTekVKPPXhw0v1lIXPs1q3H5TPtF1yc2iNiSWhyQ8+E3DhdalBJvMJfTcDjIGv1XbhP75IjsypRLWrqJez/wPjIlcKI9JOcWVJW48PeeG+SP3455kKcyEApPURZqoC/z+HTFR4xBFqqIl2qvMwDKxDWqPDX3irStbf8TUoW5D5/koGMwOzKUUl7OEJpWs8WqKc5zFwHMH5cxesTDOLlcO+WNDapnluOx8jaTOt/gPpK1AT1x8ETcpfa/2xgLfkOJmUgFS0h3MUGFDNnf4pbIQ7VaYUq08pFMkxLyVQswYGmJ5XsraZeO9ZNcNqDRpZ9FR3B5+dT+7Q4nf3WA0olt8DqOG9i4sjyZH0PcKwrDXrbTwNYf2jq6yqBZCXfIJCENTX4cRN61XbfuQ4CEGdEZGpcGZnVP2g1TeUYYk1g9q6nrHm88SEHpNYhuJQE6NGojguWfeaBtzrQHyDIlBG1p5u1EdilFmIA9itJJDQE3s2XtAEc78TKVSp8+oFbMLRB8aEyMqia5deHexfZGg5MJtXWdVsTN4/eoaoaPvODODPzew78d7j48fAi4nVcqB9rX931bWCTYWNUysDmeQ== X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: TBZMt4FiksPPhogiKDG+5I3aiwH+bjOPh4Y4/YD7BTtOyqgxkb3Q8PB76b8B1wT32TMK4FdpqhPLShGPkVfJFGm/bfFpj0Z9VZ7r2sFOGcTRkULxZmbltryAsp+T9tyynXmp/bFWua2Dnh+3afxhacWcAHhPxGEk9j42Z3T97/ci8BzBfAZzXKvWWj1TYnDw22YZxmTpu80rsh65E2p12OkxmlxlY2VNqfCQPIDsHRW0ide5KerKayR8hw9U/VI/v4VHZiAlbUkLlsqoc37RZapFyErZbObXa5se6eYF6F8DfaRXknZftB5c4e3pwbxYYGXfdEqCNAtmCBmN7EJPGKY0QRNqfdSQgGjFwgV1Tkj8O8OraMGU5htTqNW1JxdLVmEZwBd9Pv/kIGGRqDPF87l6qcetNL7gUooAPOHGS0xVyOMXRl1aoE1nJ38+mGZPRo1U8wVBcHMg7Q+cjnnJ5tuBGIRDaCb3Un5ltvz0WMk0juEBA4L6SUAaQ16XeSnwlED5s8V0mE1afXSLyJc3CFxrECr8GKnw1peTKgwX7vOPSXc5ixxUOHL9GG0Zpz2n3QRZHBdd3aFx+OSCxjqXmcm4m+8JeZSJ8ng/Zt547zE= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 365f17ce-4a0e-49a0-7760-08dcb0ad9575 X-MS-Exchange-CrossTenant-AuthSource: MW4PR10MB6608.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jul 2024 15:37:56.4006 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lRancBZbDq6a9pvx9L3J7elKkIUWbl8aM5l7Y7W9TQyaN50eitXMSINACI4/wNe5C4FyV1+XevovyC3tRcbKXw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB7476 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-07-30_12,2024-07-30_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 malwarescore=0 suspectscore=0 mlxscore=0 spamscore=0 adultscore=0 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2407110000 definitions=main-2407300106 X-Proofpoint-GUID: NrGxqiP72cVp6NHd_SoghIa0h_VwQJj- X-Proofpoint-ORIG-GUID: NrGxqiP72cVp6NHd_SoghIa0h_VwQJj- X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list <binutils.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/binutils>, <mailto:binutils-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/binutils/> List-Post: <mailto:binutils@sourceware.org> List-Help: <mailto:binutils-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/binutils>, <mailto:binutils-request@sourceware.org?subject=subscribe> Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org |
Series |
libctf: various bugfixes (including a write into freed memory), and loosen constraints on enums
|
|
Checks
Context | Check | Description |
---|---|---|
linaro-tcwg-bot/tcwg_binutils_build--master-arm | fail | Patch failed to apply |
linaro-tcwg-bot/tcwg_binutils_build--master-aarch64 | fail | Patch failed to apply |
Commit Message
Nick Alcock
July 30, 2024, 3:37 p.m. UTC
We were calling the wrong error function if opening failed, causing leaks. libctf/ * ctf-link.c (ctf_link_deduplicating_per_cu): Fix error handling. --- libctf/ctf-link.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libctf/ctf-link.c b/libctf/ctf-link.c index 42b2911e4f2..7b68d709628 100644 --- a/libctf/ctf-link.c +++ b/libctf/ctf-link.c @@ -1221,7 +1221,7 @@ ctf_link_deduplicating_per_cu (ctf_dict_t *fp) &parents)) == NULL) { ctf_next_destroy (i); - goto err_inputs; + goto err_open_inputs; } if ((out = ctf_create (&err)) == NULL)