diff mbox series

[v4,01/15] x86: Remove unused SFrame CFI RA register variable

Message ID 20240624142334.3283823-2-jremus@linux.ibm.com
State New
Headers
Series sframe: Enhancements to SFrame info generation |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_binutils_build--master-aarch64 success Build passed
linaro-tcwg-bot/tcwg_binutils_build--master-arm success Build passed
linaro-tcwg-bot/tcwg_binutils_check--master-aarch64 success Test passed
linaro-tcwg-bot/tcwg_binutils_check--master-arm success Test passed

Commit Message

Jens Remus June 24, 2024, 2:23 p.m. UTC 
  gas/
	* config/tc-i386.c: Remove unused SFrame CFI RA register
	variable.

Reviewed-by: Andreas Krebbel <krebbel@linux.ibm.com>
Reviewed-by: Indu Bhagat <indu.bhagat@oracle.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Jens Remus <jremus@linux.ibm.com>
---

Notes (jremus):
    Changes v2 -> v3:
    - Corrected formatting of ChangeLog in commit message.

 gas/config/tc-i386.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Indu Bhagat June 25, 2024, 11:56 p.m. UTC | #1 
On 6/24/24 09:13, Jens Remus wrote:
> Am 24.06.2024 um 16:51 schrieb Jan Beulich:
>> On 24.06.2024 16:23, Jens Remus wrote:
>>> gas/
>>>     * config/tc-i386.c: Remove unused SFrame CFI RA register
>>>     variable.
>>
>> Nit: The more "canonical" way would be
>>
>>     * config/tc-i386.c (x86_sframe_cfa_ra_reg): Remove.
>>
> 
> Thanks! I am still learning how to get those GNU Changelog entries in 
> the commit message correct. While this series evolved later added 
> patches do have the function names. Somehow I did not consider to reword 
> them all.
> 

If it helps, you can try using contrib/mklog.py script in GCC upstream 
for your future patches. The script is certainly helpful to get a first 
outline of the ChangeLog text.  But it does sometimes mis-attribute 
hunks to entity names, so double checking is necessary.

That said, Changelog entries in commit message in Binutils project are 
not mandatory anymore. Its just that I find them useful and I appreciate 
you keeping them for these SFrame patches.

Thanks
diff mbox series

Patch

diff --git a/gas/config/tc-i386.c b/gas/config/tc-i386.c
index e94b93701552..343848ad052d 100644
--- a/gas/config/tc-i386.c
+++ b/gas/config/tc-i386.c
@@ -639,7 +639,6 @@  static int shared = 0;
 unsigned int x86_sframe_cfa_sp_reg;
 /* The other CFA base register for SFrame stack trace info.  */
 unsigned int x86_sframe_cfa_fp_reg;
-unsigned int x86_sframe_cfa_ra_reg;
 
 #endif