mem: free the allocated memory
Checks
| Context |
Check |
Description |
| linaro-tcwg-bot/tcwg_binutils_build--master-arm |
success
|
Build passed
|
| linaro-tcwg-bot/tcwg_binutils_build--master-aarch64 |
success
|
Build passed
|
| linaro-tcwg-bot/tcwg_binutils_check--master-arm |
success
|
Test passed
|
| linaro-tcwg-bot/tcwg_binutils_check--master-aarch64 |
success
|
Test passed
|
Commit Message
---
gas/config/tc-bfin.c | 2 ++
1 file changed, 2 insertions(+)
Comments
On 19.06.2024 09:18, zhangxianting wrote:
> ---
> gas/config/tc-bfin.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/gas/config/tc-bfin.c b/gas/config/tc-bfin.c
> index cbf09037e48..001f90c045c 100644
> --- a/gas/config/tc-bfin.c
> +++ b/gas/config/tc-bfin.c
> @@ -1919,6 +1919,8 @@ bfin_loop_beginend (Expr_Node *exp, int begin)
> Adjust label address. */
> if (!begin)
> *symbol_X_add_number (linelabel) -= last_insn_size;
> +
> + free (label_name);
> }
As indicated in the earlier reply, you generally want to Cc respective
maintainers (now done). Catching their attention may also be helped by
having the architecture somewhere in the subject, e.g. instead of
mem: have it be bfin:.
Finally, just to double check (in particular with the earlier version's
apparently wrong freeing in mind): You did run the assembler testsuite
with this patch in place, and without finding any (new) failures?
Jan
@@ -1919,6 +1919,8 @@ bfin_loop_beginend (Expr_Node *exp, int begin)
Adjust label address. */
if (!begin)
*symbol_X_add_number (linelabel) -= last_insn_size;
+
+ free (label_name);
}
bool