From patchwork Wed May 8 13:22:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 89776 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 25E953892442 for ; Wed, 8 May 2024 13:22:56 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by sourceware.org (Postfix) with ESMTPS id 9E93A38708D6 for ; Wed, 8 May 2024 13:22:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9E93A38708D6 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9E93A38708D6 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::435 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715174546; cv=none; b=JummTzQABGcbXLZmznwQZe8bjzg4q0KajK8F+bznK0lwndlnmQ9LdAoHlxH2e76xa7g7chWPVZX7tfAOL+kaZoYOSBoSn3Jlyc7FLfUl0+p+/TZkM7yKjTl7L/xhD6/XpdZMc6KGi/xAqHEnLxNy6MgCWROMlCisHVYUys4sdEk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715174546; c=relaxed/simple; bh=kHvKe/G5D6hFZIK9F+AcA7gFWb8KJ/GvXBFhSm2iEAg=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=cXov/z7vcEJv7Hqus7tx7aANm1598+9LRmL3u6xeDpSPdCfrt/Ycp2Y9LiiZn3eAZqonUuVvfpsIe5tQBWGLDnoeK3efKewG2A/8EHBWmaUWxYFr7TvZkeoEi/hfaxywwZwEnuzTfJDu/WGVomSex0SW17wQlgkVPTs4WIjSWP0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-6f44b390d5fso4099230b3a.3 for ; Wed, 08 May 2024 06:22:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715174542; x=1715779342; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=C3atUiNIKSG/zDEfUoAetWTp/vHfPOC6aTFd7wZzTR0=; b=HRrG5/IJeiky7+OZDCxWlrDPDdO2tFMc9QwvlVF0MsAYDbC7yOkYhTQXHTrojKmx+p ulRJTFXkEc+Pb8LgVPfkGtdRncmoZuHe4WsbbeZfJTmyKZ5vcCVRbUt+djKOe6PZWIEa n6n1LzHNJxt9LplwDzLfjwPeC331+H5vG//SjWaogZj/g1JawJz0hVzNkfg0PecqvRPX tOBzb0adjxdLeCKOhnuiAX5lDFxHV4e0pxRimLxsFVhDQUHErn5bChZUXSpxwMXV5uP2 XmZ68YM0If1+kWmPtI7PntGJu9WpunCRGoxZ6jFhtN3KKxp+R081FRXdOmgq0GpT669a npNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715174542; x=1715779342; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=C3atUiNIKSG/zDEfUoAetWTp/vHfPOC6aTFd7wZzTR0=; b=rYPqo09MNGznCL5dmdchcuhVg8hBqQ6k0SeW3yDXNkazeEfZO/YSZRs3Jk/FGbWsp4 I+vJcfYloSk9ySXB7AqlNz33JENqJLfNZIxwc8O7q1NWv95IpVM8RJOJqb5a2vH0Mrtf EBhiQVbunW68tGUl6AR311x51MmbCS3AUdyizRi4kH6bCFCMOnIDGoxMVY3zcL9MdTQB 0oMroYKgXuzagsDVFxP/K7pJvBDMpDo/q4tnPA+eUDPTC8UF9gb/DK7yb4SxpErSqyFt Xh6RIIiV3Hsu3xSAfkV2GVA1dRhS+gzkDvtFoR5GopXKv8RSKTg0IITd9d3ZmKA3KEm7 u8xA== X-Gm-Message-State: AOJu0Yw9nlCZQXHZs7jOH9sLsYKILKs3SyDdz87QYuSRO6JJjpSdLyaQ xxGVjCbv8wzY5sV+Pv0yk/V7WYJpT/EFcDMaYRZN5B9p5xcWlrPI2BFQsw== X-Google-Smtp-Source: AGHT+IEi4h/FdmMiIr4/tk1XVgSHLyPPdc2ZJ3FJe25OVCstTPcgmQDjO9DeKbOKR0Yc3l8oPB5N+g== X-Received: by 2002:a05:6a20:9786:b0:1af:b86a:1df3 with SMTP id adf61e73a8af0-1afc8d26d58mr2686219637.18.1715174542116; Wed, 08 May 2024 06:22:22 -0700 (PDT) Received: from gnu-cfl-3.localdomain ([172.56.168.158]) by smtp.gmail.com with ESMTPSA id ei47-20020a056a0080ef00b006f40cdb63fesm8258046pfb.30.2024.05.08.06.22.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 May 2024 06:22:21 -0700 (PDT) Received: from gnu-cfl-3.. (localhost [IPv6:::1]) by gnu-cfl-3.localdomain (Postfix) with ESMTP id 95BE7740151 for ; Wed, 8 May 2024 06:22:20 -0700 (PDT) From: "H.J. Lu" To: binutils@sourceware.org Subject: [PATCH 1/2] ld: Run --wrap tests only if supported Date: Wed, 8 May 2024 06:22:19 -0700 Message-ID: <20240508132220.3809117-1-hjl.tools@gmail.com> X-Mailer: git-send-email 2.45.0 MIME-Version: 1.0 X-Spam-Status: No, score=-3022.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+patchwork=sourceware.org@sourceware.org Run --wrap tests with shared library only if -shared is supported. * testsuite/ld-elf/wrap.exp: Run --wrap tests with shared library only if -shared is supported. --- ld/testsuite/ld-elf/wrap.exp | 34 +++++++++++++++------------------- 1 file changed, 15 insertions(+), 19 deletions(-) diff --git a/ld/testsuite/ld-elf/wrap.exp b/ld/testsuite/ld-elf/wrap.exp index d24c1e7d7ce..90e2d60e67d 100644 --- a/ld/testsuite/ld-elf/wrap.exp +++ b/ld/testsuite/ld-elf/wrap.exp @@ -25,34 +25,30 @@ if ![is_elf_format] { return } -# Skip targets where -shared is not supported - -if ![check_shared_lib_support] { - return -} - # Check if compiler works if { ![check_compiler_available] } { return } -set build_tests { - {"Build libwrap1a.so" - "-shared" "-fPIC" - {wrap1a.c} {} "libwrap1a.so"} - {"Build libwrap1b.so" - "-shared tmpdir/libwrap1a.so" "-fPIC" - {wrap1b.c} {} "libwrap1b.so"} -} - -set run_tests { +if [check_shared_lib_support] { + set build_tests { + {"Build libwrap1a.so" + "-shared" "-fPIC" + {wrap1a.c} {} "libwrap1a.so"} + {"Build libwrap1b.so" + "-shared tmpdir/libwrap1a.so" "-fPIC" + {wrap1b.c} {} "libwrap1b.so"} + } + + set run_tests { {"Run with libwrap1a.so and libwrap1b.so" "-Wl,--no-as-needed,--wrap,par tmpdir/libwrap1a.so tmpdir/libwrap1b.so" "" {wrap1.c} "wrap1" "wrap1.out"} {"Run with libwrap1b.so and libwrap1a.so" "-Wl,--no-as-needed,--wrap,par tmpdir/libwrap1b.so tmpdir/libwrap1a.so" "" {wrap1.c} "wrap1" "wrap1.out"} -} + } -run_cc_link_tests $build_tests -run_ld_link_exec_tests $run_tests + run_cc_link_tests $build_tests + run_ld_link_exec_tests $run_tests +}