From patchwork Wed Apr 17 20:20:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick Alcock X-Patchwork-Id: 88601 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 86BED3847700 for ; Wed, 17 Apr 2024 20:23:55 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 739353858D20 for ; Wed, 17 Apr 2024 20:20:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 739353858D20 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 739353858D20 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713385261; cv=pass; b=MDacF9Ufl0aGi54xZqP4pQQ2QaoI2OwPu2GUUandVLI4tXUI07tXPbnBt1jOkNuu2mh2IJOZ3LbvGnvKdDY3kTvDltNjmgtI6U9xK0am9zuLQQZNN+O1B7NJx37LJas0KNVjHYf7a14xbVFAYZXw8aznFgZEYfQML57vzvt+8Qc= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713385261; c=relaxed/simple; bh=OabvIxXZ4bHeepnWTfSt5NsdauUpPxFM9FsoJdNS8nE=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=WhsuTWH626T4WlLvx+wM551BQCPMMaA7VR5YsYVt++kOdn8tB3VQ56MhYLq/NrtrFV7QzIvwuKseZLU9RJ2Nb0CjwqiWGxecqkYX5KA2FDzYvbadHtiufVqNDV/5Hi08qd0W47Im3lKs0XxaIeLRzeS2Ab5ZKPKIH42TFuJvOSk= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43HHi1tO008975 for ; Wed, 17 Apr 2024 20:20:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2023-11-20; bh=2/2lR9dgUOo14pkpVsq9WG8t++9VIy7uXGw0qgxTqxE=; b=Arq6jwspYPOLTWDlireo1vhuUOF4uTlsRONLKSDuU/eEyRbI93ctLvtM6/IoUQ6jSTDy XRJzduMp2/Mb/RYX84Lw8fHGZkS8mcLNGYUmIZrlAJxqfwaYGKLnV2QN6l9ov25W1cxF JFRYXNI13qBpNPfv0alTsgAcml8IHifzcsSihidbiHAOruHDkYDPLKt+OyMUHk5KGdAe CC+G8OlbkfSaBt6L2WCuxV3ed/eG5M5IGTLheG3FgvRMPCFQ30YuAnYjm0Q2XFpcdfmF YoElnAwEXRlslIX+e4vrnrxBBSAvfqArlsTwxf1f8sp9GJEcIW7b+o/aNverpBHVC5Ct iQ== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3xfgn2ruqc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 17 Apr 2024 20:20:58 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 43HJ5TqS021596 for ; Wed, 17 Apr 2024 20:20:56 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2040.outbound.protection.outlook.com [104.47.66.40]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3xfggfpe5c-3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 17 Apr 2024 20:20:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l1v/1rx8xBbjKlRUw7msUAjmv3ScAj1OAwgXmLjMl2KS6VRsL3TUJbB32yuYl7pEUpDdO0RrQIC/oILLCcZfA/J/0iok1IZw6I66tOIbQiqYgR8Y8ut8DurNHdORZKTgA5pvEpQCiDrnqR2vsLmNWSWkeCBT7JlOOh5Qz7imKurIJHmecVTuAjosmr+robrI5wm67Cw3yFHnRquX/Z4IJO41GyYSqorz8DKXYtJD9tO9oA3Qmo0aOX95fldt3ElcaRpjmeE2REMkKC0mijsQxubjW+bi2aTdaC8mhS4WlM82LwI2+cINVKov/4WuyufxmpQn+QyGP9SIDkjpka7AwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2/2lR9dgUOo14pkpVsq9WG8t++9VIy7uXGw0qgxTqxE=; b=IG7c3EYO5H2Y3nUcEU8DHCUWqRVf+cSe3SxFq00tYRwET+7I0KMZLuniIIeRxsnJncAcHf9D3lJ2BQp8fdC3gWHtSE+2e4JW8/RGLL2ZSaEC2iu1W/990jZbQFLQ7G/twEyIfgijTFZMgy8WV4HGvGPktXmjSfyaD1HbMJs4P88FAA/DdnLxSpdA6dMYs1/GOHvbM4zt8SaO7r5iES3B0FiECyiObQESuNM5YQLf9R1Ql/fvR/C7rHLrDZ+K710AVA9Ry9gZeFyygmmrjPZIcx9v8SAggw87s9czJwA32EUa8hJCIJPExwAFU4Aeo+nePpn35OE5PEMAO7uB1uzHhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2/2lR9dgUOo14pkpVsq9WG8t++9VIy7uXGw0qgxTqxE=; b=W2lVHnLYf+wlRFPOafgB1SxWW1BFGazgKIzsV0ikANFgOWnHypNMGLL5yUBFvWGL1Gn4gzKYRMZSVLPhR4lLcpdBpmm+W4Ev1DqjABoYWxJh8+xHXT5hYUI76NgppPYhR4lRCPLevpNfwUofPGh/Tn9O/p09SUsQqOgZeCkdfzM= Received: from MW4PR10MB6608.namprd10.prod.outlook.com (2603:10b6:303:22e::8) by SA1PR10MB5821.namprd10.prod.outlook.com (2603:10b6:806:232::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.50; Wed, 17 Apr 2024 20:20:54 +0000 Received: from MW4PR10MB6608.namprd10.prod.outlook.com ([fe80::67a4:9544:7249:7751]) by MW4PR10MB6608.namprd10.prod.outlook.com ([fe80::67a4:9544:7249:7751%7]) with mapi id 15.20.7472.037; Wed, 17 Apr 2024 20:20:54 +0000 From: Nick Alcock To: binutils@sourceware.org Subject: [PATCH 06/22] libctf: fix a comment Date: Wed, 17 Apr 2024 21:20:02 +0100 Message-ID: <20240417202018.34966-7-nick.alcock@oracle.com> X-Mailer: git-send-email 2.44.0.273.ge0bd14271f In-Reply-To: <20240417202018.34966-1-nick.alcock@oracle.com> References: <20240417202018.34966-1-nick.alcock@oracle.com> X-ClientProxiedBy: LO4P123CA0528.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:2c5::10) To MW4PR10MB6608.namprd10.prod.outlook.com (2603:10b6:303:22e::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW4PR10MB6608:EE_|SA1PR10MB5821:EE_ X-MS-Office365-Filtering-Correlation-Id: 10836b01-62f4-4280-2a44-08dc5f1be238 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QkckpFBvT7fY+32aAYTdFuQGKYRMGeExUy2Pr9/Pk6VMsb8eG6BdvxE0QKq7HwCxtb/0O/1C5MoECU97Z9BtwjxLFg1ZH3lVMXwu85FIVwd6wjnkbQUb3LbSoV/nIdqjr5ocLmt9Gr9Wy99qKdbVTCsNIYsLcMLXroEh35Ks9Ta+NFtYaPLtOOovF1CweTmrtuwZjZQStzbqAhDvAb7fw3INalZw+VufOQoaG8t3S0c5XQk4bLNqH/7isHkcJjOCwkYoJjYw5jx3/wkz2jfav40ewdRiyoZ4e6XLir+UI6RmpJJbRh4esK+IINahhbmRJmojF5hj/5CbFdxhAhtVusa9lVe7OOJvX/aGJlC4U5T7PRA51OJzXQ0aH52NMkPDv/qm6U5tVtRb/eYRuI5+6Uq2Ez02klTct0uVQnyvEwLFDUxr9DgyMLXpE7hSHJR2M7CkN8xeP+FnNBJDI3wxok8IL8Nq/E3KttDCWDRiNv8HUPKLCDmLeYrpSg5dSiR2QC1o4Rbf3ICzzQb7ORw6ZwtCu0diDRYpmJnfwgzpmCCHzczkTKaDDgYw4DhI9XekkYG6PfGob1EszBjhZGxlWDlSRqUGuKWFXuVbHhmfuwImrIZuZmd5BmYm8eR1SZjM3rwpx5yG7sFB3TLOhboECAsfeti0z+0o3J/5BbfadEg= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW4PR10MB6608.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(376005)(1800799015); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: NMogv242CLljweu9xO9tEHYDlhoF1O3UOAb8aQ07jHsMW/9yUC49rDOXD7lOQuKn+y+xVuVJ6ks3xOc/7CfOgptOpvTjh6uXmBegm4DY5dPLmiCE6KTE/6Hn1mbJAMNFi0a0iAGe6/gpaM81NFhLPi3eWhDUqp0T2RdFnLdafJLHict/JRFLGvCYBB24mA2kHQR5kE9e310whfPqkB+jOwpbqlsH0j0qFCzF+kJ1rj1koRR8O5b7HBcwvTUG/Sz9MsA7NC6dyqyDNnfZmmk/xleIoAQxsJWX+vqeITAfCVOGtK7V+M7VQCVEMAYUF/vqxNPp0FnebXa58FWe8Wz/uJ6QqTiUuGOLXepeTYUVOfQC+z1cgzEDsToPDCjfv/CUPsC4r67kYO2bW8cmmJ3b0XoGDKXjUgKsamtpXaXMhadtx92sHQ9L57jA90uxhxptOVw23qVchGXx2gprSEaXY2jgV7xrjNQOhPvW7Xm9oDz9ofIHn+qqzpojnMf9in8ivcsB4Uznq+p3A5rotM1rIENJXkz7lUBnIum1FbpWCZ2fDUXx1yvyWrq1GgzLSHTULk3Xmz3CqPQOaqEJjMrFUVtPWYYEDNZmaWYBI4l2xNl2LGVqaL+R0uwK9NRBQjvC5bLkjMPRYW1AmAcCw5TQXjQCl1w/1Z2u4+DKgJgFVpSVUl5KKJ6uRF698qC/Aew37E+/wtFQbOd1qSW1N1I+W6tfkzbEUAnOkmtY1DglmQ0UYx9mP6PjH8GnhvnHJTMo+NBWbUbDYpL5yrVjIakyWSjRv2qTRr4He/UqDUdGLYJx8wQ67kKZEKNw6Hd7D4JJcBLo6toUzASjWLwUY2XMj9b0q2o6shfz4llHNHeliLN1fKRLWnrKQ/0/Je8Eumaw8EFIi0JoKlZ3jcOrnuadqD+CZ8EGnmLY5gxGMNEwzvr9oq2SCuamj0636COAox5Y/1HxlcRWZBOO9z5NtELTvP1kstE93547Ded9wq9sAPYRRkFFaFdpdctYTTXB8y/NitWMgNLRqNYDsnnJxWDqsodYbNuCqPzbIuBK6djCBqYIxZjLNSKEA9TWsxjqkZaSFCH4Lk/pGeOeW+jmqqqHR6u4HL8dp8DsDshODv8VVCjVIuaO2dSH9Yq0RpwZkzbsJVJzknOfXjLAPUTc6zfe+97zL1hTzpua4quVKdkofIUUYlo3gckX2HfP+mFtEtdvqvh2Jnq4T6bgi0R2IxoNvIdMdUj4ufeCnHb6Ue1hfZ2TNR88bk5aEc85lHCgFqZ7skPkt9Scm34/f54bmevwJSkkEALesquUNHFLc738wBW5DdAKcUudrSCri/KmRZPPTlduBzHGx6xJ/J7ebuXAjhVFpwl3bsdmlKa5WMB3jKU8b1GOWKNhDZt2dT47yeTfWyqpUKsn5gWZlEGDaNcnnfYQdxKFHAyghc9DtTX6vQDghGzx2AxRMDcIr+wu8msvuYHH4j3V6ggncIE1iu9udV49lHCIStT2lFNUSO/8UrXpmL/jCwGlvlG/f17e5mILvXVUtbDOPzjgd+AKerdwvxn8sbEQJ6DFW4sbTnziMGU/AN28t36bEsrCtGJWNvycZDAfD3OiN8MiOc16flAfQw== X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: /fq1phst3VYHYvdjqez0TSaEOZ6orHzA64qOufvym8TwpXMre4KfV3V0zLI+BZZxaElXgRSAARLfL//8IAsoweY8gT5wKKd4+JHerNo5pklqTiceb4ApMe8gBeTWubZaYZJOKOvE0AeX87VWk168R0f1gcbxDFGECRtPl0Lnx0q65iNox1wKSeXS2NU04KeOJdZflmSB0FNyh9utUWPAFW5EgzijMfoJpNMleYk+XnUn9Tb1mC8tQX8yDpqux5kw0aYUxPp6KpTNnosRb4K0esAmyUT3EGpO8CVU3RvcTXz5v1zwlUd1txVuUXkCy7GI7oUeCncSHQS4thKUQRAvCmoRD4I70msjyjfrXz+dGI8zBJWXKgWY2r9+WWwcU6BDy4ZjRlxxCv5lcwzm5T12HOw6X9uuezjrTKrjlWgDHXqODV1pmyZju/1vu+twtY2Q58/ZadcdyXnNMZy/cKymmj+S81AONbZpLkysn33dWuq74JTRE04OLL11qrorfvK5Su3vSDLjlzwzcgMcmNLCtmWaZGZll0KKE6HCAU6Oh7OCQPqBfTrdDa3+QMGaxEXqGWWb3c8dZJ8ZngkyluxGn06D6BJpvgDDj4hd7sa4Lzs= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 10836b01-62f4-4280-2a44-08dc5f1be238 X-MS-Exchange-CrossTenant-AuthSource: MW4PR10MB6608.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2024 20:20:54.4676 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FogKc70Qljjgp5h03WfT1g3aQQHzXBC/hAfPk9Wliij/F544EeinyWrCPXCy3gNpowV7UQ4jzz+BswDjeYfOLw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB5821 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-17_17,2024-04-17_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 mlxlogscore=876 suspectscore=0 adultscore=0 phishscore=0 bulkscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404170143 X-Proofpoint-ORIG-GUID: SOcn_MspPJz5AYZ0XjqIPb6oRwj3WCBl X-Proofpoint-GUID: SOcn_MspPJz5AYZ0XjqIPb6oRwj3WCBl X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+patchwork=sourceware.org@sourceware.org A mistaken "not" in ctf_err_warn made it seem like we only extracted error messages if this was not an error. libctf/ * ctf-subr.c (ctf_err_warn): Fix comment. --- libctf/ctf-subr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libctf/ctf-subr.c b/libctf/ctf-subr.c index a21048d0032..ecc68848d31 100644 --- a/libctf/ctf-subr.c +++ b/libctf/ctf-subr.c @@ -225,7 +225,7 @@ ctf_err_warn (ctf_dict_t *fp, int is_warning, int err, } va_end (alist); - /* Include the error code only if there is one; if this is not a warning, + /* Include the error code only if there is one; if this is a warning, only use the error code if it was explicitly passed and is nonzero. (Warnings may not have a meaningful error code, since the warning may not lead to unwinding up to the user.) */