[v1] LoongArch: ld:Report an error when seeing an unrecognized relocation

Message ID 20240402014135.3018276-1-cailulu@loongson.cn
State New
Series [v1] LoongArch: ld:Report an error when seeing an unrecognized relocation |


Context Check Description
linaro-tcwg-bot/tcwg_binutils_build--master-arm success Testing passed
linaro-tcwg-bot/tcwg_binutils_build--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_binutils_check--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_binutils_check--master-arm success Testing passed

Commit Message

Lulu Cai April 2, 2024, 1:41 a.m. UTC
  If we generate an object file using an assembler with the new
relocations added, and then linking those files with an older
linker, the link will still complete and the linked file will
be generated.
In this case we should report an error instead of continuing
the linking process.
 bfd/elfnn-loongarch.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)


diff --git a/bfd/elfnn-loongarch.c b/bfd/elfnn-loongarch.c
index 952c42d3de3..d4be75b7754 100644
--- a/bfd/elfnn-loongarch.c
+++ b/bfd/elfnn-loongarch.c
@@ -2608,9 +2608,14 @@  loongarch_elf_relocate_section (bfd *output_bfd, struct bfd_link_info *info,
       bfd_vma relocation, off, ie_off, desc_off;
       int i, j;
+      /* When an unrecognized relocation is encountered, which usually
+	 occurs when using a newer assembler but an older linker, an error
+	 should be reported instead of continuing to the next relocation.  */
       howto = loongarch_elf_rtype_to_howto (input_bfd, r_type);
-      if (howto == NULL || r_type == R_LARCH_GNU_VTINHERIT
-	  || r_type == R_LARCH_GNU_VTENTRY)
+      if (howto == NULL)
+	return _bfd_unrecognized_reloc (input_bfd, input_section, r_type);
+      if (r_type == R_LARCH_GNU_VTINHERIT || r_type == R_LARCH_GNU_VTENTRY)
       /* This is a final link.  */