From patchwork Wed Sep 20 23:03:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Indu Bhagat X-Patchwork-Id: 76469 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AC5A03861829 for ; Wed, 20 Sep 2023 23:05:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AC5A03861829 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1695251108; bh=dOwsvRBUEohtc/DYmyQD6GbGqcT1f0d7CLPyVEDubZ8=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=Tuu8leZWvlvV3PIhRsS6SjcRT9DRy9NB+wlX8g3MoOjofUucLl0ScGtSpO0LCkSsV +W5QE2/bmoulaZrgxjLbURYqI2b8jZxgMbbzu9AodlymNsLVFsK823RSe0kyfu71ae BmCJIr5l11+N2MAtY5Gq/tWGjNb+Lu+OnzDuYpPQ= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id B26643858418 for ; Wed, 20 Sep 2023 23:04:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B26643858418 Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38KKJ7jA021215 for ; Wed, 20 Sep 2023 23:04:33 GMT Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3t53yu8gjm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 20 Sep 2023 23:04:32 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 38KL6vwK030994 for ; Wed, 20 Sep 2023 23:04:31 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2175.outbound.protection.outlook.com [104.47.56.175]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3t52t7r7kc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 20 Sep 2023 23:04:31 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=avWD+yL8MYnX5Ts2iVc4pR+ckD2InaFrgKRW0SINjQrJsXjJVZR25QJ0yZVnx92cxEV2KS/Z7WBjrZ0RY9EUCo+ctBpAwnwkItTmD0kFykMCIYFuhEwTepHkqGTmTzeFWibwXP6bAXS+PrbLVLGpWhuEz1nQCXadGebmrTjG22gCXN/R1lD5ROQBWpievKkiqzqOvCHIW3Cz2FdCiuECwd+5zTPD07dOGr5Xsw+YkPiEwCrfm4ovYEaJupllh4GyHGcABGobYxDEz84V0Gv1/QjYvbZ50oSK/8KAgp3nlVY2qgcQvWydt/5YmzsoD80zdsP+IbZDf3qruCIKJxytBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dOwsvRBUEohtc/DYmyQD6GbGqcT1f0d7CLPyVEDubZ8=; b=P//4uhCl+qvOhMiBOpsEilVxQDkL5vPe+OqYZy6Q6mn5tBwzXA02Xi4PYLZlTCNQ3fNXFKlSLEvR/phONuhT0ftNpslMjC6q3J1NP9lrvW06q2mGFZpiD3HCMjI5KPYNLOzBoUMTjf9I/jQxOVG0+Xy0+cI3FVxQ1zdNuK+2xFVZpbolfxtbTdqTlnQTJiWkYoHz2YxB83Be4WrXiuEB+P6OuTLP3vfM2G1NJNtLgkcZMoDQLM0ASZnue9EZhGx5jzPFTWdcdUf8xGwe/RN9lwZ4844CTscKYYpbKYHjiUnz/5J0fVCjsN3rTWCenjD7yKutDj1cD12BixPzgSNcpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by CO6PR10MB5553.namprd10.prod.outlook.com (2603:10b6:303:140::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6768.38; Wed, 20 Sep 2023 23:04:30 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::44f7:ba76:db28:606e]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::44f7:ba76:db28:606e%3]) with mapi id 15.20.6813.017; Wed, 20 Sep 2023 23:04:30 +0000 To: binutils@sourceware.org Cc: Indu Bhagat Subject: [PATCH, RFC 2/9] gas: dw2gencfi: use all_cfi_sections instead of cfi_sections Date: Wed, 20 Sep 2023 16:03:54 -0700 Message-ID: <20230920230401.1739139-3-indu.bhagat@oracle.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230920230401.1739139-1-indu.bhagat@oracle.com> References: <20230920230401.1739139-1-indu.bhagat@oracle.com> X-ClientProxiedBy: MW2PR16CA0018.namprd16.prod.outlook.com (2603:10b6:907::31) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|CO6PR10MB5553:EE_ X-MS-Office365-Filtering-Correlation-Id: 5faf6575-9738-4272-f9aa-08dbba2df219 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KBUwiaWGt9cRC73eb6Yni5belY4EN8RLMC8C6mITpW1YDX6xxvLG8O4tCNqhJ74kRpPqqvK1weeUsBz4dCX/eRuvC/0fFu0bZmJ3kKqTxYD4EiosVFjJjA/O61rECuELT7hTOIX2fPHlfXEU8dzkmlh50X4np3PhGiFQ5yDLkKAyOlKKmRclrZJvGV4jzy8EW6pE8y62291fquMCDnQIvFI88Pidq0mTXK9bl2y1el3tlM2Gdbk0JJm/zj1MXbI7efYpFBgAEN3RsL0KpkQMIkFFjokBoOE4aKkguDEs/7n8ku3sS3enUPChh/n9+mDq4NIQE4urIO8pyJTZvlGbJIcHpFVfzyC35W5qPvtN/CvPmsxn5qD3axOMErGRIfJcWClPrWxbi6Q6Wi0QGyaDUDvjlUjhdCkUOp271nAkYIX493qrpWY0mMjbayGWgI6ThKkctQdDGGbrKkamrKD7EhQB3qur3vnaUk6sUsMN3IG/9v+HR8SkeJV+dPF5ZZ/hIBzXIJev+9DXABOg17hhFxHEkG0z0x0gJ9ktgMWuN553NHdr4MjTfZ+DcJlLQL9V X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2158.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(376002)(136003)(366004)(39860400002)(396003)(451199024)(186009)(1800799009)(6666004)(41300700001)(8936002)(5660300002)(8676002)(66946007)(2906002)(316002)(6916009)(38100700002)(66556008)(478600001)(66476007)(86362001)(4326008)(44832011)(1076003)(83380400001)(6506007)(2616005)(107886003)(6486002)(36756003)(6512007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 33VNdNNpOt7jUdUvmViagfv0+nevDaHTk2j8vUSIowk9TvdHo8/3REYS1WESulfBOjZIRjZgdRmDgq6U5MGR+Hgah7BBlrbRiZ302LTNLV0Fmj2bPeq7xHwrYMduU3jtshld3ocIFOJX4c2FeqWXFb3fuBV7dQzxJ1nIuJkxaERGg084Ce0bwygeIpUUexKC30Ajqmd5ZZZ+Jn+leks44mgKlHRRMKOHPwBCGwc5tTSpsjrTzOGUkNsqigWtAKemI4Eij2IBHiPd8yU6SFvhKnEwYH2st0MCjRsPgn8AObRWzW5fusMqDAs1O7LLRA8YbjcYNzhxvun0ZKD1dZA+MxzsgzsgYtAkyUxzsf58utj310t5fxG0JELmzJ/gAFnUdv6gtqqK68XOW/EX0O4t3Q7F2xRnn563AmVCoFxxBzq7+S7CbTYWCnP+rDG6aeIKig7dsvuN6XCdUyq0m1ILhFqJ23OJL3lH7LrBRVA1XZoTMZwxeteY0FsXZwfYO6ABaeLic3lS8VjZ7e562x+YjlGz9Kzb8Fpsg162HGTuC8xNAvspML1Dh/0sey1Lse2Vt9SST6i+InvfDfY7Y8nB+kybqyTAMsXf+pUjHvLQ19Ubx1phdC6woKHNqdo5MSHBj+zb7C9/N0rRyRyt6Jm4jtLoNSTfy5MN/WgpYIDtmkJj65O716fsnELv1tULQ1c48dss/EEp2U5aVaI4SsowJO5DBUATdvG8Tt8Kg1XZpEjDoG1glmaMF3nQnfyCfSyAOklYrWD+g/t5rudmt131HcxHHXitjWK60QrYtNAwiPcpMGUIAFxleWfMMupiKb+UauZHdaDYTNNnk1ip8jp3ss3ZaoWIpqqiD8uh8tH5rv+ITFj2Smy7Mu2StwaMX0VnfXEPVdLbz4v4XqNyxLGcsfh4GcauWRtX3BRS1g+Uq86BlPr3bgbOA/8Qq/JHIjw6SXvJ5pKaCeHC2ejl2D84X7eHjCGgir9WaBSrW+b0AIPe1oWuoIzzQWig+5iIRKDcg1O5nbQ0/5pKw172bap4+cstwjNi0LthpJWHtkDVKK/lChU/fKi9j1mxvdPbbtYvpzINtuwZX78B3PO0Y8QOhTfIJjv+Hdhw+tkQDgdhTVfOnyVt2CRuh43QLUgeNaphxbgrd7o/xOvIuvgOl7+fhs1l3pU/HgsH/wxD6w3TB/9Wa6WYlZr4Ff29XDFuo+NWTL6iIZQDN5GZVUITmiZF8DPNuTIarte2kFQdNkmXSN9I0bhe/NV7AUQMilaL7WsfcdfbZErwwTc1UgdOpY4K9vWO4/KztNfc8FboGtboKhMnn/A4ryDf4epyCzF2Mk0dsPqYKJnAfsuFcA5xR+AvRHAkf69CaWqaEuN4nGSGvIDAo5DvZNEbWrqlF7hgpGztKji8ssF28cgWhyL5q5OjTBPuYfWEm+vTylzwXkGIsi4umKJpeX7FX+qzmCo0vgjT5vqNOn3EilgzcCZYiYOW/0nI/Nwhaf6ios1rsDuaXSUFeXxrzfehd1PVeWTgmR9d1/lZBDRBv3Qt4E1tE3870bPZ7QU8R2h+4byOa36khwLig78pqbg1fx9dK0R/plEjdkHF1vYNl2n7vlg++rI2LWLlvzEwQBbG02fPQ90JciQ= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: nyqCVbBoojdPb3uTc8qot6bSZXev5dYGPU8zrROCqncJ5ODSrSftldqhqJXh5ox5qcuzNU7uwv9ZTQdz1P5reyZZ7UQ5er9C6w7A9z7E0/tCaklDACuy1qvZG3CSOsvbrZ4bvymqOfGN7J5TOWFJn7d+A1uyZ9hp0wDRhuRVYtpbZ1EqHAAS2kdUyxjGVZOX0dmYoRCtmKsjIO7PoYQ1wP/UMK+fga7Z2ogvIefeQ6NupLe0NMnSq51Rii3qIAU2+T1bNMYqijPsS7q3GdLmb3/7z8HL/MpfynG6YsMe+YZM+fSgG1DLAPNrRkg4DMvveuP0Rf05LIRToZ1OaOnk9FTtYE0xvARCNiTBgS03/RWVfv3EtSSuvEWuzJPjnmZWi4IA8HpbTCQ3VWMGI3sIcR/q2rUeSWDDFu4h1xdAIIBru1FKxJXUS4VMV3KpfbGeTqXcYbDfCDU/uUfaanGyvhmQeQ+vdSetLstU+g5cgF+rL395O1f94bcJk+yeL9C2f2LoY+trvb1GbobviLrRK3/PKdOCo8T2HbHuXC6KYW0P1pGUr92+6U6LHWBOZBL8+4NA5jcZwKH49IqbVdh/1OpIfIMUcxPJiyrKnhtfBx62x6hLJbL1KceWBgKOJy4ozS1kLNpER03ptUZAM3HWZtFvsxjC6QDphXQRdvjf8BNMpQ+q1/yp7XuvjBIpL6szVuz2ziWSoQorukaKWhSGNfZt8AVIlTBtMoq6Zd3fPLQFBLWFSuHIXrRUtq8k5YLdQK/A1X0hmPB7xOvcBVjc7Q== X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5faf6575-9738-4272-f9aa-08dbba2df219 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2023 23:04:30.2582 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VffnmoUA0U+luIRLNuqn3R//u4Y76w3xj5a2/bBhiss8F+0HXAEgtSnP5SPuMm6B5bsupojUlmAlIuZhUDklrA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR10MB5553 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-09-20_11,2023-09-20_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0 mlxscore=0 mlxlogscore=999 bulkscore=0 malwarescore=0 suspectscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2308100000 definitions=main-2309200193 X-Proofpoint-GUID: QCtfYGYw3EiD9dbL6C-QOVKQ4GuL3Nox X-Proofpoint-ORIG-GUID: QCtfYGYw3EiD9dbL6C-QOVKQ4GuL3Nox X-Spam-Status: No, score=-13.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Indu Bhagat via Binutils From: Indu Bhagat Reply-To: Indu Bhagat Errors-To: binutils-bounces+patchwork=sourceware.org@sourceware.org Sender: "Binutils" The code in dw2gencfi.c was checking variable cfi_sections and all_cfi_sections seemingly randomly. Accessing all_cfi_sections seems to the correct variable to access. The data in cfi_sections has already been propagated to all_cfi_sections once cfi_dot_startproc () has been called. gas/ * dw2gencfi.c (dot_cfi_startproc): Use all_cfi_sections instead. (dot_cfi_endproc): Likewise. (dot_cfi_fde_data): Likewise. --- gas/dw2gencfi.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gas/dw2gencfi.c b/gas/dw2gencfi.c index cbfee0a0169..5fcfb373935 100644 --- a/gas/dw2gencfi.c +++ b/gas/dw2gencfi.c @@ -1316,7 +1316,7 @@ dot_cfi_startproc (int ignored ATTRIBUTE_UNUSED) if (!simple) tc_cfi_frame_initial_instructions (); - if ((cfi_sections & CFI_EMIT_target) != 0) + if ((all_cfi_sections & CFI_EMIT_target) != 0) tc_cfi_startproc (); } @@ -1336,7 +1336,7 @@ dot_cfi_endproc (int ignored ATTRIBUTE_UNUSED) demand_empty_rest_of_line (); - if ((cfi_sections & CFI_EMIT_target) != 0) + if ((all_cfi_sections & CFI_EMIT_target) != 0) tc_cfi_endproc (last_fde); } @@ -1417,8 +1417,8 @@ dot_cfi_fde_data (int ignored ATTRIBUTE_UNUSED) last_fde = frchain_now->frch_cfi_data->cur_fde_data; - if ((cfi_sections & CFI_EMIT_target) != 0 - || (cfi_sections & CFI_EMIT_eh_frame_compact) != 0) + if ((all_cfi_sections & CFI_EMIT_target) != 0 + || (all_cfi_sections & CFI_EMIT_eh_frame_compact) != 0) { struct cfi_escape_data *head, **tail, *e; int num_ops = 0;