MIPS: Fix binutils-all tests for r6 default triples

Message ID 20230817035805.551641-1-yunqiang.su@cipunited.com
State Under Review
Delegated to: Maciej W. Rozycki
Headers
Series MIPS: Fix binutils-all tests for r6 default triples |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_binutils_check--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_binutils_check--master-arm success Testing passed
linaro-tcwg-bot/tcwg_binutils_build--master-arm success Testing passed
linaro-tcwg-bot/tcwg_binutils_build--master-aarch64 success Testing passed

Commit Message

YunQiang Su Aug. 17, 2023, 3:58 a.m. UTC
  MIPS16 is not supported for MIPSr6 as ISA documents; microMIPS
on MIPSr6 is not supported by binutils yet, and in fact we have
no plan to support it.

So let's add `-32 -mips1` as options to mips16-extend-noinsn.d and
mixed-mips16-micromips.d.
---
 binutils/testsuite/binutils-all/mips/mips16-extend-noinsn.d   | 1 +
 binutils/testsuite/binutils-all/mips/mixed-mips16-micromips.d | 1 +
 2 files changed, 2 insertions(+)
  

Comments

YunQiang Su Aug. 28, 2023, 3:54 a.m. UTC | #1
YunQiang Su <yunqiang.su@cipunited.com> 于2023年8月17日周四 11:58写道:
>
> MIPS16 is not supported for MIPSr6 as ISA documents; microMIPS
> on MIPSr6 is not supported by binutils yet, and in fact we have
> no plan to support it.
>
> So let's add `-32 -mips1` as options to mips16-extend-noinsn.d and
> mixed-mips16-micromips.d.

@Maciej W. Rozycki Can you have a glance of this +2-2 patch?
It is quite simple.

> ---
>  binutils/testsuite/binutils-all/mips/mips16-extend-noinsn.d   | 1 +
>  binutils/testsuite/binutils-all/mips/mixed-mips16-micromips.d | 1 +
>  2 files changed, 2 insertions(+)
>
> diff --git a/binutils/testsuite/binutils-all/mips/mips16-extend-noinsn.d b/binutils/testsuite/binutils-all/mips/mips16-extend-noinsn.d
> index 41bb49e6ac7..74f537c3213 100644
> --- a/binutils/testsuite/binutils-all/mips/mips16-extend-noinsn.d
> +++ b/binutils/testsuite/binutils-all/mips/mips16-extend-noinsn.d
> @@ -1,4 +1,5 @@
>  #PROG: objcopy
> +#as: -32 -mips1
>  #objdump: -d --prefix-addresses --show-raw-insn
>  #name: MIPS16 unsupported EXTEND and undefined opcode disassembly
>
> diff --git a/binutils/testsuite/binutils-all/mips/mixed-mips16-micromips.d b/binutils/testsuite/binutils-all/mips/mixed-mips16-micromips.d
> index 4a53dfb8578..d3dc14e97f8 100644
> --- a/binutils/testsuite/binutils-all/mips/mixed-mips16-micromips.d
> +++ b/binutils/testsuite/binutils-all/mips/mixed-mips16-micromips.d
> @@ -1,4 +1,5 @@
>  #PROG: objcopy
> +#as: -32 -mips1
>  #objdump: -drt
>  #name: Mixed MIPS16 and microMIPS disassembly
>
> --
> 2.30.2
>
  

Patch

diff --git a/binutils/testsuite/binutils-all/mips/mips16-extend-noinsn.d b/binutils/testsuite/binutils-all/mips/mips16-extend-noinsn.d
index 41bb49e6ac7..74f537c3213 100644
--- a/binutils/testsuite/binutils-all/mips/mips16-extend-noinsn.d
+++ b/binutils/testsuite/binutils-all/mips/mips16-extend-noinsn.d
@@ -1,4 +1,5 @@ 
 #PROG: objcopy
+#as: -32 -mips1
 #objdump: -d --prefix-addresses --show-raw-insn
 #name: MIPS16 unsupported EXTEND and undefined opcode disassembly
 
diff --git a/binutils/testsuite/binutils-all/mips/mixed-mips16-micromips.d b/binutils/testsuite/binutils-all/mips/mixed-mips16-micromips.d
index 4a53dfb8578..d3dc14e97f8 100644
--- a/binutils/testsuite/binutils-all/mips/mixed-mips16-micromips.d
+++ b/binutils/testsuite/binutils-all/mips/mixed-mips16-micromips.d
@@ -1,4 +1,5 @@ 
 #PROG: objcopy
+#as: -32 -mips1
 #objdump: -drt
 #name: Mixed MIPS16 and microMIPS disassembly