From patchwork Thu Jan 23 08:01:42 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 105282 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 28780385840C for ; Thu, 23 Jan 2025 08:05:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 28780385840C Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256 header.s=google header.b=Q/A/Gn6j X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by sourceware.org (Postfix) with ESMTPS id A5C03385841E for ; Thu, 23 Jan 2025 08:01:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A5C03385841E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A5C03385841E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::335 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737619304; cv=none; b=QuIRDRbgQzwfI5jWRrXXhLMiIROaI4f1zVSE2NEQP1fwZTrxKQnCjkjQWDHPqAMlAcMQsQtoN23iLF6AXVJFsGn+P9fSH2w6ppUCmLokaa+ZkE4Yc3/yrHTFj7KInArdnEoLzq/5VnXQZja1LbY3Oc8BIzuR390GvBQtSs2uNeg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737619304; c=relaxed/simple; bh=IblgtKun2ZMfxlYTduSKpGg3LVNJe2ly/KpXRpuxtz8=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=IxMz39n7Y3Apxpdel0bdPnmo5uLCGsXMyL1byXmMu03yhMMxU1cWPrN9adBvlIIJfeEVled0e23MWbK2GNroNe3zxINwpLrcEy3YMHBaC1rp5zulMuHp69HPoAEHOveuvXJFVEuGjlHbG0ZOHY/aAgF+zBnkrBespgka/0fsZp4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A5C03385841E Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-437a92d7b96so5689315e9.2 for ; Thu, 23 Jan 2025 00:01:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1737619303; x=1738224103; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=ZQhwlggMifFxa3AruLWMj5UndWaDlpExmCBefP+M78I=; b=Q/A/Gn6jXt0MEacXyp3HKxBJFYZkRIQLTCbDJezFA1C0JkQ2joym6i2eYt9F2362OV I36UEuVjniBSFHL72WrhCRoVh6+Qiu1KzWuLwRWrnetgbRX6J/i4ixjoz/IJORRowAmT I0px5xx2fbCfKdbWGpo4SbSttfA6ksm8706M/7i+9y2pl11/9gqpMVJlkjvttNxQCR0p Nd8VSj0lPsyIdRu2yixpmx8V35iJtpANeMpOsG00uNOjgVu1g5YfUBE59N2/DUzIQ05A 2BulqAhY50cGQ3OtMp6WeK7M+zQYoKGAb5c3fsBQJLOzwOrRu5WM7cQAsuw2tWSpUXTQ cCqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737619303; x=1738224103; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZQhwlggMifFxa3AruLWMj5UndWaDlpExmCBefP+M78I=; b=glWQEoxKIt00fCqrh0U8gBHvatvZ0NBkCayQXf70h6/SoE9ccb0/isteO4PEMMeZBS 01DQMHqi76zINGv7ZqSeJ+MtpmFBbdnnABfABqBNrfAlZgfrlcqa3tIbHHVDgWaPu/R1 /TWQtfu0oiZC/FjK9GyCsXcbCGldjpXabToxiWRtH20gwuq77PLxw/L3yh5yj9QBtN5M PArMJQPJ0dQ4FfxeYEgnBf874A+HNb99GlzBcLSmCpOI0YTkvIS1LWEpYyw9Wk5+n7yM 3vLtiHBCvjXx5g5YlGxUdK82o91Hrq2GIiMbDKPs7Dt25ZBYBwDmejMxjHd0+eA8DNDP 7PtQ== X-Gm-Message-State: AOJu0YwL0zuBRjjKmnUFnmLtYlx0TswKw8j3JhQ6Rfi+XuFiTky2m2VW 4+wZ5lr4nr3+FhE7HjBGTt+pkXJJEeE2SUcVtCgf6agws+PAQF+8AMS3MxdgOkcAY7RAo5FlVns = X-Gm-Gg: ASbGnctz1svImEGqjXGtOX/e1nKNkeB+iZ8Na81FEFwaBcG5rdbETpC+lGYOfm4o3PH IaE8IPutGbHxxkt4cgoU2azofDMxmhXZEwXaovdWlHEuwZOPDoj7NqAQb8VBbjVp1qKb71zZuNT jeK8EUHAxQVT9QtUlBpRmD4DmSZ4Lg4yFSBDcer3mDsWni1DkGLWNel0L8x8zBa03Nq1QGqvYz/ MpK5pt69jhbEBqOrfdypVgB6930NUr6NTOIJudpDqjsFNnjs0yMCQwjFFmJj43BxpWzMO4O3CfD bYQAjupjx348pIIXUYOzHy/sCBx6AxRjZRMIPa8IhhCLceCtJcVVny5LK972ZwED3A== X-Google-Smtp-Source: AGHT+IHOjFy/yayfHZtj/yDU7vEprH5rkb/NMKWYrIYLwLJs3MeGNTjtgWpcBeN4gQUsWPyVXRmzpw== X-Received: by 2002:a05:600c:35c3:b0:438:a290:3ce0 with SMTP id 5b1f17b1804b1-438a2903f47mr180852015e9.8.1737619303270; Thu, 23 Jan 2025 00:01:43 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438b31a21adsm52437655e9.12.2025.01.23.00.01.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Jan 2025 00:01:42 -0800 (PST) Message-ID: <1fedd7b9-19f2-4f6f-aa77-e103830913b6@suse.com> Date: Thu, 23 Jan 2025 09:01:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 3/3] x86: support RMPREAD insn From: Jan Beulich To: Binutils Cc: "Kalvakuntla, Umesh" , "H.J. Lu" References: <862169bd-fa49-42a7-9081-7ac68e54f6f0@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <862169bd-fa49-42a7-9081-7ac68e54f6f0@suse.com> X-Spam-Status: No, score=-3022.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org Like for RMPUPDATE documentation is about to change as far as operands are concerned. They're merely the other way around here. While adjustind gas documentation, also add the missing RMPQUERY counterparts there. --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -1214,6 +1214,7 @@ static const arch_entry cpu_arch[] = VECARCH (avx_ne_convert, AVX_NE_CONVERT, ANY_AVX_NE_CONVERT, reset), SUBARCH (rao_int, RAO_INT, RAO_INT, false), SUBARCH (rmpquery, RMPQUERY, ANY_RMPQUERY, false), + SUBARCH (rmpread, RMPREAD, ANY_RMPREAD, false), SUBARCH (fred, FRED, ANY_FRED, false), SUBARCH (lkgs, LKGS, ANY_LKGS, false), VECARCH (avx_vnni_int16, AVX_VNNI_INT16, ANY_AVX_VNNI_INT16, reset), --- a/gas/doc/c-i386.texi +++ b/gas/doc/c-i386.texi @@ -281,6 +281,8 @@ accept various extension mnemonics. For @code{snp}, @code{invlpgb}, @code{tlbsync}, +@code{rmpquery}, +@code{rmpread}, @code{svme}, @code{gmism2}, @code{gmiccs}, @@ -1719,8 +1721,8 @@ supported on the CPU specified. The cho @item @samp{.lwp} @tab @samp{.fma4} @tab @samp{.xop} @tab @samp{.cx16} @item @samp{.padlock} @tab @samp{.clzero} @tab @samp{.mwaitx} @tab @samp{.rdpru} @item @samp{.mcommit} @tab @samp{.sev_es} @tab @samp{.snp} @tab @samp{.invlpgb} -@item @samp{.tlbsync} @tab @samp{.apx_f} @tab @samp{.gmism2} @tab @samp{.gmiccs} -@item @samp{.padlockrng2} @tab @samp{.padlockphe2} +@item @samp{.tlbsync} @tab @samp{.rmpquery} @tab @samp{.rmpread} @tab @samp{.apx_f} +@item @samp{.gmism2} @tab @samp{.gmiccs} @tab @samp{.padlockrng2} @tab @samp{.padlockphe2} @end multitable --- a/gas/testsuite/gas/i386/snp.s +++ b/gas/testsuite/gas/i386/snp.s @@ -16,6 +16,8 @@ att: rmpadjust rmpadjust %rax, %rcx, %rdx rmpadjust %eax, %rcx, %rdx + rmpread %rax, (%rcx) + rmpread %rax, (%ecx) .else pvalidate %ax, %ecx, %edx .endif @@ -36,6 +38,8 @@ intel: rmpadjust rmpadjust rax, rcx, rdx rmpadjust eax, rcx, rdx + rmpread [rcx], rax + rmpread [ecx], rax .else pvalidate ax, ecx, edx .endif --- a/gas/testsuite/gas/i386/snp64.d +++ b/gas/testsuite/gas/i386/snp64.d @@ -21,6 +21,8 @@ Disassembly of section \.text: [ ]*[a-f0-9]+:[ ]+f3 0f 01 fe[ ]+rmpadjust [ ]*[a-f0-9]+:[ ]+f3 0f 01 fe[ ]+rmpadjust [ ]*[a-f0-9]+:[ ]+67 f3 0f 01 fe[ ]+addr32 rmpadjust +[ ]*[a-f0-9]+:[ ]+f2 0f 01 fd[ ]+rmpread %rax,\(%rcx\) +[ ]*[a-f0-9]+:[ ]+67 f2 0f 01 fd[ ]+rmpread %rax,\(%ecx\) [0-9a-f]+ : [ ]*[a-f0-9]+:[ ]+f2 0f 01 ff[ ]+pvalidate @@ -36,4 +38,6 @@ Disassembly of section \.text: [ ]*[a-f0-9]+:[ ]+f3 0f 01 fe[ ]+rmpadjust [ ]*[a-f0-9]+:[ ]+f3 0f 01 fe[ ]+rmpadjust [ ]*[a-f0-9]+:[ ]+67 f3 0f 01 fe[ ]+addr32 rmpadjust +[ ]*[a-f0-9]+:[ ]+f2 0f 01 fd[ ]+rmpread %rax,\(%rcx\) +[ ]*[a-f0-9]+:[ ]+67 f2 0f 01 fd[ ]+rmpread %rax,\(%ecx\) #pass --- a/opcodes/i386-dis.c +++ b/opcodes/i386-dis.c @@ -1347,6 +1347,7 @@ enum X86_64_0F01_REG_5_MOD_3_RM_6_PREFIX_1, X86_64_0F01_REG_5_MOD_3_RM_7_PREFIX_1, X86_64_0F01_REG_7_MOD_3_RM_5_PREFIX_1, + X86_64_0F01_REG_7_MOD_3_RM_5_PREFIX_3, X86_64_0F01_REG_7_MOD_3_RM_6_PREFIX_1, X86_64_0F01_REG_7_MOD_3_RM_6_PREFIX_3, X86_64_0F01_REG_7_MOD_3_RM_7_PREFIX_1, @@ -3253,6 +3254,8 @@ static const struct dis386 prefix_table[ { { "rdpru", { Skip_MODRM }, 0 }, { X86_64_TABLE (X86_64_0F01_REG_7_MOD_3_RM_5_PREFIX_1) }, + { Bad_Opcode }, + { X86_64_TABLE (X86_64_0F01_REG_7_MOD_3_RM_5_PREFIX_3) }, }, /* PREFIX_0F01_REG_7_MOD_3_RM_6 */ @@ -4632,6 +4635,12 @@ static const struct dis386 x86_64_table[ { "rmpquery", { Skip_MODRM }, 0 }, }, + /* X86_64_0F01_REG_7_MOD_3_RM_6_PREFIX_3 */ + { + { Bad_Opcode }, + { "rmpread", { DSCX, RMrAX, Skip_MODRM }, 0 }, + }, + /* X86_64_0F01_REG_7_MOD_3_RM_6_PREFIX_1 */ { { Bad_Opcode }, @@ -13143,7 +13152,7 @@ OP_DSreg (instr_info *ins, int code, int { switch (ins->codep[-1]) { - case 0x01: /* rmpupdate */ + case 0x01: /* rmpupdate/rmpread */ break; case 0x6f: /* outsw/outsl */ intel_operand_size (ins, z_mode, sizeflag); --- a/opcodes/i386-gen.c +++ b/opcodes/i386-gen.c @@ -251,6 +251,8 @@ static const dependency isa_dependencies "SEV_ES" }, { "RMPQUERY", "SNP|64" }, + { "RMPREAD", + "SNP|64" }, { "TSX", "RTM|HLE" }, { "TSXLDTRK", @@ -470,6 +472,7 @@ static bitfield cpu_flags[] = BITFIELD (TLBSYNC), BITFIELD (SNP), BITFIELD (RMPQUERY), + BITFIELD (RMPREAD), BITFIELD (64), BITFIELD (No64), #ifdef CpuUnused --- a/opcodes/i386-opc.h +++ b/opcodes/i386-opc.h @@ -316,6 +316,8 @@ enum i386_cpu CpuSNP, /* RMPQUERY instruction required */ CpuRMPQUERY, + /* RMPREAD instruction required */ + CpuRMPREAD, /* NOTE: These items, which can be combined with other ISA flags above, need to remain second to last and in sync with CPU_FLAGS_COMMON. */ @@ -549,6 +551,7 @@ typedef union i386_cpu_flags unsigned int cputlbsync:1; unsigned int cpusnp:1; unsigned int cpurmpquery:1; + unsigned int cpurmpread:1; CPU_FLAGS_COMMON; #ifdef CpuUnused unsigned int unused:(CpuNumOfBits - CpuUnused); --- a/opcodes/i386-opc.tbl +++ b/opcodes/i386-opc.tbl @@ -3181,6 +3181,12 @@ rmpquery, 0xf30f01fd, RMPQUERY, AddrPref // RMPQUERY instruction end +// RMPREAD instruction + +rmpread, 0xf20f01fd, RMPREAD&x64, IsString|NoSuf|NoRex64, { Acc|Qword, RegC|Unspecified|BaseIndex } + +// RMPREAD instruction end + // RDPRU instruction rdpru, 0x0f01fd, RDPRU, NoSuf, {}