diff mbox series

x86: fix Solaris gas testsuite run

Message ID 1ce66222-7358-48c1-8e73-2147ac365bec@suse.com
State New
Headers
Series x86: fix Solaris gas testsuite run |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_binutils_build--master-arm success Build passed
linaro-tcwg-bot/tcwg_binutils_build--master-aarch64 success Build passed
linaro-tcwg-bot/tcwg_binutils_check--master-aarch64 success Test passed
linaro-tcwg-bot/tcwg_binutils_check--master-arm success Test passed

Commit Message

Jan Beulich Sept. 26, 2024, 2:16 p.m. UTC 
  Commits 8015b1b0c1a1 ("x86-64: Never make R_X86_64_GOT64 section
relative"), d774bf9b3623 ("x86: Add tls check in gas"), and
1b714c14e40f ("x86: Turn PLT32 to PC32 only for PC-relative
relocations") all should have adjusted the Solaris counterpart of the
reloc64 test as well.

Comments

H.J. Lu Sept. 27, 2024, 12:04 a.m. UTC | #1 
On Thu, Sep 26, 2024, 10:16 PM Jan Beulich <jbeulich@suse.com> wrote:

> Commits 8015b1b0c1a1 ("x86-64: Never make R_X86_64_GOT64 section
> relative"), d774bf9b3623 ("x86: Add tls check in gas"), and
> 1b714c14e40f ("x86: Turn PLT32 to PC32 only for PC-relative
> relocations") all should have adjusted the Solaris counterpart of the
> reloc64 test as well.
>
> --- a/gas/testsuite/gas/i386/solaris/reloc64.d
> +++ b/gas/testsuite/gas/i386/solaris/reloc64.d
> @@ -1,4 +1,4 @@
> -#as: -mx86-used-note=no
> +#as: -mx86-used-note=no -mtls-check=no
>  #source: ../reloc64.s
>  #objdump: -Drw
>  #name: x86-64 relocs
> @@ -57,6 +57,9 @@ Disassembly of section \.text:
>  .*[    ]+R_X86_64_32[  ]+xtrn
>  .*[    ]+R_X86_64_32S[         ]+xtrn
>  .*[    ]+R_X86_64_32[  ]+xtrn
> +.*[    ]+R_X86_64_GOT64[       ]+ptr
> +.*[    ]+R_X86_64_GOTOFF64[    ]+Ldst
> +.*[    ]+R_X86_64_PLT32[       ]+ptr
>  Disassembly of section \.data:
>  #...
>  .*[    ]+R_X86_64_64[  ]+xtrn
> @@ -97,3 +100,8 @@ Disassembly of section \.data:
>  .*[    ]+R_X86_64_GOT32[       ]+xtrn-0x4
>  .*[    ]+R_X86_64_GOT32[       ]+xtrn\+0x4
>  .*[    ]+R_X86_64_GOTPLT64[    ]+xtrn
> +
> +.* <ptr>:
> +       ...
> +.* <Ldst>:
> +       ...
>

Thanks.


>
diff mbox series

Patch

--- a/gas/testsuite/gas/i386/solaris/reloc64.d
+++ b/gas/testsuite/gas/i386/solaris/reloc64.d
@@ -1,4 +1,4 @@ 
-#as: -mx86-used-note=no
+#as: -mx86-used-note=no -mtls-check=no
 #source: ../reloc64.s
 #objdump: -Drw
 #name: x86-64 relocs
@@ -57,6 +57,9 @@  Disassembly of section \.text:
 .*[ 	]+R_X86_64_32[ 	]+xtrn
 .*[ 	]+R_X86_64_32S[ 	]+xtrn
 .*[ 	]+R_X86_64_32[ 	]+xtrn
+.*[ 	]+R_X86_64_GOT64[ 	]+ptr
+.*[ 	]+R_X86_64_GOTOFF64[ 	]+Ldst
+.*[ 	]+R_X86_64_PLT32[ 	]+ptr
 Disassembly of section \.data:
 #...
 .*[ 	]+R_X86_64_64[ 	]+xtrn
@@ -97,3 +100,8 @@  Disassembly of section \.data:
 .*[ 	]+R_X86_64_GOT32[ 	]+xtrn-0x4
 .*[ 	]+R_X86_64_GOT32[ 	]+xtrn\+0x4
 .*[ 	]+R_X86_64_GOTPLT64[ 	]+xtrn
+
+.* <ptr>:
+	...
+.* <Ldst>:
+	...