From patchwork Mon Apr 7 13:53:37 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 109975 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DCE693857002 for ; Mon, 7 Apr 2025 13:56:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DCE693857002 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256 header.s=google header.b=Dfq2Sp4w X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by sourceware.org (Postfix) with ESMTPS id 6D1C9384A473 for ; Mon, 7 Apr 2025 13:53:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6D1C9384A473 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6D1C9384A473 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::335 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1744034016; cv=none; b=IfcDnueJ1K6aLjkn48FKCboPzjteFMf0dTSFrmL3jCQwv9YTWjFk0AFBLfE4C29V5Ic1MdW96AYSoBzZ+zOX9zbRXcU7WYuu8LCwhPbDt7iDHiHiBPskBtYVi+b3WWIA8ynQT4Hcxrk7LRoFi3NQBgS3yJbOdQI/Np+uMvgShlU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1744034016; c=relaxed/simple; bh=SLMzDLR1nlwNfzuxV4CNbS9w7C3ikyxcTZbkiB7d6Sg=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=BWVYfK1ILEmMMvGdA/Fo6h5jjddDlgfbwmyoOZbIPT2niPAe8bXqlGLe3alvCAhQw3XErtPJEzbTTF2P+4VEZ6XRfzJz5Cl836G9PnjK7EOzN6pzAREepH0bWCa2+kg6VpQ0c6Fo/H7cPtShx/JWyWem7O2Kex3zGB5Cag7v09g= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6D1C9384A473 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-43cf0d787eeso48458745e9.3 for ; Mon, 07 Apr 2025 06:53:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1744034015; x=1744638815; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:to:from:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dGI3/sSrlpiaUIO3/CrQhTyy3kPK5l7MmHhjNMY40GQ=; b=Dfq2Sp4wjnGuGgjMl0DoqxmsvDyZpKVFuPl60KcmVgXqZdvKXHQK7ppRQxyCS3jsFv gJn170DtojMLsxcwKydHBap+vmtrnnZDHkliR6CJudpoduBWPPjieNJdeS7Eo/7loWTU OPaQRSJP8cOiVqIFp2PQJtVgn7YQmuQaUX8NsvY9VK/C6fuSX/Xg4CNUaqYg7h4FQg6l XE+nRlqV0KpE7j5Q/RhvvaYJ4zYED4NPvh128jRtgXRdS5sbcsfh7BVfT+xtgt1mVZPG 2QjLdLVJKIkRi6RIF3xDYsS3OCs1FdRgC0XwyxyHxBISC6VAj437lfAOXNZrVd8yzJG4 6Jgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744034015; x=1744638815; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dGI3/sSrlpiaUIO3/CrQhTyy3kPK5l7MmHhjNMY40GQ=; b=Z4/h3ymNgrGQxhhMr4P/frSYbAWu5VfUgz1VPEk6Ic7Lr2gWXvZRJxmPVkHg+iS1Uy ezrNyGuBpsojfdxeBn2e/jZEMMh6Gp/whpvLYDtRuTUQ6OZWdv8lt3DNpf5wMLjGNCMF /N6YjRRiJfgbsJclAUAkhEAa/PMvDsE01648cfh7NOfGLCCIDsmR6LoxjzugnxUl28uv nOD7c6iW66MGyNPe7Wix4u7LgSqyT/qZAt/0RBX6DyQzz4J3SsB/B1zxaJ8bwPvOr2Cq 8J1Cf6WrKy7VRUGZch+Uap+0OlvRvMJ9xkFdQsHyIgIvmesw6IkrfnisinE9DwCvKQ4t bjlg== X-Gm-Message-State: AOJu0YyOynW1cJqUsTyqXpko5dRIMthODFEkpXjvh3R6abGOpD4UJMmI /MWbZRZT78ZppuYz3AjoLrIMx6sedX3l3bd6DVVwxLf9hODhxTAxC9AFFfoin8rO4loIEMxDbZ4 = X-Gm-Gg: ASbGnctxxg+9+/JbLr1+cmUTz2XcSz1zn68ZRYoV8ECTW9DCXNfSK4OxuZ4WNDnaVf1 KX31simHPNcK6HlvvpZrNY9kyjDWsarTCzR2Ma5sL2kAJkEYspDjYwSasXb0ST7050KzLzg9ydJ yJhDtxZlyuCStvtBfr/95WKT77ikjOjTpN2hy6uk8Y5zWNRB+UkRr4xiLV+Ee8S/MXq9Ia8gXWp IqSw8Gp3Z84s8cpmEn3Ri/7AG8pbE5Stphfw2KAdiBOGXyDk1pWQZ28M3SzmvyNO2CcvI9edL3/ 83Sze9x90VUYF3/OEN8Zrlk/8OYFFt+mX6G9goqFTj+WrFLk2YxHhFPnRkvanhY976bkEMU+4Yy FHNQQ15XGo7vkcBIzHF5hAY++TxiXHw== X-Google-Smtp-Source: AGHT+IFiNCr2x2rxeaq1HaG5XWp4Y2MVrjgOPfi8ZVRAt1NUALLHfguVSkWN3x/Je5a0B1wgELXblQ== X-Received: by 2002:a05:600c:46d0:b0:43c:e8a5:87a with SMTP id 5b1f17b1804b1-43ed0c6ba07mr122275985e9.16.1744034014931; Mon, 07 Apr 2025 06:53:34 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec16602bbsm133765305e9.9.2025.04.07.06.53.34 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Apr 2025 06:53:34 -0700 (PDT) Message-ID: <1686ccad-8c83-4bf3-bd0d-22946d53e376@suse.com> Date: Mon, 7 Apr 2025 15:53:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v2 2/3] bfd/aout: drop add_one_symbol() hook From: Jan Beulich To: Binutils References: <566b1382-8eba-4e25-904f-84b47092765b@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <566b1382-8eba-4e25-904f-84b47092765b@suse.com> X-Spam-Status: No, score=-3021.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org The need for this has disappeared with c65c21e1ffd1 ("various i386-aout and i386-coff target removal"), with a few other users having got removed just a few days earlier; avoid the unnecessary indirection. --- v2: New. --- a/bfd/aout-target.h +++ b/bfd/aout-target.h @@ -286,9 +286,6 @@ MY (set_sizes) (bfd *abfd) #ifndef MY_add_dynamic_symbols #define MY_add_dynamic_symbols 0 #endif -#ifndef MY_add_one_symbol -#define MY_add_one_symbol 0 -#endif #ifndef MY_link_dynamic_object #define MY_link_dynamic_object 0 #endif @@ -312,7 +309,6 @@ static const struct aout_backend_data MY MY_set_sizes, MY_exec_header_not_counted, MY_add_dynamic_symbols, - MY_add_one_symbol, MY_link_dynamic_object, MY_write_dynamic_symbol, MY_check_dynamic_reloc, --- a/bfd/aoutx.h +++ b/bfd/aoutx.h @@ -2973,9 +2973,6 @@ NAME (aout, link_hash_table_create) (bfd static bool aout_link_add_symbols (bfd *abfd, struct bfd_link_info *info) { - bool (*add_one_symbol) - (struct bfd_link_info *, bfd *, const char *, flagword, asection *, - bfd_vma, const char *, bool, bool, struct bfd_link_hash_entry **); struct external_nlist *syms; bfd_size_type sym_count; char *strings; @@ -3013,10 +3010,6 @@ aout_link_add_symbols (bfd *abfd, struct return false; obj_aout_sym_hashes (abfd) = sym_hash; - add_one_symbol = aout_backend_info (abfd)->add_one_symbol; - if (add_one_symbol == NULL) - add_one_symbol = _bfd_generic_link_add_one_symbol; - p = syms; pend = p + sym_count; for (; p < pend; p++, sym_hash++) @@ -3167,7 +3160,7 @@ aout_link_add_symbols (bfd *abfd, struct break; } - if (! ((*add_one_symbol) + if (! (_bfd_generic_link_add_one_symbol (info, abfd, name, flags, section, value, string, copy, false, (struct bfd_link_hash_entry **) sym_hash))) return false; --- a/bfd/i386aout.c +++ b/bfd/i386aout.c @@ -79,7 +79,6 @@ static const struct aout_backend_data MY MY (set_sizes), 1, /* Exec header not counted. */ 0, /* Add_dynamic_symbols. */ - 0, /* Add_one_symbol. */ 0, /* Link_dynamic_object. */ 0, /* Write_dynamic_symbol. */ 0, /* Check_dynamic_reloc. */ --- a/bfd/libaout.h +++ b/bfd/libaout.h @@ -177,13 +177,6 @@ struct aout_backend_data (bfd *, struct bfd_link_info *, struct external_nlist **, bfd_size_type *, char **); - /* Callback from the add symbols phase of the linker code to handle - adding a single symbol to the global linker hash table. */ - bool (*add_one_symbol) - (struct bfd_link_info *, bfd *, const char *, flagword, - asection *, bfd_vma, const char *, bool, bool, - struct bfd_link_hash_entry **); - /* Called to handle linking a dynamic object. */ bool (*link_dynamic_object) (struct bfd_link_info *, bfd *); --- a/bfd/pdp11.c +++ b/bfd/pdp11.c @@ -2839,9 +2839,6 @@ aout_link_check_archive_element (bfd *ab static bool aout_link_add_symbols (bfd *abfd, struct bfd_link_info *info) { - bool (*add_one_symbol) - (struct bfd_link_info *, bfd *, const char *, flagword, asection *, - bfd_vma, const char *, bool, bool, struct bfd_link_hash_entry **); struct external_nlist *syms; bfd_size_type sym_count; char *strings; @@ -2875,10 +2872,6 @@ aout_link_add_symbols (bfd *abfd, struct return false; obj_aout_sym_hashes (abfd) = sym_hash; - add_one_symbol = aout_backend_info (abfd)->add_one_symbol; - if (add_one_symbol == NULL) - add_one_symbol = _bfd_generic_link_add_one_symbol; - p = syms; pend = p + sym_count; for (; p < pend; p++, sym_hash++) @@ -2951,7 +2944,7 @@ aout_link_add_symbols (bfd *abfd, struct break; } - if (! ((*add_one_symbol) + if (! (_bfd_generic_link_add_one_symbol (info, abfd, name, flags, section, value, string, copy, false, (struct bfd_link_hash_entry **) sym_hash))) return false;