From patchwork Mon Jan 27 16:30:24 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 105500 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CBCE5385828B for ; Mon, 27 Jan 2025 17:01:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CBCE5385828B Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256 header.s=google header.b=bLFeZ1d+ X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by sourceware.org (Postfix) with ESMTPS id 171693857C78 for ; Mon, 27 Jan 2025 16:30:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 171693857C78 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 171693857C78 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::632 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737995427; cv=none; b=iivSUf+IXtK1FEG/l/YUQJYAo/bBxcp/UUogGBmte5XObxi04MBNFJQpeKDuAsLCrWu9/G86pe0uoaf63nG8Ntz8JGRDJRGghObXfx/cKXsolicDRBEWsdIsWLq5tFsE8dBqJe6/WpbopXlE42AreNnxhGsbp2Rgm0n5l3s0hWQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737995427; c=relaxed/simple; bh=uzr8C8YWsAk/Xo44/iIDPQdH4UhXZwmpJPAWph70TL4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=oU6/O/ol2lr+P61BpH898zu9/AUaHvBYqufLLq5Lv9LGARjVFri7Yu5Z0gSdvj7nN/CA6VlZEIlXFKjUYUIKFymaIu8GXPr6HDG+yc/CQ47ENfOK+fTaGlVJmN31gRcxs78aPU5mry7tfUTaFsPqALkaIuBwJBT+JroSAMFSd24= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 171693857C78 Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-ab698eae2d9so344098766b.0 for ; Mon, 27 Jan 2025 08:30:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1737995426; x=1738600226; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:cc:content-language :references:to:from:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yBSkzMqYbgs929RW6Ek/euO6/oQFLJITi1uBiw8jPaI=; b=bLFeZ1d+DWGzvtjXmFM6jKFjppYB75favEn0ToSh5dVfr+88SnM0f7/Uuypr37JWV0 zDAZ1OPmlOWMT+YJgvC+3+Fqd9x7JjeWs2+JSBFFvoB97EwWGiCsq7fBkPVYvQ/WBfBA WmFu+m+pleVRegPo6OunKdYP6aPKC9XsH/EDaxBM4lt3Q6SSIoLHhsZT0+lVx9liQd0C XTBHggcPMTJEvgjAq/Ourg7t8rFV+cW6w325DxM9zH4QStpFB7Og23iICIhO8K82X8zI 6oEwqqQEzFyLMKIHlA3jqB+7KZPCvJAOAO5H0Uarrlvt7ugUh6THvzrHwZXxUaJj9fnl Wzwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737995426; x=1738600226; h=content-transfer-encoding:in-reply-to:autocrypt:cc:content-language :references:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yBSkzMqYbgs929RW6Ek/euO6/oQFLJITi1uBiw8jPaI=; b=d28cvqDVpBxMQklj4JhhCziLSQaC2d5jtUqPIrzzLTsEWUiHeV+u8RDkNpnrtk9j/W ZSmfSMR6uVvIzAgJW4uuIGx0vqgkrgCEfwYUBYNEdfhcf5MF3jzL2soJgQnMY/gc4sab mZw6PxX+lRzSXaCBfwLew1CdJkT15a4Hn1aCsgUrJ606ZMtaIdmv8DqcSxNMaBCnc+0n +5u36bGIbGVxM3y2NnCdTR5FMGJkOAJ+IN+9DaGKoT1kx9aJJghJ/wwb0NPvVcv7fSPN f6W3FMlnKFG+EScj+YAAdRUbZhrsL8OsAyp9jidzk4kASIzMb0Ox0pfxKcFytAVs4nr+ dlAw== X-Gm-Message-State: AOJu0YyURHL0MhLEcbdeaA6QyhdqC0DeCP0mCOXyhjg/U4Dk7qO4+pbD EREqnzckB2iYMoJaCaC/BLEAUgVDMjli32rxec3EDT0gdueK2HVUhpxz3CFt2km5UMtR6FJT9zE = X-Gm-Gg: ASbGnct3Fx6+3V9EVzWfSDTNvnpJaa7hgsyWQdaPO1TJA5xMttiRx/A7Ji35vBFcdzQ RzX6b887uWB8fx7S9o1xFBbhlZUDxwqd28MZAhl4+O+q8MGck2GsTVOkQroVmiF681nTWufByKv flRrrZq3IX9b81zfeIeTDczG2La1lh8TzmnVmd7VZzdwv1UqmQk7c5o8OfSLc7IE/A5p+LFfo2e oqI0iVd/GwmqRmiLO2iw0+1CvQGJW/0zk7SmyKeJc+54nFQ0+wtAG/HQewbZ8J3z48Zi0u/znLm qr61wMVhsjEpa2VnPVE3+LBw9IcOnBbkh3lkX3qHMhWcx3DFXGseq4fjpb8NUugftQ== X-Google-Smtp-Source: AGHT+IFtBsRY5UYJA5IZzHR5Vcx0Obsz4azB+rGrItTULw6qptKNlfRJzwP5Q5/624nzP1Pgn46KIA== X-Received: by 2002:a17:907:940e:b0:aae:bd36:b198 with SMTP id a640c23a62f3a-ab38b4c6a1emr3505028366b.47.1737995425645; Mon, 27 Jan 2025 08:30:25 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab69a26dc94sm293438866b.166.2025.01.27.08.30.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Jan 2025 08:30:25 -0800 (PST) Message-ID: <0d034664-4381-44aa-b24f-c5f15c16630d@suse.com> Date: Mon, 27 Jan 2025 17:30:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v2 35/65] Moxie: use is_whitespace() From: Jan Beulich To: Binutils References: <2316ac5c-7870-4b46-9c80-eaecaef93a31@suse.com> Content-Language: en-US Cc: Anthony Green Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <2316ac5c-7870-4b46-9c80-eaecaef93a31@suse.com> X-Spam-Status: No, score=-3022.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org Wherever blanks are permissible in input, tabs ought to be permissible, too. This is particularly relevant when -f is passed to gas (alongside appropriate input). Also convert ISSPACE() uses. At the same time use is_end_of_stmt() instead of an open-coded check in adjacent code. While at it also drop a redundant whitespace skipping loop. --- v2: New. --- a/gas/config/tc-moxie.c +++ b/gas/config/tc-moxie.c @@ -163,13 +163,13 @@ md_assemble (char *str) int nlen = 0; /* Drop leading whitespace. */ - while (*str == ' ') + while (is_whitespace (*str)) str++; /* Find the op code end. */ op_start = str; for (op_end = str; - *op_end && !is_end_of_line[*op_end & 0xff] && *op_end != ' '; + !is_end_of_stmt (*op_end) && !is_whitespace (*op_end); op_end++) nlen++; @@ -193,7 +193,7 @@ md_assemble (char *str) { case MOXIE_F2_A8V: iword = (1<<15) | (opcode->opcode << 12); - while (ISSPACE (*op_end)) + while (is_whitespace (*op_end)) op_end++; { expressionS arg; @@ -214,7 +214,7 @@ md_assemble (char *str) break; case MOXIE_F1_AB: iword = opcode->opcode << 8; - while (ISSPACE (*op_end)) + while (is_whitespace (*op_end)) op_end++; { int dest, src; @@ -224,7 +224,7 @@ md_assemble (char *str) op_end++; src = parse_register_operand (&op_end); iword += (dest << 4) + src; - while (ISSPACE (*op_end)) + while (is_whitespace (*op_end)) op_end++; if (*op_end != 0) as_warn (_("extra stuff on line ignored")); @@ -232,7 +232,7 @@ md_assemble (char *str) break; case MOXIE_F1_A4: iword = opcode->opcode << 8; - while (ISSPACE (*op_end)) + while (is_whitespace (*op_end)) op_end++; { expressionS arg; @@ -240,7 +240,7 @@ md_assemble (char *str) int regnum; regnum = parse_register_operand (&op_end); - while (ISSPACE (*op_end)) + while (is_whitespace (*op_end)) op_end++; iword += (regnum << 4); @@ -266,7 +266,7 @@ md_assemble (char *str) case MOXIE_F1_M: case MOXIE_F1_4: iword = opcode->opcode << 8; - while (ISSPACE (*op_end)) + while (is_whitespace (*op_end)) op_end++; { expressionS arg; @@ -284,19 +284,19 @@ md_assemble (char *str) break; case MOXIE_F1_NARG: iword = opcode->opcode << 8; - while (ISSPACE (*op_end)) + while (is_whitespace (*op_end)) op_end++; if (*op_end != 0) as_warn (_("extra stuff on line ignored")); break; case MOXIE_F1_A: iword = opcode->opcode << 8; - while (ISSPACE (*op_end)) + while (is_whitespace (*op_end)) op_end++; { int reg; reg = parse_register_operand (&op_end); - while (ISSPACE (*op_end)) + while (is_whitespace (*op_end)) op_end++; if (*op_end != 0) as_warn (_("extra stuff on line ignored")); @@ -305,7 +305,7 @@ md_assemble (char *str) break; case MOXIE_F1_ABi: iword = opcode->opcode << 8; - while (ISSPACE (*op_end)) + while (is_whitespace (*op_end)) op_end++; { int a, b; @@ -329,7 +329,7 @@ md_assemble (char *str) } op_end++; iword += (a << 4) + b; - while (ISSPACE (*op_end)) + while (is_whitespace (*op_end)) op_end++; if (*op_end != 0) as_warn (_("extra stuff on line ignored")); @@ -337,7 +337,7 @@ md_assemble (char *str) break; case MOXIE_F1_AiB: iword = opcode->opcode << 8; - while (ISSPACE (*op_end)) + while (is_whitespace (*op_end)) op_end++; { int a, b; @@ -361,7 +361,7 @@ md_assemble (char *str) op_end++; b = parse_register_operand (&op_end); iword += (a << 4) + b; - while (ISSPACE (*op_end)) + while (is_whitespace (*op_end)) op_end++; if (*op_end != 0) as_warn (_("extra stuff on line ignored")); @@ -369,7 +369,7 @@ md_assemble (char *str) break; case MOXIE_F1_4A: iword = opcode->opcode << 8; - while (ISSPACE (*op_end)) + while (is_whitespace (*op_end)) op_end++; { expressionS arg; @@ -394,7 +394,7 @@ md_assemble (char *str) op_end++; a = parse_register_operand (&op_end); - while (ISSPACE (*op_end)) + while (is_whitespace (*op_end)) op_end++; if (*op_end != 0) as_warn (_("extra stuff on line ignored")); @@ -404,7 +404,7 @@ md_assemble (char *str) break; case MOXIE_F1_ABi2: iword = opcode->opcode << 8; - while (ISSPACE (*op_end)) + while (is_whitespace (*op_end)) op_end++; { expressionS arg; @@ -412,7 +412,7 @@ md_assemble (char *str) int a, b; a = parse_register_operand (&op_end); - while (ISSPACE (*op_end)) + while (is_whitespace (*op_end)) op_end++; if (*op_end != ',') @@ -448,7 +448,7 @@ md_assemble (char *str) } op_end++; - while (ISSPACE (*op_end)) + while (is_whitespace (*op_end)) op_end++; if (*op_end != 0) as_warn (_("extra stuff on line ignored")); @@ -458,7 +458,7 @@ md_assemble (char *str) break; case MOXIE_F1_AiB2: iword = opcode->opcode << 8; - while (ISSPACE (*op_end)) + while (is_whitespace (*op_end)) op_end++; { expressionS arg; @@ -499,10 +499,7 @@ md_assemble (char *str) op_end++; b = parse_register_operand (&op_end); - while (ISSPACE (*op_end)) - op_end++; - - while (ISSPACE (*op_end)) + while (is_whitespace (*op_end)) op_end++; if (*op_end != 0) as_warn (_("extra stuff on line ignored")); @@ -512,14 +509,14 @@ md_assemble (char *str) break; case MOXIE_F2_NARG: iword = opcode->opcode << 12; - while (ISSPACE (*op_end)) + while (is_whitespace (*op_end)) op_end++; if (*op_end != 0) as_warn (_("extra stuff on line ignored")); break; case MOXIE_F3_PCREL: iword = (3<<14) | (opcode->opcode << 10); - while (ISSPACE (*op_end)) + while (is_whitespace (*op_end)) op_end++; { expressionS arg; @@ -535,7 +532,7 @@ md_assemble (char *str) break; case MOXIE_BAD: iword = 0; - while (ISSPACE (*op_end)) + while (is_whitespace (*op_end)) op_end++; if (*op_end != 0) as_warn (_("extra stuff on line ignored")); @@ -547,7 +544,7 @@ md_assemble (char *str) md_number_to_chars (p, iword, 2); dwarf2_emit_insn (2); - while (ISSPACE (*op_end)) + while (is_whitespace (*op_end)) op_end++; if (*op_end != 0)