From patchwork Wed May 29 08:07:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 91076 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B3F1C3870C33 for ; Wed, 29 May 2024 08:08:18 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by sourceware.org (Postfix) with ESMTPS id EE40A3870921 for ; Wed, 29 May 2024 08:07:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EE40A3870921 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EE40A3870921 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::534 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716970069; cv=none; b=cMKGAmS7yENcG9mR7Y9921M+rDvxlJDDGUNBivSoWBofK9UGjh4BTZnhJeXBo4C9FJKa/IzMG5v4yoZIJYMHN7kcnZqG7Ar7wcH1daBY+64VGXpi7UdeY5uxmxw3N+nbfu0+EcCfn4QjxXVfPpNkott5PnF/HGElhoAXuNuzb/M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716970069; c=relaxed/simple; bh=2WzUURG1ohWdSUQDJuO7V/TVBQzXhaZS9qV75ML4nuc=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=JfJo6OWGE+iz1I4tXEH5glEKsGEP7brGXxXHnCeaeaJDk1FUzCAuorDCPaINeayxdP3zVbVTl97+LXDLt/6F9tAwJ4ZL98qV47K3YqKrwS3mUcadPCGPOeJ7emGh1plg4N50FiHhxetJgiVPf8lzJQ/N6MMUHA9Tuw0uUf7Pcx8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-578517c7ae9so2078189a12.3 for ; Wed, 29 May 2024 01:07:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1716970065; x=1717574865; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=SOnU/2jWXb1CgsxagO2dVe6PCuTgpPOayW7HbROCKFU=; b=VAh8E5vX7GDjCQhpub7hBBvtjDUVCxTkTALIG2sKZeiBQKQMGhRKOS1BUcqNJ1rYRj fAHSL1t3NCQzKn5O814XF74lemRmc8D1WM15hFv2yXKdE+gWlfQKBgToiMmKJD8TYg+D cOJ1YSifm+/18IuxTwIvgQ8ydbpHkZq14M/3xldVQNvYiZj9aD0Gdc/c40kaXWryNcOv tbK2ch7ikrcMHIbQRPyFh6pFmwTdz2BlLEU7/2lmwtM3vYrTWDHQI1YTMjUWFiqRrcNL eg+smy6NyId7lGtuTCS+JuF5jUyygr94flEMfpJXvNaWzz9R/LMF/ZLx5NDa049bkAfh mWDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716970065; x=1717574865; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SOnU/2jWXb1CgsxagO2dVe6PCuTgpPOayW7HbROCKFU=; b=SrF+HISh1GqSYVrWflGKtXtfcXsfLYyIB7oglpIdTsVzkYgj2+Pt+APWfk2W2lhwLk qGJRcj/JrPSVvj080LFOj2CvBbqZvgkQ9OHQhbUYP6rzh78h0fWQ3YPW0K3BqgqCANeD zx2/53VJYNoB1FapmWtUQOZBgVZ72vYljYulgz8yjsVvg9RuWRgmGTBAhIetkIpofbXh dH6Wg0u04qOtjiEUzS6MwGxmexagO94OprissTT2bIn5tGQiJG7cZOZCPo8DsrVGNW+q z6UIPidbBBJ7bL0sBfbnZ6RmQudjBWcqOekJ6eC1+t2Y0OzL9fNSC5y/wdGueUSw6TwN kfxQ== X-Gm-Message-State: AOJu0Yzn/LN1ygrZpH9o1gRT9oR1+iUIvVOy66n59Wcp8JS8i0UVoyw1 GebrDugejowVRhHPmfmGLleD+5iyvg68TOygVPjrYw+r45cymfWlsIGj1E7d21yZq3zMp3CyROc = X-Google-Smtp-Source: AGHT+IEqI8hC0lNz1p7c5LdJLqnztoOe/4sE/D95/L6nnTG6G99DB5P2aTqgKNZpDrrDHdemyP4QAA== X-Received: by 2002:a50:999a:0:b0:578:5f1b:421a with SMTP id 4fb4d7f45d1cf-5785f1b434bmr8486093a12.27.1716970065501; Wed, 29 May 2024 01:07:45 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5786957ec9esm5992014a12.1.2024.05.29.01.07.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 May 2024 01:07:45 -0700 (PDT) Message-ID: <0acf17ee-350c-4e8e-81bf-aee531b2b3da@suse.com> Date: Wed, 29 May 2024 10:07:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 1/3] x86/APX: support extended SETcc form From: Jan Beulich To: Binutils Cc: Lili Cui , "H.J. Lu" References: Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: X-Spam-Status: No, score=-3024.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+patchwork=sourceware.org@sourceware.org As indicated during review, spelling/readability-wise setz %eax is easier than setzuz %al _and_ properly specifies the full register that's being modified. Permit that form to be used, even if the spec writers are unwilling to formally mention it. While there also correct the non-ZU EVEX form: That ought to also permit memory operands. --- In principle SETZUcc ought to also permit for memory operands, for (as per the spec) EVEX.ZU simply being ignored in that case. However, such forms are rather meaningless, so I'm not convinced we really want to permit that. --- a/gas/testsuite/gas/i386/x86-64-apx-zu-intel.d +++ b/gas/testsuite/gas/i386/x86-64-apx-zu-intel.d @@ -42,6 +42,9 @@ Disassembly of section .text: \s*[a-f0-9]+:\s*62 dc 7f 18 4f c1[ ]+setzug r25b \s*[a-f0-9]+:\s*d5 91 9f c1[ ]+setg r25b \s*[a-f0-9]+:\s*62 f4 7f 08 4f c0[ ]+\{evex\} setg al +\s*[a-f0-9]+:\s*62 f4 7f 08 4f 00[ ]+\{evex\} setg (BYTE PTR )?\[rax\] +\s*[a-f0-9]+:\s*62 f4 7f 18 4a c0[ ]+setzup al +\s*[a-f0-9]+:\s*62 f4 ff 18 4b c0[ ]+setzunp al \s*[a-f0-9]+:\s*62 f4 7d 18 6b c3 0a[ ]+imulzu ax,bx,0xa \s*[a-f0-9]+:\s*67 62 f4 7d 18 6b 00 0a[ ]+imulzu ax,WORD PTR \[eax\],0xa \s*[a-f0-9]+:\s*62 ec 7d 18 6b c1 0a[ ]+imulzu r16w,r17w,0xa --- a/gas/testsuite/gas/i386/x86-64-apx-zu.d +++ b/gas/testsuite/gas/i386/x86-64-apx-zu.d @@ -42,6 +42,9 @@ Disassembly of section .text: \s*[a-f0-9]+:\s*62 dc 7f 18 4f c1[ ]+setzug %r25b \s*[a-f0-9]+:\s*d5 91 9f c1[ ]+setg %r25b \s*[a-f0-9]+:\s*62 f4 7f 08 4f c0[ ]+\{evex\} setg %al +\s*[a-f0-9]+:\s*62 f4 7f 08 4f 00[ ]+\{evex\} setg \(%rax\) +\s*[a-f0-9]+:\s*62 f4 7f 18 4a c0[ ]+setzup %al +\s*[a-f0-9]+:\s*62 f4 ff 18 4b c0[ ]+setzunp %al \s*[a-f0-9]+:\s*62 f4 7d 18 6b c3 0a[ ]+imulzu \$0xa,%bx,%ax \s*[a-f0-9]+:\s*67 62 f4 7d 18 6b 00 0a[ ]+imulzu \$0xa,\(%eax\),%ax \s*[a-f0-9]+:\s*62 ec 7d 18 6b c1 0a[ ]+imulzu \$0xa,%r17w,%r16w --- a/gas/testsuite/gas/i386/x86-64-apx-zu.s +++ b/gas/testsuite/gas/i386/x86-64-apx-zu.s @@ -36,6 +36,9 @@ _start: setzug %r25b setg %r25b {evex} setg %al + {evex} setg (%rax) + setpe %eax + setpo %rax .intel_syntax noprefix imulzu ax,bx, 10 --- a/opcodes/i386-opc.tbl +++ b/opcodes/i386-opc.tbl @@ -533,8 +533,11 @@ loopne, 0xe0, x64, JumpByte|No_bSuf|No_w // Set byte on flag instructions. set, 0xf9/0, i386, Modrm|No_wSuf|No_lSuf|No_sSuf|No_qSuf, { Reg8|Unspecified|BaseIndex } -set, 0xf24/0, APX_F, Modrm|No_wSuf|No_lSuf|No_sSuf|No_qSuf|VexWIG|EVexMap4, { Reg8 } +set, 0xf24/0, APX_F, Modrm|No_wSuf|No_lSuf|No_sSuf|No_qSuf|VexWIG|EVexMap4, { Reg8|Unspecified|BaseIndex } setzu, 0xf24/0, APX_F, Modrm|No_wSuf|No_lSuf|No_sSuf|No_qSuf|VexWIG|EVexMap4|ZU, { Reg8 } +// As an extension, allow SETcc without the ZU infix, instead taking the full +// register as operand. +set, 0xf24/0, APX_F, Modrm|No_bSuf|No_sSuf|EVexMap4|ZU, { Reg32|Reg64 } // String manipulation. cmps, 0xa6, 0, W|No_sSuf|RepPrefixOk|IntelSuffix, {}