Message ID | 08cbe4df-67e3-43aa-a2fb-4bbd041ffbf5@suse.com |
---|---|
State | New |
Headers |
Return-Path: <binutils-bounces~patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8B5673857C63 for <patchwork@sourceware.org>; Mon, 27 Jan 2025 16:55:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8B5673857C63 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256 header.s=google header.b=bKxj2vyN X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by sourceware.org (Postfix) with ESMTPS id CBA6B3857C47 for <binutils@sourceware.org>; Mon, 27 Jan 2025 16:36:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CBA6B3857C47 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CBA6B3857C47 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::62e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737995769; cv=none; b=WOgeOJMhvJQ3IUk8qA8k2w13w50koa1PDAdsv+9hyMw0qK2hdTObnpFAtpcsJpO4RwqcHDaFaYjp5yz8pXPBD+OLiG5U9x41pnUCu3G9gMuNChMyqeYXSX7IHetadLyvwEKL473DMgYBa1Tw26TGLKET5soQBcrK6Thg7aEqFAU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737995769; c=relaxed/simple; bh=vFpZezb3uv/75+NeRb7Jb/i6zciSITU38cK+1wgihaU=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=DjDKAbYAQmrrzuCfxg58gcurLU79ZOVjPM4tOzUpQXlfuao+qGg4F0p25fh7e/EnXMj6xikJGSTxkRsCBijNsNukUuomdEtJj6YXAr/Ax/SxINbLptm2cVsyG03t9UwqBHIuqyFDRM+h/MxWm0+fnbXl/EnviT/GTObRQMWf9vk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CBA6B3857C47 Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-ab2bb0822a4so910894266b.3 for <binutils@sourceware.org>; Mon, 27 Jan 2025 08:36:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1737995767; x=1738600567; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:cc:content-language :references:to:from:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/v6kIpU1Nocpn7GF4yEovz4k8Ce4mYh7AObaOMCmVKo=; b=bKxj2vyND6lfUVp5Xf4HzoQ1YCWBA1sXh3lzVBM36Pzczeb2UnghsUKYuYyF5DmKL5 869Itt/QwJbP5ew7qja9nkgbPmsWcXv4wvjCkoG70ODPbKUS/WGW45u3qro7nWSiz43f mfkSBiL4Jv7TM7ApvSMfkW7fGW/xnjOXHC0OQkte7SbW6FA057U0leBpJWneCf0/Np3b eMzLBchQLsalJD9nX9FnR9n0Rc9NK8hINt0G3mmkzIs8xv43DpGfr9+mgYggqfFYsIcM tBLz88kh1YL6DYh+K1hOx3aHb/9Twj6kCZTpDXqpmwd0XAPbzMMJte4nfqkbsSXBYhJy Dlmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737995767; x=1738600567; h=content-transfer-encoding:in-reply-to:autocrypt:cc:content-language :references:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/v6kIpU1Nocpn7GF4yEovz4k8Ce4mYh7AObaOMCmVKo=; b=gPPEvJrumFP2dl+FTheRWLA47iBR8huxnwa8d0eSWUNM4SRkDC9mFWpuopDpM49F9U JqImC2L9JAX/6cMTZt/knVgldPGbnXmEAzAPZcA51RvHRcbn/oupwnzyp0Jh4xz+jgCC DB2hjZyxPkaWahsdrdUrqu5HpdkUP3eg7Z12oewAa84Njx9nHq9eBXUsHZhDCGwJAKPn 4rfyvtJM9f2g4p4S9M63YLcBtT+uR3okt3RPWXjn1OuQZrj30CECY/6u+n1Rp1bmYyuL 1N3x0yQXM8Ih+yiuHQezFOQ8vKphrA/SE2nbDOuGJfcfDCIf3sB7uyFZzH28m5KRhSCE rmgg== X-Gm-Message-State: AOJu0YwATPq1drQM005pv3Tpcc0qtTAl4UDi37vzMadKPEnPNwoyRASz welACr4rotrS8mUfoNGE/gqZonBBclRhXNjU/mff5UZjg0+PUdUXZZ+y+dE5RzijiZYrs55w/Wg = X-Gm-Gg: ASbGncse/2BKw/0Q5IzmEiycoZdpsCLxkiR/8Vtv4YueE/p0SvEYl/VqdFhxBh059OP zBgyWWtpBYnFZU1ONKRFza0ahRh9fBAnby7rNI/3TddFsHTbhKdG5ykh3TDHhgFfkDWoHppreoM g3O2EA9zMOOs0zDFYtWwgI2+WLJFGT6oxZ5wJdkssuGeljVt5Xiv9F+j3xf7YzA87LO4rpPxOMb 93s+rD2fgP9XKBrp3RmvwpNo47y13BgBs/Lk7vhP7uVAFn+vA/p1oSxxNjyrQSVzT/u9zwAfwFG Y1agkK6Upxrk+UwlSj/nz+VGawt8s9I7nWg817Ug+zrTeNcOcVMvnkuYnZHSPZYJeA== X-Google-Smtp-Source: AGHT+IH+Udb9IHmS0c+ZiEY4N0GbBi8pgGwrcpRT2PIgjkjBgkMSG5RgLI3hzq/u274zxIUFuWxPaA== X-Received: by 2002:a17:906:80c4:b0:ab6:37c5:12b6 with SMTP id a640c23a62f3a-ab637c5155bmr1962400166b.7.1737995767451; Mon, 27 Jan 2025 08:36:07 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab675e65f54sm601707666b.72.2025.01.27.08.36.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Jan 2025 08:36:07 -0800 (PST) Message-ID: <08cbe4df-67e3-43aa-a2fb-4bbd041ffbf5@suse.com> Date: Mon, 27 Jan 2025 17:36:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v2 46/65] s12z: use is_whitespace() From: Jan Beulich <jbeulich@suse.com> To: Binutils <binutils@sourceware.org> References: <2316ac5c-7870-4b46-9c80-eaecaef93a31@suse.com> Content-Language: en-US Cc: John Darrington <john@darrington.wattle.id.au> Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <2316ac5c-7870-4b46-9c80-eaecaef93a31@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3022.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list <binutils.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/binutils>, <mailto:binutils-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/binutils/> List-Post: <mailto:binutils@sourceware.org> List-Help: <mailto:binutils-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/binutils>, <mailto:binutils-request@sourceware.org?subject=subscribe> Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org |
Series |
gas: whitespace handling
|
|
Checks
Context | Check | Description |
---|---|---|
linaro-tcwg-bot/tcwg_binutils_build--master-arm | success | Build passed |
linaro-tcwg-bot/tcwg_binutils_check--master-arm | success | Test passed |
linaro-tcwg-bot/tcwg_binutils_build--master-aarch64 | success | Build passed |
linaro-tcwg-bot/tcwg_binutils_check--master-aarch64 | success | Test passed |
Commit Message
Jan Beulich
Jan. 27, 2025, 4:36 p.m. UTC
Convert open-coded checks. At the same time use is_end_of_stmt() instead of open-coded checks in adjacent code. This then also fixes the prior use of a wrong cast for an array index: Plain char may, after all, be signed. --- v2: New.
--- a/gas/config/tc-s12z.c +++ b/gas/config/tc-s12z.c @@ -207,7 +207,7 @@ s12z_init_after_args (void) static char * skip_whites (char *p) { - while (*p == ' ' || *p == '\t') + while (is_whitespace (*p)) p++; return p; @@ -347,7 +347,7 @@ static bool lex_match_string (const char *s) { char *p = input_line_pointer; - while (p != 0 && *p != '\t' && *p != ' ' && *p != '\0') + while (p != 0 && !is_whitespace (*p) && !is_end_of_stmt (*p)) { p++; } @@ -3790,7 +3790,7 @@ md_assemble (char *str) /* Find the opcode end and get the opcode in 'name'. The opcode is forced lower case (the opcode table only has lower case op-codes). */ for (op_start = op_end = str; - *op_end && !is_end_of_line[(int)*op_end] && *op_end != ' '; + !is_end_of_stmt (*op_end) && !is_whitespace (*op_end); op_end++) { name[nlen] = TOLOWER (op_start[nlen]);