From patchwork Wed Sep 27 15:50:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 76781 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F3AA03889E31 for ; Wed, 27 Sep 2023 15:51:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F3AA03889E31 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1695829919; bh=rSZGLxusZw0m4PXR5mJRXw/xTy3JjpeB7JaUwkyil0w=; h=Date:Subject:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=eZb6z/AbhJKDZXkW51t7YTzd2emPXlpCobrCEtFoNkXbxSv7rdfmEm+4ejQLI7lef b9zaaCyjX73A6xB8zbJyrariK47jqsKtqZvgLayCaxw1WK0rFbNIxnOqMvQTBuoL6v J1RdhmkNTyJK3/1h3pM4Fm1J5VuOzbnfqhn7JfG0= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2051.outbound.protection.outlook.com [40.107.22.51]) by sourceware.org (Postfix) with ESMTPS id F2B16388265A for ; Wed, 27 Sep 2023 15:50:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F2B16388265A ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UAjh0fIQqWSDzr3JQeqlO7poUTf2y+PZN+fbNy117Wnt49PxNXBi/FHkLC8J7e1fy3CZyl/O1TgF7MoxRs59dvNbeuGNKmsEUOgeaMfPQJkXfGeNHtbRcJsEnJ1vDEf1TL09dTkEfB1RZlE0YWKtCEr4Ut/lM6o//npeQBwxA+Z9CjWS1Mtj1CrURs8cGmYl13uzQ9UeaYSTScZnTMmQdiJnDG6i4F26J81USvxPkcMT4GGGK87LJbJqeCUsVOsP0PuaNr7xGMiyFLzfgFpdeqVanmMMQL0mNdr5qoElAhyqh6cAW/WF13Cvk/Cw39VJ/yqZLxEF79SzumBhRc20BA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rSZGLxusZw0m4PXR5mJRXw/xTy3JjpeB7JaUwkyil0w=; b=JOddlKiLmwMC4LkjQ95nYQJ63ofhFaDVMvDigVbGlX9hKcgtU9+sqHl9USGi7jAlQRA+IcYGPVrSsNAYgj246aMgna2P7eBVLmeHEi91kC2KU5iksmpaTn3FNR9waig4gXJYvYZrbM7Mp070g6+pMGNp2ryA1RWvYYHu39uUv6+zoWIDtpTyW+ajpjK83lUkuPguYG8jpoNXrD0XACnfLBlOqpoAdlwcEDlW12pQIvaZYcKawLScqr+lMfYcs4/WiZSNLusTmsr0RTTP3RvntIVpswwmqimGkZ81JJjvC7lJfRK0EKp+yfAQwzuAdfVSW5g0w4LVH6q3uSVZz443RQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from AS8PR04MB8788.eurprd04.prod.outlook.com (2603:10a6:20b:42f::21) by PAXPR04MB9138.eurprd04.prod.outlook.com (2603:10a6:102:22d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.28; Wed, 27 Sep 2023 15:50:42 +0000 Received: from AS8PR04MB8788.eurprd04.prod.outlook.com ([fe80::afae:3fda:c84d:bcdc]) by AS8PR04MB8788.eurprd04.prod.outlook.com ([fe80::afae:3fda:c84d:bcdc%7]) with mapi id 15.20.6838.016; Wed, 27 Sep 2023 15:50:42 +0000 Message-ID: <02623925-0b8f-4699-34d1-0ecc03dd2d9c@suse.com> Date: Wed, 27 Sep 2023 17:50:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: [PATCH 06/11] x86: i686 != PentiumPro Content-Language: en-US To: Binutils Cc: "H.J. Lu" References: <7ce54bc2-fef2-d2e4-21fd-202fdead0c20@suse.com> In-Reply-To: <7ce54bc2-fef2-d2e4-21fd-202fdead0c20@suse.com> X-ClientProxiedBy: FR2P281CA0048.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:92::19) To AS8PR04MB8788.eurprd04.prod.outlook.com (2603:10a6:20b:42f::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8788:EE_|PAXPR04MB9138:EE_ X-MS-Office365-Filtering-Correlation-Id: c6066ff8-c2a8-4ae3-de96-08dbbf71816f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: c6V42AZtRYEjG3yXgSX7cNcMKNWX39vBIfjAw2cFfxQdtuKOgPjZ/OhpvvVY3a52BoeLXWl+npD5/qzzLMNtF2+GHQLKyDSP798KeXHDhenI7UgrXpNSYHuymA8aF9o+LTY6d21NiVBs/Tz/P6yBQQZ9wDyr3ELIfZ7yYn3hUg1rZ+KhUwXt1ZCs7IDQB+JM/iTAQt87h/uKcu9YGAVZA0VKwdSQg3USIK/QIQKXUcDDifZND6AAIxzXof9m3iNv1J960+m+yJzJh5Pr4GqttEoSM2kKfEPVXAvVu6MOCEXGrgeWoaoV75Lu1QoHs9ZEb3mljLUYw6cN6BCBy/hqFR0OPFdKFsEPJEfNrm5PwSJjdNkHv27osNA5i4/WDNIzm3uO1JIxPBExdkDga9Qvy6cTK9/4EKqdrnHpgjCMUKLod0Ncm3NQIenT+H+5EToC3N9FZdqW5dXlym6UCkTKe+lZtd4Ko1HxFz4VEA8sZUQMQ41/5mBVU+jTNo58nI0fqKvUk9HNFD9/270di4i7bB2TmpIoySRcsNDNxGCfRP/K6kYI8MnmbbndPb+IsVwsdtmBerGan6z2v+CS7XVu+Bytb60bwVwW3yHWPgHvuijNpRfaH1OmN3PbVtRrp4nlrra5uLGW5OIVtAgoD1cHrg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR04MB8788.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(396003)(346002)(366004)(376002)(39860400002)(230922051799003)(1800799009)(451199024)(186009)(6512007)(6506007)(2616005)(8936002)(26005)(2906002)(478600001)(4326008)(66556008)(66476007)(6916009)(66946007)(316002)(5660300002)(41300700001)(8676002)(36756003)(31696002)(6486002)(38100700002)(86362001)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?cGvsJnMrhJIptMuWHno5oDf5LgBQ?= =?utf-8?q?C3/znZ/O79hkVZxmD2w9L5aOiRB0GN2A3iwM2fxF6ObfYLZ8nJOQAUHoYFKYeGS9v?= =?utf-8?q?LGDKNK+SpSkyb0VRahJTTsIZ8EU8cA4lNIaUK1zPG+iUTKtcNST8AOgx4W18ocZEm?= =?utf-8?q?huM5oXralY2/gNo1Qqpj6tnPwJjAvRROQW6uwCQ3oe2y42O4Ks03OmoYfHIzzscAD?= =?utf-8?q?07nwPsBV8I5fPjdOfnPKLwHw+zK6157Pd5be8qWRydrx3rSHNC4bqxRHSIFvgulb4?= =?utf-8?q?GH4tzD7q1ih7MOwjMaOto+8+bGOxVeAmoYtvUkhpn822BygyHydu3mLQ5b1GoNXv8?= =?utf-8?q?Dha75OrSKu4l5DFdlMsGHxusOizGn7Zx7b59HwYNVFc6te5n4jsnKRvpeVZZVHnk6?= =?utf-8?q?UGDTVxQDPUVUcuDivTQPgZMDTVLz/N/K8yVK2N5dNm49tuO6XzzP3Ma8TBqd4KBCl?= =?utf-8?q?NghslHNhw2H6G9TKnSM93KzECvsv5uha7Oxxwt3fGdtpo8ij1fNWJUanZ/mS2EVkv?= =?utf-8?q?l44sqYgcRJ41uMHQxrUEbQQW/kRgp9fYwsmoPwno8s9XrmUtQZo/kIGYTmUQ0Vae2?= =?utf-8?q?v1e+CWQszW/WTF7rzQ/HmhUJ6cfTUL7y0oGEp9He7y7LgFAPNkhr55Lv4W4XbxQt2?= =?utf-8?q?QVo1k7+PUQP9Dp9sPaREng2qFOaK27VbJobeOv6BzPTgEn5xR9h2NfGco+053Hyei?= =?utf-8?q?Z0ScBJFoxMbc739GJ0Qzajn6+BREmSZtT9l0nT8PE7ESw9uu5iwGsFjsKwIoHooU4?= =?utf-8?q?/4xffGPZTNSJAr9+xEWIYIHtTHnS657SWcaJfPfFScKFydkWPoUxewYaPgTtzltZf?= =?utf-8?q?fWfaUw9GpS6/OITShYx2i2rfqYfL/QQXPUYS0rjoc05vJCmo9mfmu4B27Xxf9B0tx?= =?utf-8?q?qeJRbqcjm/E6s/0A8qlRS+NFzj196OG4df172x1FuZ0ABhW4sv+PSYzdHB71Ds54k?= =?utf-8?q?Xuy0dTSt0duG1njD2L33wIZnizLaVr9WS7hoILCsgwb+JlioQ1dV7m7HHD/m76fSa?= =?utf-8?q?AJjv/99HIBG8nV090A+Z32fJmCM34qSqoVB+gAGQckMloGyZ7Ne7NROhLm808SRdX?= =?utf-8?q?4Mt6PEnF4mJFZj1JoYaEEpgokvCPEulAnVkb/zT86sRCbajfqx75Sj3TuHvIFcYfk?= =?utf-8?q?j+WF/QWnovrRK38XhYAcDExCYlma4X5LGlwt0Jroy79mn/l1GCBb9gdr1chuJH7zV?= =?utf-8?q?RQbOiRMTnlbQOI7zYkSTWp+Hw4j4gERlCoxVZjzr97Go/zHFZznRQ4I/kg30JmXqT?= =?utf-8?q?A9xfjPCG6kuWEy6VPx2nuPgYjVDYCllLq8Jkixo9FJnpm1ZeI6wO71fTos0S03Toh?= =?utf-8?q?V2BcAJ+vxxjimf53gPIZH7oEQnls3vqYGVw6hMAZH57REQLM8ovjPfdzhT421WMdb?= =?utf-8?q?kWAVq0J0CMCTgMmkFAyQNwPc+8xEptQZalw3wI7A7I6vH6tf7JBMeei5sXaCxYvnB?= =?utf-8?q?HVy84zIxhEsrstALZGaz7gViXEEu1cJ1/vn/UljS0xsxmpBjAIJu4cXTMPaZn5fhH?= =?utf-8?q?D7csl1E69Oyv?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c6066ff8-c2a8-4ae3-de96-08dbbf71816f X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8788.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2023 15:50:42.7853 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: m1BkkqUeXNtftXu4xTNMKRFHZkItoX7VFC+1LjaIogKrpYVmvackGFZLWrHR4oxRM/lFjk4YIomjT/gZYVtNTQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9138 X-Spam-Status: No, score=-3026.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jan Beulich via Binutils From: Jan Beulich Reply-To: Jan Beulich Errors-To: binutils-bounces+patchwork=sourceware.org@sourceware.org Sender: "Binutils" The two are distinct in opcodes/, distinguished precisely by CpuNOP that's relevant in i386_generate_nops(), yet the function has the PPro case label in the other group. Simply removing it revealed that cpu_arch[] had a wrong entry for i686. While there also add PROCESSOR_IAMCU to the respective comment. --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -987,8 +987,8 @@ static const arch_entry cpu_arch[] = ARCH (i386, I386, 386, false), ARCH (i486, I486, 486, false), ARCH (i586, PENTIUM, 586, false), - ARCH (i686, PENTIUMPRO, 686, false), ARCH (pentium, PENTIUM, 586, false), + ARCH (i686, I686, 686, false), ARCH (pentiumpro, PENTIUMPRO, PENTIUMPRO, false), ARCH (pentiumii, PENTIUMPRO, P2, false), ARCH (pentiumiii, PENTIUMPRO, P3, false), @@ -1440,7 +1440,7 @@ i386_generate_nops (fragS *fragP, char * /* We need to decide which NOP sequence to use for 32bit and 64bit. When -mtune= is used: - 1. For PROCESSOR_I386, PROCESSOR_I486, PROCESSOR_PENTIUM and + 1. For PROCESSOR_I?86, PROCESSOR_PENTIUM, PROCESSOR_IAMCU, and PROCESSOR_GENERIC32, f32_patt will be used. 2. For the rest, alt_patt will be used. @@ -1473,6 +1473,8 @@ i386_generate_nops (fragS *fragP, char * if (fragP->tc_frag_data.isa_flags.bitfield.cpunop) patt = alt_patt; break; + + case PROCESSOR_PENTIUMPRO: case PROCESSOR_PENTIUM4: case PROCESSOR_NOCONA: case PROCESSOR_CORE: @@ -1493,7 +1495,7 @@ i386_generate_nops (fragS *fragP, char * case PROCESSOR_I386: case PROCESSOR_I486: case PROCESSOR_PENTIUM: - case PROCESSOR_PENTIUMPRO: + case PROCESSOR_I686: case PROCESSOR_IAMCU: case PROCESSOR_GENERIC32: break; --- a/gas/config/tc-i386.h +++ b/gas/config/tc-i386.h @@ -242,6 +242,7 @@ enum processor_type PROCESSOR_I386, PROCESSOR_I486, PROCESSOR_PENTIUM, + PROCESSOR_I686, PROCESSOR_PENTIUMPRO, PROCESSOR_PENTIUM4, PROCESSOR_NOCONA,