mbox series

[v3,0/9] gas: scrubber adjustments

Message ID 7e951d11-cccf-4851-84a6-3a85cda8254a@suse.com
Headers
Series gas: scrubber adjustments |

Message

Jan Beulich July 31, 2024, 11:51 a.m. UTC 
  The end goal is to finally deal with long standing issues in, in
particular, macro handling (see e.g. b3446f947bd1 ["gas: retain
whitespace between strings"]). That's the second to final patch.

One of the issues I'm facing in dealing with target specific
adjustments is that there are 5 gas targets which don't even have a
testsuite subdir:
- m32c (no maintainer)
- moxie
- ns32k (no maintainer)
- spu (Alan confirmed no expected issues)
- tic30 (no maintainer)
How is one supposed to have even the slightest idea whether a common
code change breaks such a target (Cc-ing the two maintainers of the
named targets which have one)? I'm already worried enough by targets
having only a pretty "slim" set of test cases. In any event, target
specific changes made in that final patch don't go much beyond what is
needed to have the testsuite pass. I'm pretty sure further changes are
going to be needed in perhaps many places; while I'll try to deal with
those as they're being pointed out, I think target maintainers are in
a better position to change what needs changing, as they ought to have
a better idea than me where whitespace may occur and hence need
skipping.

Doing better at skipping whitespace is, to some degree at least, also
a prereq for -f (or its equivalent #NO_APP at the start of a file) to
be reliable to use. It is probably for a reason that gcc currently
doesn't use this for most targets. Work there is in progress
separately.

Compared to v2, besides re-basing, there are mainly a few more tidying
patches. All patches individually detail what has changed, if anything.

1: have scrubber also respect quoted labels
2: respect CR_EOL also for scrubbing
3: Arm: respect line separators for .symver scrubber special case
4: m32r: move scrubber override to target header
5: Arm: relax gas testsuite whitespace expectations
6: aarch64: relax gas testsuite whitespace expectations
7: MIPS: relax gas testsuite whitespace expectations
8: have scrubber retain more whitespace
9: drop scrubber states 14 and 15

Jan

Comments

Jan Beulich July 31, 2024, 11:59 a.m. UTC | #1 
In a subsequent change the scrubber is going to be changed to retain
further whitespace. Test case expectations generally would better not
depend on the specific whitespace treatment by the scrubber, unless of
course a test is specifically about it. Adjust relevant test cases to
permit blanks where those will subsequently appear.
---
This is adding just the blanks that are going to be needed; imo it would
generally be better if test case expectations were, from the very
beginning, written to focus on what is being tested, rather than taking
verbatim copies of the respective tool's output.
---
v3: Re-base.
v2: Re-base.