mbox series

[0/7] x86: templatize various ALU insn templates

Message ID 3c3a57fd-9493-4405-97b9-2b306fdcd7d1@suse.com
Headers
Series x86: templatize various ALU insn templates |

Message

Jan Beulich March 25, 2024, 10:05 a.m. UTC 
  With the multitude of new APX templates, it finally becomes desirable to
further remove redundancy by also templatizing basic arithmetic insns.

Unlike indicated previously, I think at least part of this would better
go ahead of the APX NF patch. This is because some of what needs adding
explicitly there is being added implicitly here (patches 3 and 4 at
least), in order to avoid losing templates we already had (prematurely
added by the APX NDD patch, imo).

Note that patches 4 and 5 also drop certain templates again which imo
were added by mistake in the course of the NDD work. See the descriptions
of those patches.

1: templatize INC/DEC
2: templatize unary ALU insns
3: templatize binary ALU insns
4: templatize shift/rotate insns
5: templatize shift-double insns
6: templatize ADX insns
7: templatize RAO-INT insns

Jan

Comments

Cui, Lili March 27, 2024, 4:08 a.m. UTC | #1 
> With the multitude of new APX templates, it finally becomes desirable to
> further remove redundancy by also templatizing basic arithmetic insns.
> 
> Unlike indicated previously, I think at least part of this would better go ahead of
> the APX NF patch. This is because some of what needs adding explicitly there is
> being added implicitly here (patches 3 and 4 at least), in order to avoid losing
> templates we already had (prematurely added by the APX NDD patch, imo).
> 
> Note that patches 4 and 5 also drop certain templates again which imo were
> added by mistake in the course of the NDD work. See the descriptions of those
> patches.
> 
> 1: templatize INC/DEC
> 2: templatize unary ALU insns
> 3: templatize binary ALU insns
> 4: templatize shift/rotate insns
> 5: templatize shift-double insns
> 6: templatize ADX insns
> 7: templatize RAO-INT insns
> 

Thanks for the cleanup, I reviewed the patches, and they are ok for me, I will rebase the NF patch after you submit them.

Lili.