mbox series

[0/4] Cleanup duplicate test names

Message ID 20250915154151.2595921-1-rearnsha@arm.com
Headers
Series Cleanup duplicate test names |

Message

Richard Earnshaw Sept. 15, 2025, 3:41 p.m. UTC 
  GCC's compare_tests script has recently been augmented to report
duplicate test names in the summary file.  The reason for doing this
is that if names are not unique then the test can appear to both pass
and fail in a single run, making the script unable to determine
whether or not this is a regression.

This short patch series cleans up a number of duplicate test names in
the gas component of the testsuite.  I've tried to avoid unnecessary
churn, particularly for the multiple 'as' tests, but some name changes
are inevitable since any duplicate must be resolved to a different
name.

Richard Earnshaw (4):
  testsuite: all: use unique test names for multibyte3 tests
  binutils: testsuite: avoid dup names when using multiple as:
    directives
  testsuite: elf: avoid clashing mbind test names
  testsuite; Avoid clashing names in err-sizeof.s

 binutils/testsuite/lib/binutils-common.exp | 27 +++++++++++++---------
 gas/testsuite/gas/all/err-sizeof.s         |  2 +-
 gas/testsuite/gas/all/gas.exp              |  2 +-
 gas/testsuite/gas/elf/section16b.d         |  2 +-
 4 files changed, 19 insertions(+), 14 deletions(-)

Comments

Jan Beulich Sept. 16, 2025, 2:02 a.m. UTC | #1 
On 15.09.2025 17:41, Richard Earnshaw wrote:
> GCC's compare_tests script has recently been augmented to report
> duplicate test names in the summary file.  The reason for doing this
> is that if names are not unique then the test can appear to both pass
> and fail in a single run, making the script unable to determine
> whether or not this is a regression.
> 
> This short patch series cleans up a number of duplicate test names in
> the gas component of the testsuite.  I've tried to avoid unnecessary
> churn, particularly for the multiple 'as' tests, but some name changes
> are inevitable since any duplicate must be resolved to a different
> name.
> 
> Richard Earnshaw (4):
>   testsuite: all: use unique test names for multibyte3 tests
>   binutils: testsuite: avoid dup names when using multiple as:
>     directives
>   testsuite: elf: avoid clashing mbind test names
>   testsuite; Avoid clashing names in err-sizeof.s

In the event this isn't considered obvious anyway - okay (with the one
adjustment to patch 3).

Jan